lirantal / typeform-export-excel Goto Github PK

Expected Behavior

Make sure the output filename being generated is based on a date/time so we don't override output files on every typeform export run.

Current Behavior

Filename is exported as a static, non-changing name and gets overriden.

When running

$ typeform-export-excel --apiKey test1234 --formId iGifhW --filename survey-results.xlsx --author Adriaan

Expected Behavior

I expect it to create a download file.

Current Behavior

Error: Cannot read property 'totalRespondents' of undefined

Context

Just want to download the questions, because I can't export them in the Typeform itself.

Your Environment

• Library Version used: [email protected]
• Node.js version (e.g. Node.js 5.4): v13.0.1
• Operating System and version (desktop or mobile): desktop

Test "Creating an Excel file from form matches previous sample file'"passes when the files are't the same , because expect inside 'try/catch'. Jest has issue #3917 about this problem.

There is also a problem that the actual file from "sample.xlsx" and the exported file have different sizes.

actual value to equal:
  7793
expected:
  7823

Expected Behavior

if a actual and a expected files have different sizes then test fails

Current Behavior

Test always passes.

Possible Solution

1. Remove "try/catch" because it also prevents find errors and situations where exceptions are raised.
2. Use cvle's gist

Steps to Reproduce (for bugs)

1. change expected.size or actual.size to any number
2. run test
3. test passed

Context

I met this problem when worked on #12

Your Environment

• Library Version used: 1.0.6
• Node.js version (e.g. Node.js 5.4): v12.13.1
• Operating System and version (desktop or mobile): macOS Catalina 10.15.1