Test matches passes when the files are't the same about typeform-export-excel HOT 5 CLOSED

Oh I see. That's a good catch @arszh
Not sure how I feel about that gist workaround, doesn't seem friendly. What if we just refactor the test a bit so that the expect is simply not inside a try/catch?

from typeform-export-excel.

We can declare actual and expected variables before try/catch and move down expect(expected.size).toEqual(actual.size) under try/catch, but I think it is not good.

In my opinion, maybe I wrong, we can delete the try/catch altogether because:

1. It prevents find errors and situations where exceptions are raised.
2. Test doesn't check receiving certain exceptions.
3. 'Catch' doesn't improve information from caught exception to output it.

If important to remove created file after this test:

1. It will be deleted anyway when developer fix fail and the test is passed.
2. Can use afterAll() to remove all created excel files after all tests.

from typeform-export-excel.

this is the test we're referring to, right?

    try {
      // eslint-disable-next-line
      const actual = fs.statSync(path.resolve('./__tests__/Fixtures/sample.xlsx'))
      // eslint-disable-next-line
      const expected = fs.statSync(path.resolve(testOutputFilename))

      expect(expected.size).toEqual(actual.size)
    } catch (e) {
    } finally {
      // eslint-disable-next-line
      fs.unlinkSync(testOutputFilename)
    }

in which case, the expectation is within a try/catch only for the sake of cleaning-up. In this case, how about we simply clean up in a Jest's afterAll() hook? Surely it's not as clean as with doing this within every test, but for the sake of this small lib seems not far fetched.

Looks like you are suggesting the same so 👍 from me and I'm happy to merge a PR if you have a bit of time to send it over.

from typeform-export-excel.

fixed in #18

from typeform-export-excel.

@arszh @lirantal Can you guys please suggest what should be fixed for below case, It is always passing :

test("test", () => {
  try {
    expect(true).toBe(false);
  } catch (err) {
    console.log(err);
  }
});

from typeform-export-excel.