/home/runner/work/skynet-js/skynet-js/node_modules/base32-encode/index.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){import toDataView from 'to-data-view'
                                                                                             ^^^^^^

    SyntaxError: Cannot use import statement outside a module

      1 | import base32Decode from "base32-decode";
    > 2 | import base32Encode from "base32-encode";
        | ^
      3 | import { fromByteArray, toByteArray } from "base64-js";
      4 |
      5 | import { assertUint64 } from "./number";

      at Runtime.createScriptFromCode (../node_modules/jest-runtime/build/index.js:1350:14)
      at Object.<anonymous> (utils/encoding.ts:2:1)

https://github.com/SkynetLabs/skynet-js/pull/227/checks?check_run_id=3160347860

Hi, we're using this library to encode bytes to a character set that works well with QR codes. We noticed that the input to your API is an ArrayBuffer rather than a view on that ArrayBuffer, such as a Uint8Array.

If a view were accepted instead, we wouldn't have to worry about corner cases where the underlying ArrayBuffer isn't the same size as the view. If a Uint8Array, x, is a view on an ArrayBuffer that is larger than the Uint8Array, then passing the x.buffer to the API in this library would result in it encoding outside of the view. This requires the caller to check that the underlying ArrayBuffer is the same size, and if not, create a new ArrayBuffer made by copying the data within the view.

Could your API and documentation be adjusted to accept views -- or, at least minimally, a Uint8Array view as it is likely the most common? Looking at the code, a Uint8Array is internally used to wrap the ArrayBuffer parameter. My understanding is that this wouldn't need to change if the input were a Uint8Array as opposed to an ArrayBuffer.

I'll be filing a similar issue on https://github.com/LinusU/base32-decode -- where the return value is an ArrayBuffer instead of a view on one.

Related: digitalbazaar/vpqr#2

Please add a LICENSE file with your copyright information and the full text of the MIT LICENSE. The MIT licenses requires that the full text of the license accompany the source code.

As specified by RFC4648, the padding symbol is not mandatory.

I am currently using your module and I need to disable the padding, in order to be coherent among other languages.

Sources:

https://godoc.org/encoding/base64#pkg-variables
https://github.com/golang/go/blob/244c98fe01b2af844f6f41b7123a17b7b56f1c2a/src/encoding/base64/base64.go#L105