Comments (4)
How about something like this?
-module.exports = function base32Encode (buffer, variant) {
+module.exports = function base32Encode (buffer, variant, options) {
+ options = options || {}
+
- var alphabet, padding
+ var alphabet, defaultPadding
switch (variant) {
case 'RFC3548':
case 'RFC4648':
alphabet = RFC4648
- padding = true
+ defaultPadding = true
break
case 'RFC4648-HEX':
alphabet = RFC4648_HEX
- padding = true
+ defaultPadding = true
break
case 'Crockford':
alphabet = CROCKFORD
- padding = false
+ defaultPadding = false
break
default:
throw new Error('Unknown base32 variant: ' + variant)
}
+ var padding = (options.padding === undefined ? defaultPadding : options.padding)
var length = buffer.byteLength
var view = new Uint8Array(buffer)
Would love a PR 🙌
from base32-encode.
Sounds reasonable 👍
Any ideas for option name? Maybe { disablePadding: true }
, or just { padding: false }
... or { stripPadding: true }
🤔
from base32-encode.
At first, when I created this PR I was thinking about { padding: false }
, but I prefer padding
to be the variable that you already use. So, I was thinking on something more similar to what is being called in GO, such as { rawEncoding: true }
. What do you think?
I can create the PR later or tomorrow with this 😄
from base32-encode.
SGTM! I will try to do it later
from base32-encode.
Related Issues (7)
- Please add a LICENSE file HOT 1
- ArrayBuffer concerns and feature request HOT 3
- [Install error] The engine "node" is incompatible with this module. HOT 1
- [Runtime error] Cannot use import statement outside a module HOT 3
- Add support for custom alphabet HOT 1
- Missing LICENSE file in the repo of ver 0.1.1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from base32-encode.