Git Product home page Git Product logo

Comments (4)

LinusU avatar LinusU commented on September 25, 2024 1

How about something like this?

-module.exports = function base32Encode (buffer, variant) {
+module.exports = function base32Encode (buffer, variant, options) {
+  options = options || {}
+
-  var alphabet, padding
+  var alphabet, defaultPadding
 
   switch (variant) {
     case 'RFC3548':
     case 'RFC4648':
       alphabet = RFC4648
-      padding = true
+      defaultPadding = true
       break
     case 'RFC4648-HEX':
       alphabet = RFC4648_HEX
-      padding = true
+      defaultPadding = true
       break
     case 'Crockford':
       alphabet = CROCKFORD
-      padding = false
+      defaultPadding = false
       break
     default:
       throw new Error('Unknown base32 variant: ' + variant)
   }

+  var padding = (options.padding === undefined ? defaultPadding : options.padding)
   var length = buffer.byteLength
   var view = new Uint8Array(buffer)

Would love a PR 🙌

from base32-encode.

LinusU avatar LinusU commented on September 25, 2024

Sounds reasonable 👍

Any ideas for option name? Maybe { disablePadding: true }, or just { padding: false }... or { stripPadding: true } 🤔

from base32-encode.

vasco-santos avatar vasco-santos commented on September 25, 2024

At first, when I created this PR I was thinking about { padding: false }, but I prefer padding to be the variable that you already use. So, I was thinking on something more similar to what is being called in GO, such as { rawEncoding: true }. What do you think?

I can create the PR later or tomorrow with this 😄

from base32-encode.

vasco-santos avatar vasco-santos commented on September 25, 2024

SGTM! I will try to do it later

from base32-encode.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.