lilypad / golilypad Goto Github PK

Explanation of Bug:
When my players log into the server it shows the incorrect UUID (Like the server is in offline mode.) If the server is full and players have the permission to bypass the limit it doesn't check their real UUID but an the incorrect one. This happens with anytime I need to check a users UUID on login. This also happens when the server is whit-listed and someone try's to join that is white-listed it will also check the incorrect UUID and tell them they are not white listed.

The Bug: Lily-pad doesnt provide the correct UUID info on login.

Version: Bukkit-Connect V87, Go server Proxy V112, Go server connect V57, Spigot 1.8.8 (latest patch)

Errors or Things in the Console: In console it shows when the user logs in it displays the incorrect UUID it checks for X permission under the incorrect UUID then denies the login. Same with whitelist.

Reproduction of Bug: White-list your server add yourself to the white-list (without op) try to join.

Issue occurred when the UUID update happened. Servers are in online mode. When removing lily-pad to test everything worked as it should and displayed the correct UUID.

Thank you for any help!

wget http://ci.lilypadmc.org/job/Go-Server-Proxy/lastStableBuild/artifact/target/proxy-linux-amd64

resuls in
running in an infinite loop

Adding the file in a docker context also breaks

When joining a network and connecting to the actual MC server, if using the wrong version you get disconnected/timed out which does not explain to players they are using the wrong version to join the server.

In order to counter this, having a configurable set of versions with which the proxy allows to join would be very useful. Just a comma-separated list of Minecraft version IDs/numbers would do I suppose.

Hi there,
I am currently writing a new console client for the versions 1.8.x - 1.12.x.
My 1.8.x version has been encountering issues when connecting to any servers that use LilyPad, in order to debug this further i have installed a copy onto my own machine.
The issue seems to arise when the client is redirected to a new server. After which the client no longer receives any packets. This means that shortly after the redirect the client times out.
Due to the point at which the redirect occurs the client never even receives a Keep Alive packet.
My client can connect to any other 1.8.x server without any issue which leads me to believe this is the fault of the LilyPad server.

If anyone could share any information as to how LilyPad handles the connection process i would greatly appreciate it.
Clearly the way my client behaves may also be partially to blame as i am yet to discover any other client that exhibits the same issues however LilyPad must also have a fault to be the only server to cause the issue with my client. (Bungee works fine.)

Any help would be appreciated..
Thanks.
ItzKmaf

In Spigot, Player Locale can be detected with Player.getLocale(). When connecting to a host Spigot server behind LilyPad, Player.getLocale() ALWAYS returns "en_us" upon player joining. Player.getLocale() still returns "en_us" for players using "es_mx" locale.

To verify that it's a LilyPad issue, I used ProtocolLib.

1. Launch spigot server (1.12.2) (accept eula and let it generate a world)
2. Copy ProtocolLib.jar to /plugins directory and restart server.
3. In console type: packet add client 21 true (this listens for packet PacketPlayInSettings This packet is sent by the Minecraft client and has updated locale settings for the player)
4. Connect to running server with a Minecraft client
5. Look at log you will see something similar to this:

[ProtocolLib] Received SETTINGS[class=PacketPlayInSettings, id=5] from BigMacMC: { a = "es_mx", b = 32, c =Unknown macro: { e = 0, f = "options.chat.visibility.full", name = "FULL", ordinal = 0 } , d = true, e = 127, f = { c = ("TextComponent{text='Right', siblings=[], style=Style{hasParent=false, color=null, bold=false, italic=false, underlined=false, obfuscated=false, clickEvent=null, hoverEvent=null, insertion=null}}"), name = "RIGHT", ordinal = 1 } }

The host was able to detect my locale as "es_mx" (look at a = "es_mx").

I setup LilyPad so that it points to same Server. I then repeated the above steps. When connecting to the LilyPad ip, I successfully joined the server but DID NOT SEE packet PacketPlayInSettings being captured. When executing Player.getLocale(), the result returned was "en_us" even though I was using locale "es_mx".

If as a player I changed my locale while playing (hitting Escape to go to menu, Options->Language->Espanol(Mexico)), the server would successfully detect the new locale change of "es_mx" and the console would display multiple packets of PacketPlayInSettings with the correct locale information being captured.

However, if I disconnected and reconnected, I would never see packet PacketPlayInSettings being captured. When calling Player.getLocale() I would get "en_us".

it seems packet PacketPlayInSettings is being blocked by LilyPad for new players joining, but not blocked for any other events where the client transmits the packet.

Behaviour happens on a docker image using Alpine 12.
The following is output whenever a user attempts to join:
Proxy server, name: TerminalSin ip: [ip redacted] disconnected, err: read tcp 172.18.0.3:25567->[ip redacted]:16824: use of closed network connection

Pretty straight forward. Everything is properly configured.

A server I am managing is currently having issues with players disconnecting after approximately 60 seconds on some servers behind the proxy. Here is an example timeline:

Success

• Player join to lobby
• Player is able to idle for hours

Failed

• Player joins to lobby
• Player connects to some other server
• Player gets disconnected after about 60 seconds

The player sees the message "The connection was forcibly closed", but on the server in which they were joined to shows "Timed out" due to not receiving a keepalive packet. Players will also sometimes notice that upon teleporting, the world doesn't load, but they are still able to chat.

This behavior started upon upgrade to 1.13 from 1.12, and still remains present through 1.15.

It would be nice to have this URL format come from a sys environment variable defaulting to the constant rather than having it static.

This could probably be done by querying the environment here:
response, err := http.Get(fmt.Sprintf(URL, name, MojangSha1Hex([]byte(serverId), sharedSecret, publicKey)))

GoLilyPad seems to be a resource efficient bungeecord replacement. Cuberite is a resource efficient minecraft server replacement. I wonder if we could marry these two together?

GoLilyPad Should support Native IPv6 networking on IPv6 enabled networks.

err: dial tcp: too many colons in address 2607:5300:60:2307:::32532

When spectating an entity first person (left clicking it while in gamemode 3)
you can't leave it using "shift" key.

This only happens when you have hopped servers (for example using portalcommand)
this does not happen on the server you initially join.
So when testing this, make sure you hopped.

Are there any outstanding differences between GoLilyPad and JLilyPad? Is there any reason to prefer JLilyPad over GoLilyPad other than wanting to stick with Java?

Hey.

So, I recently switched to GoLilyPad from BungeeCord and after I made the switch I realised that firework rockets were no longer making elytra flight faster.

I didn't assume this was an issue with GoLilyPad until I searched google to find this used to be an issue in BungeeCord before it was patched. Here is the commit in BungeeCord where they fixed the issue: SpigotMC/BungeeCord@6104354

Here is the thread where I found out it used to be an issue in BungeeCord: https://www.spigotmc.org/threads/fireworks-not-boosting-elytra.206316/

I'm assuming using a proxy stops them from working, but BungeeCord was able to patch it, so could a similar patch be added to GoLilyPad to resolve the issue?

If this can be fixed that would be great as a lot of players on my server want this back and if it's an issue with the proxy there isn't much I can do about it.

Thanks!

Can climb into a boat just fine on login in the hub server but the minute that you connect to a server on the network and attempt to use a boat, it doesn't interact correctly. It acts like you aren't in the boat but can still click shift and have it give the animation of jumping out of the boat but you are never in the boat.

Ok, turns out it's impossible to mount any type of entity. Horse, pig, boat, minecart, etc.

Hello!

Since commit 9728604 there is a bug in lilypad which makes it so that the kick message which is being sent by the server is not actually showing up in the kick screen. This only occurs if you run 1.9.2 and not 1.9.

Hello,
I am currently using the newest versions of the Connect and Proxy. Skins are not showing on any of my servers.

Using a fork, with network leave/join events, merged all latest commits into fork, when following build instructions the proxy still comes up as 1.11.2 in Minecraft game

As of 47916f2 we are no longer able to compile GoLilyPad for Mac OSX Yosemite.

Title. My environment is a 1.12 Spigot server running ViaVersion.

When managing a server network, it would be nice if there was a way to see which servers are online at the moment (possibly with playercount?).

Not seen skins and heads. Only steve.

astei/krypton#22 (comment)

When I brought this project down into my workspace, I noticed that almost every function does not have any comments for them, leading to the linter showing a bunch of issues. Would you mind if I went about cleaning up and documenting things for you?

I've updated to Minecraft 1.9.4 and it seems that everytime a player goes to Hub or disconnects, the players inventory resets, removing everything they had and treating the player like a new player by not saving the players data file. Been using proxy version #148 and bukkit-connect #98.

Nice to have. Not immediately required for an authenticated connection.

While building a project, I get a Maven error for lilypad.client.connect:

[ERROR] Failed to execute goal on project DiscordConnect: Could not resolve dependencies for project <>: The following artifacts could not be resolved: lilypad.client.connect:lib:jar:0.0.1-SNAPSHOT, lilypad.packet:connect:jar:0.0.1-SNAPSHOT, lilypad.packet:common:jar:0.0.1-SNAPSHOT: Could not transfer artifact lilypad.client.connect:lib:jar:0.0.1-20171001.001814-50 from/to lilypad (http://ci.lilypadmc.org/plugin/repository/everything): GET request of: lilypad/client/connect/lib/0.0.1-SNAPSHOT/lib-0.0.1-20171001.001814-50.jar from lilypad failed: Premature end of Content-Length delimited message body (expected: 4324897; received: 15679 -> [Help 1]

I tried a second time thinking the connection might've gotten interrupted, got the same error except expected: 4324897; received: 15439

Is this on my side or yours?

Hey.

So, I recently switched to GoLilyPad from BungeeCord and after I made the switch I realised that firework rockets were no longer making elytra flight faster.

I didn't assume this was an issue with GoLilyPad until I searched google to find this used to be an issue in BungeeCord before it was patched. Here is the commit in BungeeCord where they fixed the issue: SpigotMC/BungeeCord@6104354

Here is the thread where I found out it used to be an issue in BungeeCord: https://www.spigotmc.org/threads/fireworks-not-boosting-elytra.206316/

I'm assuming using a proxy stops them from working, but BungeeCord was able to patch it, so could a similar patch be added to GoLilyPad to resolve the issue?

If this can be fixed that would be great as a lot of players on my server want this back and if it's an issue with the proxy there isn't much I can do about it.

Thanks!

Looks like this is dead.. O Well.

Recently we switched from 1.13.2 to 1.16.4, and after about two weeks, servers started to be completely unjoinable and left players hanging on the "Loading terrain..." screen. After many hours of debugging, we have found that if the scoreboard.dat world data file is >1mb in size on 1.16.4 the issue occurs. When testing without running behind the proxy, the client can connect fine.

We know that this issue must have some relation to 1.16 of the sort, as we have found hubs with 5mb scoreboard.dat files that are running on 1.12 without issue in the past. Even if the issue is just some sort of limitation, it'd be best to at least disconnect the player with an error, as this caused many hours of headaches.

Alot of my players are having problems connecting to my other servers? They enter the hub and try to connect to a server and just get kicked.

"Update: My game no longer loads the main server. It goes straight to "Loading terrain..." and then crashes after a minute of not being able to connect."