Git Product home page Git Product logo

curriculum-app's People

Contributors

aaronev avatar bairbanu avatar brac avatar bundacia avatar danisyellis avatar daschi avatar deadlyicon avatar dianavashti avatar ethanjstark avatar hjbowers avatar jaredatron avatar jason00111 avatar je-lopez avatar jlopker avatar jrob8577 avatar jrpool avatar justinhaaheim avatar leikkisa avatar maighdlyn avatar msmishi avatar needdra avatar optomal7 avatar pporche87 avatar punitrathore avatar rae-ralston avatar salsoloman avatar spencerdezartsmith avatar tannerwelsh avatar trevorjamesh avatar yaseenagag avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

curriculum-app's Issues

Typo in Serialization module

This sentence in the description has typos and seems incomplete:

In other words anytime you convert data (like objects, arrays, strings, numbers, etc.) into a string that can be converted back into those same data strictures, then you're serializing that data it.

Checkbox states not persistent

The checkboxes under “You've completed this exercise when” can be checked, but when the page is reloaded the checkmarks have disappeared. This conflicts with the behavior of other checkboxes on the site, but without any indication as to which checkboxes’ states persist and which do not. It would be most productive if all checkboxes on the site were to preserve their states across sessions, but, if not, then for checkboxes to be labeled so users know whether they do.

users can see which learners have completed a challenge

User Stories

  • As a learner, I can see which active members of the guild have completed what challenge.
    • /challenges/:challengeSlug/learners
  • As a learner, I can submit an artifact url when I report that I've completed a challenge
    • when you click on the checkbox next to the challenge, popup a modal asking for the artifact url.

Technical Notes

  • remove list of modules from phase READMEs
  • convert benchmark modules to challenges (in /challenges instead of /modules)

Upgrade Node.js version

---------- Forwarded message ---------
From: Heroku <[email protected] <mailto:[email protected]>>
Date: Wed, Jul 12, 2017 at 9:10 PM
Subject: [software] [ACTION REQUIRED] Follow-up: Node.js security update on Heroku

Hello,

Earlier today, we notified you that you had one or more Node.js applications affected by a recent vulnerability <http://hello.heroku.com/e/36622/y-july-2017-security-releases-/cqwlkl/643538443>. We sincerely apologize if the email you received did not include the list of affected applications.

Note: Apps that have already been upgraded will appear in this list.

Upgrading

1. Review your package.json file. You need to assure your engines section specifies a version that is not vulnerable: 4.8.4, 6.11.1, 7.10.1, or 8.1.4. If you do not specify a version, 6.11.1 will be used automatically. Please see Specifying a Node.js version <http://hello.heroku.com/e/36622/t-specifying-a-node-js-version/cqwlkn/643538443> for details.

2. Push a new commit to your app, which will cause a deploy. For example:

$ heroku git:clone -a APPNAME

# review your package.json and edit if necessary (see above)

$ git add package.json

$ git commit --allow-empty -m "Upgrade Node.js version"

$ git push heroku master

If you have any additional questions, please view our detailed FAQ <http://hello.heroku.com/e/36622/htable-seeds-vulnerability-faq/cqwlkq/643538443>.

Heroku, 650 7th Street

San Francisco, CA 94103

Bug: Lose filter on redirect

Summary

I partially lose my filter when navigating back to the curriculum page

Steps to reproduce:

Go to https://curriculum.learnersguild.org/phases/3/skills
Click Filters and select SQL
Click on Can build a SQL schema for a given problem definition to navigate to a different page
Click the BACK button in your browser.
Notice that SQL is still typed in the filter, yet the list shows all articles.
Focus on the text input and press enter key to reactivate filter

What I expected to happen instead:

Navigating to another page and then clicking back button should load the page with my filter still applied, OR: with my filter not applied but text input is empty.

Changes to install instructions (new node consideration)

Just a quick note that with the new version of node what was once:

npm install --save express cookie-parser body-parser

can now be this:
npm install express cookie-parser body-parser

and npm install --save-dev nodemon

can now be:
npm install -D nodemon

I know that many people may be operating off of older node versions, or using nvm in certain scenarios to use an older node, but, as more go to node 8 and npm 5, these instructions will be more commonplace. Please correct any misunderstanding I may have, and since this is not remotely a high-priority item, no worries if this isn't implemented.

"Report a Bug" link misleading

The "Improve This Page" and "Report a Bug" links on curriculum pages are VASTLY different, the former being for the curriculum and the latter being for a private repository aimed at supporting all of Github! The "Report a Bug" link should be removed, or, if it is retained, both relocated and reworded so learners will know what it's about. Otherwise, bug reports from some learners about the curriculum application will continue to get lost.

Checking or clearing checkboxes disables them until refresh

I found a problem on http://curriculum.learnersguild.org/modules/HTTP-Node/

Checking or clearing checkboxes disables them until the page is refreshed. At the moment when the box is checked or cleared, a TypeError appears in the JavaScript console:

Uncaught TypeError: Cannot read property 'value' of undefined
at Object.postJSON.then._ (behaviors.js:37)
at Object. (jquery-1.10.1.min.js:4)
at c (jquery-1.10.1.min.js:4)
at Object.fireWith [as resolveWith] (jquery-1.10.1.min.js:4)
at k (jquery-1.10.1.min.js:6)
at XMLHttpRequest.r (jquery-1.10.1.min.js:6)

Dot Files Exercise Terminal Error

Bug Report

There seem's to be an issue with Line 59 of the .bash_profile file included as part of the Dot Files exercise error. After moving and renaming files to the home directory and starting a new terminal process the following error pops up:
-bash: unalias: git: not found

Line 59 reads:
export PS1=' \[\033[4;1;${PROMPT_COLOR}m\]\w\[\033[0m\]$(unalias git; __git_ps1 " $(git config --get user.email) (%s)") \n$ '

Removing the unalias git portion of the line seems to correct the error.
export PS1=' \[\033[4;1;${PROMPT_COLOR}m\]\w\[\033[0m\]$( __git_ps1 " $(git config --get user.email) (%s)") \n$ '

curriculum app branding is off

From ch3403

Description

colors

We need to ensure that the branding (colors, mostly) align with the Guild branding guide.

favicon

We should always use the Learners Guild icon for favicons for all services. This was a Q1 goal of "internal brand matching external brand".

Side-note: Please don't create new iconography in any of our services!

Details

The "right" way to do it (that works on all devices in a seamless way) is to do something like IDM does by downloading the <head> metadata as necessary from brand.learnersguild.org.

Check out npm run icons:fetch on IDM.

Tasks

  • use standard favicon
  • ensure colors match style guide

create instructor dashboard

  • instructor can see who is in which phase
  • instructor can see what kills an individual has checked off
  • anyone can see which users can checked off a particular skill

broken link

When you are on one of the phase pages -->
https://curriculum.learnersguild.org/phases/[phase number]/

The link "phases" at the top of the page is broken...this url is returning a 404:
https://curriculum.learnersguild.org/phases/

Missing skills

Express skills in phase 1
Duplicate array sort skills
More http skills

Add flag and link to resources with LG recorded media

LG has a YouTube channel with all recorded lectures. It would be awesome to make sure each skill or module that has some LG media (most likely recorded lectures), has a link to it on its page, and that the skill or module has a flag of some sort to show which skills and modules have LG media already.

See screen shots for dropdown menu and phase specific list of module links, each with media could have a ⏯ type flag.

screen shot 2017-08-17 at 2 25 26 pm

screen shot 2017-08-17 at 2 26 59 pm

Party List Its ES2017

just a heads up.
in the Party List Its ES2017 module there is a "watch" section at the bottom with a video link. this is the exact same video as the "exercises" ES2017 with Babel + Node.js Tutorial

Project team size (phase 3)

Bug Report

Is it possible to see on the phase 3 page which projects are solo goals and which ones are not? It would be super helpful at times if there was a way to see at a glance.

Feature Request: Tracking phase progress tools

  • breaking up the subtasks of the modules into time/completion contexts. I.e To-Do, In-Progress, Finished.
  • Set personal due dates on a project and per module basis
  • Gantt Chart based off project and module due dates set by user.
  • Module view shows at a glance: Module completion status, number of tasks left, personal due date.

Context of $PS1

Since $PS1 pertains to bash and not to csh or tcsh (which use “prompt”, “prompt2”, etc.), it might be clearer to preface it, where it occurs, with “bash shell” rather than only “shell”.

Clarify Specs for App 3-4 of Phase 2 Secure Session Cookie Exercise

Quoted feedback from a learner after completing this exercise:

Pertaining to this exercise: https://curriculum.learnersguild.org/modules/Adding-State-to-HTTP/exercises/Secure-Session-Cookie/: the part of the module that was unclear and frustrating was this: 
"Build a middleware that serializes a session object into a session cookie using JSON. Look at cookie-session as a guide. Each route should have access to the deserialized session cookie object at req.session. The cookie needs to be updated on each form submission. When the user's first name, last name, and color are submitted, store them in the session cookie object under the keys first_name, last_name, and color."

Later on in the specs, there was a line that said: 
"The homepage and form post routes should only read and write data to and from request.session and not to the cookies header directly."

The language in this module is very unclear, especially when it says that the cookie needs to be updated on each form submission, but that you cannot write to the cookies header directly; it took me a while and a lot of help to figure out that I needed to create a middleware function to create the cookie and another middleware function to store that cookie information in the current page's session as well. It'd be great if it could be made more clear that you can write to the cookies header as middleware. As it stands, I read the specs as not being able to create a cookie at all.

open source all LOS repos

From ch3008

  • echo
  • idm
  • curriculum
  • jsdev (subsumed by echo or curriculum?)
  • matrix (subsumed by curriculum?)

Tasks

  • ensure LICENSE file exists (ISC or MIT)
  • echo
  • idm
  • curriculum
  • jsdev

Spruce up UI for curriculum app

(merged two stories to create this one)


From ch3847

Some simple design tweaks we could do:

  • Use Material UI
  • Convert to Guild colors, typefaces
  • Use style idioms for buttons, layout, etc.

From ch3403

Description

colors

We need to ensure that the branding (colors, mostly) align with the Guild branding guide.

favicon

We should always use the Learners Guild icon for favicons for all services. This was a Q1 goal of "internal brand matching external brand".

Side-note: Please don't create new iconography in any of our services!

Details

The "right" way to do it (that works on all devices in a seamless way) is to do something like IDM does by downloading the <head> metadata as necessary from brand.learnersguild.org.

Check out npm run icons:fetch on IDM.

Tasks

  • use standard favicon
  • ensure colors match style guide

Move jsdev content into curriculum

From ch3834

Let's move all the goal data from jsdev into curriculum so that we can decommission jsdev.

Tasks

  • Make relevant goals visible in curriculum UI
  • Re-create goal API from curriculum service for consumption by Echo

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.