Spruce up UI for curriculum app about curriculum-app HOT 13 CLOSED

[Comment from Clubhouse user @Tanner:] @jaredatron: mind if I take a crack at this?

from curriculum-app.

[Comment from Clubhouse user @jaredatron:] not at all. @jeffreywescott and I talked about picking a CSS framework that works with both react and non-react (bootstrap, material-ui, ?) and then building a shared LG theme. That way we can all use the same assets across all of our apps. Maybe in a shared npm repo or something.

So maybe we should start there?

from curriculum-app.

[Comment from Clubhouse user @prattsj:] +1 to using an existing material design react ui library (and really a ui library rather than just a css framework) and creating a custom css theme for it. would make a request that we not use material-ui, though. i've used it extensively in the past (back when it was the only decent one out there). its performance is terrible and it's difficult to do theming.

https://www.reddit.com/r/reactjs/comments/4fd4ro/materialui_vs_reacttoolbox_and_why/

we're using react-toolbox for echo and, while it has some shortcomings, its performance is good and it's much easier to work with and customize. i like jared's idea of having a module on npm - we can basically just have a wrapper around whatever ui library we choose.

from curriculum-app.

[Comment from Clubhouse user @Tanner:] @prattsj: won't react-toolbox only work with react apps though? Could we start with just some shared CSS/SCSS?

from curriculum-app.

[Comment from Clubhouse user @prattsj:] sure. i mean...react-toolbox uses css modules, so i see an opportunity for us to actually have 2 separate repos: one for the s/css, then another that depends on that and wraps react-toolbox (plus other custom) react components in it.

from curriculum-app.

[Comment from Clubhouse user @prattsj:] another option is materialize: http://materializecss.com

from curriculum-app.

@tannerwelsh

from curriculum-app.

is this a duplicate of issue #74 ?

from curriculum-app.

Yup. I just merged #74 into this one and will close #74.

from curriculum-app.

Ok so a first pass is ready for review here: #91.

It's not perfect, but I didn't want to spend too much time customizing the bootflat styles if we will be merging curriculum soon anyway.

from curriculum-app.

@jeffreywescott why do we have to use the standard favicon. That seems like form over function. I want to be able to distinguish between tabs more easily.

from curriculum-app.

Iif we had an "on brand" favicon that clearly communicated Learners Guild while also communicating the specific app, we would consider it. But brand trumps ugly icons in this case.

from curriculum-app.

from curriculum-app.