Comments (13)
[Comment from Clubhouse user @Tanner:] @jaredatron: mind if I take a crack at this?
from curriculum-app.
[Comment from Clubhouse user @jaredatron:] not at all. @jeffreywescott and I talked about picking a CSS framework that works with both react and non-react (bootstrap, material-ui, ?) and then building a shared LG theme. That way we can all use the same assets across all of our apps. Maybe in a shared npm repo or something.
So maybe we should start there?
from curriculum-app.
[Comment from Clubhouse user @prattsj:] +1 to using an existing material design react ui library (and really a ui library rather than just a css framework) and creating a custom css theme for it. would make a request that we not use material-ui, though. i've used it extensively in the past (back when it was the only decent one out there). its performance is terrible and it's difficult to do theming.
https://www.reddit.com/r/reactjs/comments/4fd4ro/materialui_vs_reacttoolbox_and_why/
we're using react-toolbox for echo and, while it has some shortcomings, its performance is good and it's much easier to work with and customize. i like jared's idea of having a module on npm - we can basically just have a wrapper around whatever ui library we choose.
from curriculum-app.
[Comment from Clubhouse user @Tanner:] @prattsj: won't react-toolbox only work with react apps though? Could we start with just some shared CSS/SCSS?
from curriculum-app.
[Comment from Clubhouse user @prattsj:] sure. i mean...react-toolbox uses css modules, so i see an opportunity for us to actually have 2 separate repos: one for the s/css, then another that depends on that and wraps react-toolbox (plus other custom) react components in it.
from curriculum-app.
[Comment from Clubhouse user @prattsj:] another option is materialize: http://materializecss.com
from curriculum-app.
from curriculum-app.
is this a duplicate of issue #74 ?
from curriculum-app.
Yup. I just merged #74 into this one and will close #74.
from curriculum-app.
Ok so a first pass is ready for review here: #91.
It's not perfect, but I didn't want to spend too much time customizing the bootflat styles if we will be merging curriculum soon anyway.
from curriculum-app.
@jeffreywescott why do we have to use the standard favicon. That seems like form over function. I want to be able to distinguish between tabs more easily.
from curriculum-app.
Iif we had an "on brand" favicon that clearly communicated Learners Guild while also communicating the specific app, we would consider it. But brand trumps ugly icons in this case.
from curriculum-app.
from curriculum-app.
Related Issues (20)
- Coach status page
- COS workshop passport
- phase 4 status report HOT 2
- Add tracking of personal days taken by a learner to the phase 4 status page. HOT 2
- Write tests for routes: calendar, guide HOT 4
- Write tests for routes: api, assets
- Write tests for routes: profile, users HOT 1
- Write tests for routes: digest, phases, modules, skills, cos HOT 2
- redirected to login when already logged in HOT 1
- add 404 page HOT 3
- skills filter dropdown should not contain filters for-which there are zero skills
- Modules pages broken HOT 2
- Resource is no longer available
- modules dropdown filter
- write tests for `/database/queries.js` and `/database/commands.js` HOT 5
- Skills checkboxes are not saving HOT 2
- tests ensuring learners can save their progress as they check off skills HOT 2
- create a npm script to reset the db
- Unable to see modules HOT 1
- Can affectively manipulate the DOM in a Browser
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from curriculum-app.