laino / final-pm Goto Github PK

Hello @laino! It looks like there's an issue when trying to log -f all of the available apps. I assume all should be supported here as well. If not, please consider this a feature request :).

final-pm log -f all
[ERROR] [CLI] Arguments mismatch for follow: "value" with value "all" matches the inverted is not "all" pattern

Update and publish to npm

You already compare LOC, however that's only part of the truth... The actual LOC that will be (potentially) running on one's system are not just the lines from the projects but also from all of those dependencies.

The node "community" has a tendency to add a metric (or maybe even imperial) shitton of dependencies to everything they code... libraries of quite varying[0] quality which in turn pull in even more libraries of varying quality.

Furthermore, there were finally some blogs pointing out how many of the node community will often blinding import third party code, commonly the minified and transpiled "release" versions that even cannot be audited, without anybody ever considering the possibility of an evil actor[1].

As such, it is preferable that:

• Any and all dependencies have merit and purpose being there. [2]
• Authors, such as yourself, are aware of the pros and cons of dependencies and vet any new (and occasionally re-vet old) dependencies
• Authors make it known that they are.

In the end, I[4] gotta trust you as an author[5].

[0] "varying" in this context obviously means inefficient, insecure and generally crappy.
[1] Putin himself hacking your node app to change the outcome of the election in your country.
[2] aka. you're not too lazy or unskilled to google String.prototype.padEnd on MDN[3]
[3] the npm leftpad/padleft/padgenericfromtheleftexceptwhenpassingaconfigurationobjecttopadrightinstead packages are serious quality softwares that should be included in every node project
[4] properly tinfoiled at almost all times
[5] I kinda trust you so far, even tho you're from Bavaria.

Helllo @laino! I use systemd to launch final-pm on system boot and while it's working fine (systemd is able to "guess" the just launched daemon's PID), it would be great if final-pm wrote the daemon's PID into a file (~/.final-pm/daemon.pid maybe?) once it's up. It would make the setup more robust. What do you think?

I installed final-pm on Windows. I met some errors.

The first error

The examples is not published with npm package (which is good), so I have to comment out export.examples in cli-args.js.

The second error is not able to start daemon

node_modules\.bin\final-pm start app -v
[DEBUG] [Connection] Connecting to ws+unix://C:\Users\me\.final-pm\daemon.sock
[INFO ] [Daemon] Starting Daemon
[ERROR] [CLI] spawn D:\proj1\node_modules\final-pm\bin\daemon ENOENT

Hello @laino! It looks like there's an issue when downscaling an app:

// conf.js
module.exports = {
  applications: [
    {
      "name": "foo",
      "run": "foo.js",
      "instances": 2,
      "ready-on": "message"
    },
  ]
};

// foo.js
process.send('ready');
setTimeout(() => {}, 999999999);

final-pm -c conf.js start foo
[INFO ] [Daemon] Starting Daemon
[INFO ] [Config] foo added
[INFO ] [Action] Start 2 processes...
[INFO ] [Action] Success

Now change the number of instances in the config file to just 1 and run scale.

final-pm -c conf.js scale foo
[INFO ] [Config] foo{instances} updated
[INFO ] [Action] Stop 1 process...
[ERROR] [CLI] Arguments mismatch for all: Arguments mismatch for stop: "value" must be a number

final-pm -c conf.js show

Any ideas?

It's not 1999, pls