Git Product home page Git Product logo

Comments (2)

laino avatar laino commented on May 28, 2024

tl;dr: This is implemented in 2.24.0.

Long Explanation:

In the daemon follow/unfollow "all" is implemented via a virtual application (really just an event) that receives all logging output. The call just wasn't whitelisted.

This was because it isn't as transparent as I would like: for instance you can't follow "all", then unfollow some applications separately to get "all except X, Y and Z". Also following "all" would different to other commands in that it doesn't really operate on some pre-defined set of applications/processes, since obviously you'd also get log output of applications that are added later.

There may also be some counter-intuitive behavior if you follow "all", but follow more applications separately (duplicate log lines instead of NOOP), but the CLI already detects and prevents this.

Plus (!) "all" is generally resolved to a list of known applications on the client side (to prevent ugly surprises
where something your client didn't see earlier gets caught in it) and I had originally planned to keep the concept of "all" out of the daemon entirely, where I had to relent when it came to logging. At least here it's safe to allow it

I did not really consider how counter-intuitive this decision would make the CLI client, where unfollow doesn't matter anyways and following everything, even if it is added later, is probably precisely what you meant to do. Also the CLI documentation nowhere states that "all" is unsupported for -f, so that would still need changing.

I'm now convinced it is better to just allow "all" in follow/unfollow, which is implemented in version 2.24.0 by whitelisting the argument.

from final-pm.

jiripospisil avatar jiripospisil commented on May 28, 2024

Thank you! Works great.

from final-pm.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.