kubernetes / component-base Goto Github PK

Support for endpoints and configmaps is removed in K8s 1.24 with kubernetes/kubernetes#106852.
More details about the motivation to switch to leases - ref kubernetes/kubernetes#80289.

To preserve the backwards-compatibility, resource lock for migration purposes (endpointsleases, configmapsleases) should be used when switching from the legacy resource locks (endpoints, configmaps)

component-base is currently using endpoints . We want to migrate this to endpointsleases and finally to leases.

Upgrade github.com/moby/term to a tagged release: v0.5.0.

$ go get github.com/moby/[email protected] && go mod tidy

The go.opentelemetry.io dependencies are still on some older versions.

The sig-storage upgraded these libs in our csi-lib-utils(kubernetes-csi/csi-lib-utils#140) but the versions are not compatible with what is in the component-base under certain dependency chain.

This causes upgrading dependencies in the csi sidecars failed. For example, the external-provisioner is depending on both csi-lib-utils and component base, in this scenario there is conflict in upgrading.

Similar issue in other repos: open-telemetry/opentelemetry-go#2938
Can component-base update the libs to newer versions?

There's breaking changes in opentelemetry new version, see https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md

That is to say a project does not work if it depend on this repo and there's also direct/indirect dependencies on the new version of opentelemetry

when I use this module in my project, go build give me this error:
go version: go 1.17

pkg/mod/k8s.io/[email protected]/logs/config.go:41:22: cannot use nil as type logr.Logger
 in argument to LogRegistry.Register
pkg/mod/k8s.io/[email protected]/logs/registry.go:56:3: cannot use nil as type logr.Logger
 in return argument

From @stealthybox
component-base is an automated staging repository from k/k, so most of the issues end up on kubernetes/kubernetes or their associated component's repo's.
See:

• Project Board
• k/k Issues/PR's needing Review
  The wg label has also been used in other orgs and repos such as kubernetes-sigs/kubebuilder.
  For repos outside of the kubernetes org, I've just been adding links to the respective issues on the Project Board.

traces utils.go

The most fundamental is that TracingConfiguration does not yet provide a complete configuration

func NewProvider(ctx context.Context, baseSampler sdktrace.Sampler, resourceOpts []resource.Option, opts ...otlpgrpc.Option) trace.TracerProvider {
 opts = append(opts, otlpgrpc.WithInsecure())

 driver := otlpgrpc.NewDriver(opts...)
 exporter, err := otlp.NewExporter(ctx, driver)
 if err != nil {
  klog.Fatalf("Failed to create OTLP exporter: %v", err)
 }

 res, err := resource.New(ctx, resourceOpts...)
 if err != nil {
  klog.Fatalf("Failed to create resource: %v", err)
 }

 // TODO Missing customization
 bsp := sdktrace.NewBatchSpanProcessor(exporter)

 return sdktrace.NewTracerProvider(
  // TODO Missing customization
  sdktrace.WithSampler(sdktrace.ParentBased(baseSampler)),
  sdktrace.WithSpanProcessor(bsp),
  sdktrace.WithResource(res),
 )
}