kristjank / ark-net Goto Github PK

The dead link leads to nowhere, and the reference thus is a dead link.
Could you either update the link or add the file?

When building from VS on both win10 and macOS platform I receive build error related to the main ark-net solution. Here is the console output:

Target PostBuildEvent:
    REM Create a NuGet package for this project and place the .nupkg file in the project's output directory.
    REM If you see this in Visual Studio's Error List window, check the Output window's Build tab for the actual error.
    ECHO Creating NuGet package in Post-Build event...
    PowerShell -NoProfile -ExecutionPolicy Bypass -Command "& '/Users/doob/Desktop/UnityBlock/ark-net/ark-net/_CreateNewNuGetPackage/DoNotModify/CreateNuGetPackage.ps1' -ProjectFilePath '/Users/doob/Desktop/UnityBlock/ark-net/ark-net/ark-net.csproj' -OutputDirectory '/Users/doob/Desktop/UnityBlock/ark-net/ark-net/bin/Debug/' -BuildConfiguration 'Debug' -BuildPlatform 'AnyCPU'"
    /var/folders/6r/wkww53sj6gbf1cpmj2lq7ygr0000gn/T/tmp69086b90510749819e89e1ac125a4306.exec.cmd: line 5: unexpected EOF while looking for matching `''
    /var/folders/6r/wkww53sj6gbf1cpmj2lq7ygr0000gn/T/tmp69086b90510749819e89e1ac125a4306.exec.cmd: line 6: syntax error: unexpected end of file
    /Library/Frameworks/Mono.framework/Versions/5.2.0/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(5036,5): error MSB3073: The command "REM Create a NuGet package for this project and place the .nupkg file in the project's output directory.
    /Library/Frameworks/Mono.framework/Versions/5.2.0/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(5036,5): error MSB3073: REM If you see this in Visual Studio's Error List window, check the Output window's Build tab for the actual error.
    /Library/Frameworks/Mono.framework/Versions/5.2.0/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(5036,5): error MSB3073: ECHO Creating NuGet package in Post-Build event...
    /Library/Frameworks/Mono.framework/Versions/5.2.0/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(5036,5): error MSB3073: PowerShell -NoProfile -ExecutionPolicy Bypass -Command "& '/Users/doob/Desktop/UnityBlock/ark-net/ark-net/_CreateNewNuGetPackage/DoNotModify/CreateNuGetPackage.ps1' -ProjectFilePath '/Users/doob/Desktop/UnityBlock/ark-net/ark-net/ark-net.csproj' -OutputDirectory '/Users/doob/Desktop/UnityBlock/ark-net/ark-net/bin/Debug/' -BuildConfiguration 'Debug' -BuildPlatform 'AnyCPU'"" exited with code 1.
Done building target "PostBuildEvent" in project "ark-net.csproj" -- FAILED.

Done building project "ark-net.csproj" -- FAILED.

Build FAILED.

Core/PeerApi.cs(101,21,101,26): warning CS0162: Unreachable code detected
/Library/Frameworks/Mono.framework/Versions/5.2.0/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(5036,5): error MSB3073: The command "REM Create a NuGet package for this project and place the .nupkg file in the project's output directory.
/Library/Frameworks/Mono.framework/Versions/5.2.0/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(5036,5): error MSB3073: REM If you see this in Visual Studio's Error List window, check the Output window's Build tab for the actual error.
/Library/Frameworks/Mono.framework/Versions/5.2.0/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(5036,5): error MSB3073: ECHO Creating NuGet package in Post-Build event...
/Library/Frameworks/Mono.framework/Versions/5.2.0/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(5036,5): error MSB3073: PowerShell -NoProfile -ExecutionPolicy Bypass -Command "& '/Users/doob/Desktop/UnityBlock/ark-net/ark-net/_CreateNewNuGetPackage/DoNotModify/CreateNuGetPackage.ps1' -ProjectFilePath '/Users/doob/Desktop/UnityBlock/ark-net/ark-net/ark-net.csproj' -OutputDirectory '/Users/doob/Desktop/UnityBlock/ark-net/ark-net/bin/Debug/' -BuildConfiguration 'Debug' -BuildPlatform 'AnyCPU'"" exited with code 1.
    1 Warning(s)
    1 Error(s)

get network seettings (hash, byte prefix, version) from peer and set them

the call is to a seed peer (either devnet or mainnet) -
http://5.39.9.240:4001/api/loader/autoconfigure

1. you select a seed peer - based on settings (devnet or mainnet)
2. you call peer:port/api/loader/autoconfigure
3. you set the params

This will ensure developers using this library are able to override the default config settings with a settings.conf file in the root dir.

Hi @sharkdev-j @sharkdev-a ,

only one seed peer is usually not a good idea. I know there has been lately an issue with a lot of them. Please take a look at the clean healthy SEED peer list - and include them from here:
https://github.com/kristjank/ark-go/blob/master/core/arkenv.go#L206

After you randomly select one SEED peer... you must build up the ACTIVE healthy peer list to work with, meaning:

connect to randomly selected SEED peer from the SEED list
call peer/list from that peer
clean the received peer/list by (version= 1.0.1 - mainnet, status=OK, and find the max height peer, and then select just the ones (let's say 10 blocks smaller than max height peer)
save filtered the peer list globaly so it can be used on the API for later on (multi broadcasts and switch peer, etc)...
--I use this in arkgo now - and I usually clean the list from 150 to 70/60 healthy peers to work with...

Comment the code, give more information about the different functions.
I am already on that.

ArkModel

1. Change UnconfirmedBalance & Balance to BigInteger instead of string in ArkAccount

ArkBlock

1. Change PreviousBlock to int instead of string
2. Add reward as BigInteger
3. Add Confirmations as int
4. Add TotalForged as BigInteger

ArkPeer

1. Add Errors as int

DelegateVoters

1. Change Balance to BigInteger instead of string

PeerHeader

1. Change PreviousBlock to int instead of string

Add the following methods...

1. GetEpoch
2. GetHeight
3. GetNetHash
4. GetFees
5. GetMilestone
6. GetReward
7. GetSupply
8. GetStatus

Add the following methods...

1. GetFee
2. GetForgedByAccount (amount of ark forged by account). Need to supply generatorPublicKey as param
3. GetNextForgers
4. GetTotalVoteArk

When connection to seed peer and receiving a list of peers, filter them according to:

-status OK
-version 1.1.0
-find the max height peer (and remove peers more than 10 blocks behind)

Store this filtered list and use it as clean peer list.

Make a class called ArkTransactionReponse with properties returned from /peer/transactions

Class name is misleading and also the ones that inherit it... it' looks...

Maybe a rename from ArkError - ArkResponseStatus? or something... as you also have success variable...
Then you have to align with ArkTransactionResponse - I think thouse two classes server same purpuose?

@sharkdev-j @dnovacik

This can be done - after #36 is completed

This is so we don't return errors in existing fields like Address for 'GetByAddress'.

Add fields

1. Success
2. Error

Rename DelegateVoter -> ArkDelegateVoter
Rename PeerStatus -> ArkPeerStatus

This is for consistency with the other models

1. Make private variables for passPhrase & secondPassPhrase
2. return all account info to _account in constructor using AccountService.GetByAddress.
3. Remove all passPhrase & secondPassPhrase parameters in all methods in AccountController. Replace with the _ variables

Create task async methods. This is necessary for mobile developement and a popular pattern within newly created apps.

typos and code formatting

Add methods...

1. GetStatus
2. GetSyncStatus
3. GetAutoConfigureParameters

Currently the blockservice is not in the solution. Just need to add it as a reference.

Add the following methods...

1. GetDelegates. Need to supply address
2. GetTop. Pass nullable param limit & offset

Update the info on the Read-me, do some re-up to make it current with the API.

1. Inside create class called ArkApiPaths and put in all the string path api calls in there. This will make the path api calls exposed to devs and not hard coded strings within the lib. A path example is '/peer/status'.

2. Replace all hard coded paths with static string variables.