Comments (2)
A lot of the unit tests just check for null when the objects being returned from the services will never be null. Need to add more Assert methods within the unit test functions to properly test them.
from ark-net.
I reworked some in my PR, but after it, we really should update them + I think some of the api calls no longer exist, so a test fails for no reason.
from ark-net.
Related Issues (20)
- Update properties in models to use correct types HOT 1
- Rename DelegateVoter & PeerStatus
- Create corresponding async methods in the services & controller HOT 1
- Change return type of PostTransaction to an object
- Create ErrorModel and extend models that can return an error HOT 2
- Change return type of methods in the AccountController to objects instead of tuples HOT 2
- Create until class ArkStaticStrings HOT 1
- code refactoring
- PeerCleaning and optimization
- rename ARKError
- create unit tests for async methods
- Add dev/main net switch for unit tests
- create send ark multiple broadcast in controller
- remove endpoint /api/accounts/top HOT 1
- Create Nuget package for both frameworks
- default.conf missing HOT 2
- Comment the whole API HOT 4
- Review the ReadMe HOT 1
- Adding New Image to header
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ark-net.