Git Product home page Git Product logo

github-defreshed's Issues

script errors normal??

after most recent updates I am getting script errors in tampermonkey(was using greasemonky but it was so inconsistent and only worked 1/2 the time, tampermonkey was much better)
and it shows a big red ! on the tampermonkey extension icon
image

Script does still work, but I have noticed it seems to dlitch sometimes as well and takes a couple refreshes to not have the "New" github layout

red ! icon
image

Github broke the UI again

Description

Today I opened the repository page, and it got stretched in an unnatural way. Reproducable both in chrome and firefox

Screenshot

изображение
изображение

Other information

Looks pretty good...

the one thing that was not restored is the 'followers' 'following' 'stars' links which were on the top in profile. other than that it looks like the old ui. of course I don't remember every single detail of the old ui, I would have to look at old screenshots, but it looks pretty close to it. looks better than the new ui that's for sure.

Request: Non-minified userscript

I don't suppose you'd be willing to provide us with a version of the userscript that hasn't been minified?
Yes, users who want to make adjustments could take the time to reformat and analyze the script themselves, or just write their own from scratch, but both of those seem rather wasteful when there's already an open-source project that does 99% of what you want it to.
It's just so much easier to figure out what's what if everything has intelligible and informative names.

Add Starred tab link to profile page

Not sure if this is achievable... but I felt like having the Stars tab back in the profile page instead on the left sidebar. Just a hyperlink tab would be good.

Anyway, this really made my day! This is really something soooooo great haha xD Can't resist my joy when I saw the old UI back.

"Error: @match: Invalid protocol (http*:) specified." when attempting to download the script

This was on Firefox 77, using GreaseMonkey, but Chrome also refused to download it from the link provided on the repository's main page (https://raw.githubusercontent.com/Kir-Antipov/GitHub-Defreshed/master/build/github-defreshed.user.js).

The script itself worked after manually building it with npm and replacing the http* part with https before importing it.

Thanks for your efforts, by the way! The repository page at least looks much less anger-inducing now, even if it took some custom CSS to undo the horrible style changes.

Remove Public/Private badge after repo name

Description

GitHub now adds a badge telling you if you're in a public or private repo after the repo name.

Public repo badge

Private repo badge

If I recall correctly, this badge used to exist only for private repos (as they went against the norm of GitHub).

I suggest that we get the option of removing this badge via one of three options:

  1. Remove badge for all repos
  2. Remove badge for private repos (old GitHub behavior)
  3. Keep badge for all repos

Other information

Why? Having the badge there is ugly (subjective), redundant with the icon in front of the name, and removes the 'normalcy' status of public repos by making them look just as awkward as private repos.

I can completely remove or keep the badge using custom uBlock origin filters, but I think the old GitHub behavior is best, and should be the default option.

Unable to command/ctrl click to open links in a new tab

Hi there, Thanks so much for all the work you put into this, it is impressive. One issue that I noticed is that when this is installed command click on links no longer opens them in a new tab.

It seems that some links work, but some do not. I am not sure the exact behavior causing it, but probably a preventDefault() somewhere where it should not be if (e.metaKey || e.ctrlKey) is pressed

Ah ya the problematic part looks to be:

a.addEventListener("click", async function(e) {
e.stopPropagation();
e.preventDefault();
navigate(getAbsoluteURL(this.href));
});

Anchor links also don’t seem to work correctly

No commits link

comes up as null null
Screenshot below as example
image

EDIT
I should add that is WITH the new "enhancement"
with it disabled it looks normal with commits in the old spot just like it always was
image

Add the version number to the summary bar

I always wanted to see the version number in the summary bar and that's something that was added somewhat hidden in the new crappy layout.

I think adding a popup that when hovering the releases button shows the latest version number/name and when it was released and then an option to change which shows in the popup and which in the text would be nice. This way both options can see the latest version number and the number of releases.

Originally posted by @An-dz in #21 (comment)

Is the padding right? Feels cramped...

I feel like this is much more padding than in my memory. Just look at all of this wasted space and how cramped everything is:
image
Could we get a way to adjust the padding?

Also, now that I found this image of how it used to be, I think I know the reason why I feel like the add-on is much more cramped and uncomfortable than it used to be. The problem is that it keeps the terrible new about sidebar thing.
How it used to be:
image
With the add-on (look at red square):
image
Is there a way to remove the new about sidebar thing with the add-on? Maybe add that too? I think doing that will make you have to add stuff back to the "tab bar" (bar where Code, Issues, Pull requests are). It made a lot more sense when that stuff was up there!

Also, you can see there is duplicate language info. If you want to keep the about sidebar enabled by default in the add-on, maybe you should make it remove the extra one to make it look less bad.
image

[BUG] Terrible performance on own profile page (Firefox only)

Description

This issue have been there since the beginning, and I can definitely say that it's not my browser messed up after long time use, as even after reinstalling the OS this issue was still existing, and as I reported previous bug, why not to report this one too! (:

This issue is very strange, and probably hard to reproduce.
When opening your own profile page (not anyone else's, otherwise it is alright), the page slows down the whole browser and everything is lagging a lot. It might last for as long as 5 seconds. When trying to scroll or hover over the links, it slows down even more, not touching the keyboard makes it lag less.

This issue seems to be occuring only on Firefox. I have disabled my adblock, tried in private mode and with no extensions except for Tampermonkey+Github defreshed, the issue persists. Tried in Chrome-no issues.

Screenshot

A video (:
Note my attempts trying to scroll the page

github-defreshed-lag.mp4

Other information

  • Link to page with the issue: Your own profile page (for me it's https://github.com/MrNaif2018, obviously)
  • Browser: Firefox 86.0
  • Operating System: Linux Mint 20 XFCE 64 bit
  • GitHub-Defreshed version: 4.2.1

I have tried to record a profiler dump, here it is:
https://share.firefox.dev/3cMGYd2

I don't really know how to read it, but from what I see, recalculating styles takes most of the time

Can't open repository page (Firefox)

Description

With the latest extension (in fact I'm not aware since which version), any repository page won't open, similar to #39 but with a different error log:
TypeError: can't access property "fetchData", e.index is undefined

Screenshot

image

Other information

Enabling the script renders all Project boards unusable

Hello again! I've discovered that enabling your script makes it impossible for me to use Project boards feature. As soon as I disable the script in GreaseMonkey and reload, everything works as expected again.

Screenshot: https://i.imgur.com/drJ287i.png
Example project: https://github.com/SacredDuckwhale/TestProject/projects/1

Hopefully this is enough to reproduce the problem.

It looks like the content isn't visible in the main container, presumably because the div with class="repository-content d-flex flex-auto container-lg" isn't sized properly? I've only taken a brief glance at the HTML, though.

Can't open repository page

Description

The repository page does not want to open with 4.3.1, had to revert to 4.3.0. Error log is below.

Everything else works.

Log

Uncaught (in promise) TypeError: Cannot read property 'whenDefined' of null
    at Object.<anonymous> (github-defreshed.user.js:16)
    at Generator.next (<anonymous>)
    at a (github-defreshed.user.js:16)

Other information

  • Link to page with the issue: https://github.com/Kir-Antipov/GitHub-Defreshed
  • Browser: Vivaldi w/ Chromium 91.0.4472.66 & Woolyss Ungoogled Chromium 90.0.4430.212
  • Operating System: Windows 10 x64 20H2
  • GitHub-Defreshed version: 4.3.1 user-script version

Wrong URL when there's only one contributor

Description

If the repository has only one contributor the URL in the repository "info header" points to the wrong address.

That's because it uses the button text as the URL and when there's only one it reads contributor in the singular form, while the real URL needs the plural form contributors.

Other information

  • Link to page with the issue: https://github.com/Kir-Antipov/Termigram
  • Browser: Ungoogled Chromium 98.0.4758.80 & Vivaldi 5.2 Blink 98.0.4758.88
  • Operating System: Windows 10 & Linux
  • GitHub-Defreshed version: 4.4.1

Top bar buttons displayed vertically when used together with Refined GitHub extension

Description

I have been using the script for a few weeks so far, and I am very happy with it. Thank you very much.

Now, I am not sure whether the culprit lies in this in the script, or rather in the Refined GitHub (https://github.com/sindresorhus/refined-github) extension, but when the two are used together, the buttons at the top are displayed as below.

One strange thing is that this does not happen always. Sometimes the buttons get lined up horizontally after a page refresh, but break again on a next reload. It seems as if there was a conflict between the script and the extension during the page load.

Screenshot

image

Other information

Top bar fails to render on refresh

When loading the code tab from a link or by doing a refresh the script fails to execute.

The log is basically that it could not find the DOM.

Fixer exception:  TypeError: Cannot read property 'querySelector' of null
    at x.isApplieble._createCommitsSummaryElement (github-defreshed.user.js:15)
    at x.isApplieble.apply (github-defreshed.user.js:15)
    at k (github-defreshed.user.js:15)

What should we do next?

The script fulfilled its main purpose and gave us back the old GitHub layout, but should we stop there? Or should we go further and implement some features that GitHub has always lacked?

Since we can customize the behavior of the script, there will be no conflict of interest for those who want to leave everything as it is and those who want to add something, so it seems to me that we can go ahead and expand the capabilities of GitHub.

What do you think about it? It would be great to hear your thoughts and suggestions!

Extension is broken after latest github design updates

Description

Recently github has been messing up with the UI (it all started with a nice kitty animation), so now repository pages at least return to something like "new" design again

In dev console I see:

Fixer exception: TypeError: t is null

It is probably occurring there:

t=e.querySelector(".gutter-condensed")

Also just noticed, contributor count seems to be wrong, or is it github-side bug?

Screenshot

изображение

Other information

  • Link to page with the issue: any repository front page
  • Browser: Firefox 93.0
  • Operating System: Linux Mint 20.2
  • GitHub-Defreshed version: 4.4.0

Preview changes to edited markdown files are not working

When I edit a markdown file, and click on the Preview changes, nothing happens. Also, the Commit changes button appears to be inactive. In order to preview or commit changes, I have to deactivate the GitHub-Defreshed (v 1.4.5) script in Tapermonkey.

Slimmer toolbars on repository page

Description

I am not 100% sure, but few updates back I have noticed that all toolbars (showing latest commit, issue filter, etc.) are now slimmer than before (looks like removed paddings). It was not so in the previous versions, and also not in the original github UI. Sorry if I missed some change, but I definitely remember it was not so before, see the screenshots below.

Screenshot

( Showing on my own repo, as I don't have any other screenshots from older versions of the script)

Current toolbars:

In the repo page:

изображение

In the issues filter:

изображение

Pull requests filter:

изображение

How was it back then:

At the initial versions of the script:

изображение

Few months after the creation of the script:

изображение

Other information

  • Link to page with the issue: Any repository page, for example, my repo
  • Web Archive example: Web archive seems to be unavailable now, see the screenshots above, will add an example when it's back up, but it's easy to find out
  • Browser: Firefox 86.0, tried in Chrome 89.0.4389.90, same issue
  • Operating System: Linux Mint 20.1 XFCE 64 bit
  • GitHub-Defreshed version: 4.2.1

Broken link for contributors on forks

On forked repositories the contributors link is broken, the user name is duplicated on the URL. I guess the reason is because GitHub decided to not show contributors on forks so the script fails to obtain the number of contributors and fallback to showing a single contributor.

Here's a repo that is a fork:
https://github.com/rust-lang/rust-enhanced

Seeing on archive that's something the redesign changed as it used to show up:
https://web.archive.org/web/20200530174346/https://github.com/rust-lang/rust-enhanced

No CI status displayed in commit message on repository front page

Hello! First of all, thank you very much for your extension to bring old good github back!
When viewing my repository front page, I don't see CI build mark (green checkmark or red depending on build status), but when viewing full commits list I can see that.
Version 1.6.0
Seems to be related to latest commit message "improvements".
Screenshots:
изображение
изображение

Different UI when opening master branch and a different branch (with branch diff message)

Hello! Thank you for quick version 2, and that's me once again telling about bugs (:
This bug appears when opening a branch different from master, the layout changes to something mixed between old and new style (actually it looks not bad :D, but commits link and some other stuff is hidden).
I can't seem to reproduce this on third-party repos, I can only reproduce it only on my repos, so looks like it is caused by "Recent pushes on some branch" message though I don't see it.
Link to the branch if it shows for you too
Version 2.0
Screenshots:
Default branch:
изображение
PR branch:
изображение

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.