Git Product home page Git Product logo

Comments (11)

Kir-Antipov avatar Kir-Antipov commented on July 27, 2024 1

Confirmed. Refined GitHub changes some tab buttons (and adds new), but it's using new layout (of course):

<li class="d-flex">
    <a href="js-selected-navigation-item UnderlineNav-item hx_underlinenav-item no-wrap js-responsive-underlinenav-item">...</a>
</li>

Not:

<li>
    <a href="js-selected-navigation-item reponav-item">...</a>
</li>

In Firefox extensions always run before user scripts, so GitHub-Defreshed can take care about new tabs, but in Chrome things seem kinda chaotic, so sometimes it's okay and sometimes not, just like you're saying.

from github-defreshed.

Kir-Antipov avatar Kir-Antipov commented on July 27, 2024 1

GitHub Defreshed is about "cosmetic stuff" too, so you're welcome to open new feature request issues about something you wanna see as part of GitHub Defreshed :)

from github-defreshed.

Kir-Antipov avatar Kir-Antipov commented on July 27, 2024

Well, that's interesting. At least I was unable to reproduce this behavior in Firefox (my home browser). Will try it in chromium later. Do you have any other GitHub scripts/extensions/styles installed (except Refined GitHub, of course)?

from github-defreshed.

tomasz1986 avatar tomasz1986 commented on July 27, 2024

No other GitHub-related additions on my side. I have tested only in Chromium, so I cannot speak for other browsers though. The issue is gone after disabling the Refined Github extension, but comes back immediately after re-enabling it.

As for the extension itself, I basically keep everything at default. It does have an option to add a Releases button to the top bar, which I suppose could potentially cause issues when used together with the script, but the buttons get moved like that even with that option disabled.

from github-defreshed.

Kir-Antipov avatar Kir-Antipov commented on July 27, 2024

Thanks for this information, hope it will help me to find out the problem's root :)

from github-defreshed.

Kir-Antipov avatar Kir-Antipov commented on July 27, 2024

But there's one thing: Refined GitHub does not really care about dynamic loading, so it's not really compatible with GitHub-Defreshed in general, so I don't think this small issue should be "fixed".

At this time the best I can offer you is implementing some features you've installed Refined GitHub for :)

from github-defreshed.

Kir-Antipov avatar Kir-Antipov commented on July 27, 2024

May be in future I'll change script's "engine" (the way it's handling GitHub dynamic page loading), but it's not the theme of the present day, so today Refined GitHub is totally incompatible with GitHub Defreshed just like many other GitHub scripts/extensions with each other, so I don't see any purpose to fix this small issue when the whole Refined GitHub is not doing well while GitHub Defreshed is active ¯\(ツ)

from github-defreshed.

Kir-Antipov avatar Kir-Antipov commented on July 27, 2024

Goddamn stale...

from github-defreshed.

tomasz1986 avatar tomasz1986 commented on July 27, 2024

At this time the best I can offer you is implementing some features you've installed Refined GitHub for :)

Thank you for the investigation. I am not really a heavy user or such, and the features I mostly "use" the Refined Github extension for seem to be mostly the cosmetic stuff, e.g. showing a download count next to files in Releases, showing usernames next to reactions, hiding useless "+1" comments, etc.

from github-defreshed.

Kir-Antipov avatar Kir-Antipov commented on July 27, 2024

I am currently working on a second engine for GitHub Defreshed that will be fully compatible with extensions like Refined GitHub, so it's time to reopen this issue

from github-defreshed.

Kir-Antipov avatar Kir-Antipov commented on July 27, 2024

v4.0.0 brings compatibility with another scripts and extensions by introducing pjax-based engine

from github-defreshed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.