Git Product home page Git Product logo

Comments (6)

AleCaste avatar AleCaste commented on July 17, 2024

After having a look at jqlite.js I believe the code that says (lines 661-663):

          if( this[i].classList.item(className) ) {
              return true;
          }

Should be replaced with something like:

        for( var i2 = 0, len2 = this[i].classList.length; i2 < len2 ; i2++ ) {
          if(this[i].classList.item(i2)==className) {
              return true;
          }
        }

Or am I wrong?

from jqlite.

jgermade avatar jgermade commented on July 17, 2024

Fixed in commit 105f8de (new release v0.2.5)

thanks @AleCaste !!

from jqlite.

AleCaste avatar AleCaste commented on July 17, 2024

You're welcome.
I can see you've used the method 'contains' in the fix, but I'm not quite sure if that would work on the client side on all browsers. Would the array method 'indexOf' be a better alternative in this case?

from jqlite.

jgermade avatar jgermade commented on July 17, 2024

Hi @AleCaste this implementation is for browsers that support classList, old browsers will use the alternative definition of hasClass see code.

from jqlite.

AleCaste avatar AleCaste commented on July 17, 2024

Ahhh ok. I missed that. Thanks a lot for the clarification.

from jqlite.

jgermade avatar jgermade commented on July 17, 2024

ur welcome! thanks you for your feedback!

from jqlite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.