Comments (6)
After having a look at jqlite.js I believe the code that says (lines 661-663):
if( this[i].classList.item(className) ) {
return true;
}
Should be replaced with something like:
for( var i2 = 0, len2 = this[i].classList.length; i2 < len2 ; i2++ ) {
if(this[i].classList.item(i2)==className) {
return true;
}
}
Or am I wrong?
from jqlite.
Fixed in commit 105f8de (new release v0.2.5)
thanks @AleCaste !!
from jqlite.
You're welcome.
I can see you've used the method 'contains' in the fix, but I'm not quite sure if that would work on the client side on all browsers. Would the array method 'indexOf' be a better alternative in this case?
from jqlite.
Hi @AleCaste this implementation is for browsers that support classList, old browsers will use the alternative definition of hasClass see code.
from jqlite.
Ahhh ok. I missed that. Thanks a lot for the clarification.
from jqlite.
ur welcome! thanks you for your feedback!
from jqlite.
Related Issues (20)
- add .hide() and .show() function HOT 6
- add the .add() function HOT 3
- adding CSS functionality HOT 3
- add .prev() , .prevAll() , .siblings() functions HOT 4
- binding and unbinding keypress HOT 9
- one() on multiple elements only unbind the activated element HOT 6
- How to use with browserify HOT 6
- Data API should be stored object HOT 3
- Style change event detection HOT 1
- filterDuplicated Error HOT 1
- Re-consider ListDOM'a array-like object implementation HOT 2
- How to avoid collision with Jquery HOT 22
- Adding WrapAll() and unWrap() function HOT 2
- Unbind all listeners of the same event type HOT 10
- Supporting extend method HOT 6
- considering add dataset, classList polyfills HOT 2
- "hasClass" logic in toggleClass function HOT 3
- classListMethods never declared HOT 1
- TypeError: Cannot read property "prototype" from undefined HOT 4
- Minified jqlite does not work in browser HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jqlite.