one() on multiple elements only unbind the activated element about jqlite HOT 6 CLOSED

I also tried to use an event handler as so:

function foo(){
  var buttons = $(document.body).find('.elem1 , elem2');

  var myEventHandler = function(){
    //some code...
    buttons.off('click', myEventHandler);
  }

  buttons.on('click', myEventHandler);
}

but with no avail, the result was the same as i got with the one() function where only the pressed button got the event removed from it

from jqlite.

Hi @RongBranovate, this is a hard question.

It was hard because handler is embeded into a function autoDetach(handler) wrapper. So the handler is not the function that is attached.

Finally I've created a onceListeners collector and is passing tests for release: v0.2.12

please tell me if is working for you. And thanks, as always!!

from jqlite.

Hi @jgermade, this is still an issue.

I am using the first method i describered and from what i'm seeing, in jqlite.js lines 1242-1245:

  var index = onceListeners.indexOf(listenerData);
          if( index >= 0 ) {
            onceListeners.splice(index, 1);
          }

If i have 2 elements with that event the onceListeners.splice only removes one of them(the one that got pressed), the other one is still assigned and will fire when pressed.

from jqlite.

Hi @RongBranovate , I think this is the expected behavior (like jquery).

Maybe this snippet can help you:

demo in plunker

<div>
      <button class="once">Button 1</button>
    </div>
    <div>
      <button class="once">Button 2</button>
    </div>
    <div>
      <button class="once">Button 3</button>
    </div>
    <div>
      <button class="once">Button 4</button>
    </div>

    <br/>

    <div>
      <button class="reset">Reset</button>
    </div>

$(function () {

  var jButtons = $('button.once');

  function clickOnce (e) {
    alert('clicked ' + e.target.textContent);
    jButtons.off('click', clickOnce);
  }

  jButtons.one('click', clickOnce);

  $('button.reset').click(function () {
    jButtons.off('click', clickOnce);
    jButtons.one('click', clickOnce);
  });

});

from jqlite.

Hi @jgermade

YES! This worked! thanks alot!

from jqlite.

thanks you @RongBranovate !!

from jqlite.