TypeError: Cannot read property "prototype" from undefined about jqlite HOT 4 CLOSED

Hi @binarykitchen, thanks for your feedback!

I'm a bit confused, this seems to be an angular.js issue, contains method is not provided by jqlite.

Could you provide a playground to test this behavior?

from jqlite.

i am afraid, i cannot reduce this to a small test case. things in the angular code seem to be too bloated.

but i think we should add a check whether window.Node is defined. if not, then use that function.

from jqlite.

Hi again @binarykitchen , I've added $.contains method to jqLite, maybe this can be helpful for you.

According to angular issue #10259, this behavior can be escaped with following snippet:

if (typeof SVGElement.prototype.contains == 'undefined') {
  SVGElement.prototype.contains = HTMLDivElement.prototype.contains;
}

In general, I prefer to avoid add hacks and polyfills to jqLite in order to avoid mistake libraries that detects browser support (like modernizr)

from jqlite.

@jgermade do i need to replace the buggy code

var jqLiteContains = window.Node.prototype.contains || /** @this */ function(arg) {
// eslint-disable-next-line no-bitwise
return !!(this.compareDocumentPosition(arg) & 16);
};

with if (typeof SVGElement.prototype.contains == 'undefined') {
SVGElement.prototype.contains = HTMLDivElement.prototype.contains;
}

or do it need to place it somewhere

from jqlite.