khronosgroup / vulkan-samples-deprecated Goto Github PK

All convert tools i found do not support KTX texture, and glTF 1.0 ,1.1 spec does not support KTX texture.

Which tool did J.M.P. van Waveren use?

The function here looks wrong:
https://github.com/KhronosGroup/Vulkan-Samples/blob/master/samples/apps/atw/scenes/scene_perf.h#L1706

The UBO buffers are being copied from a wrong memory in case of multiview. I think that it should look like this:

static void ksPerfScene_UpdateBuffers( ksGpuCommandBuffer * commandBuffer, ksPerfScene * scene, const ksViewState * viewState, const int eye )
{
ksMatrix4x4f * sceneMatrices = NULL;
ksGpuBuffer * sceneMatricesBuffer = ksGpuCommandBuffer_MapBuffer( commandBuffer, &scene->sceneMatrices, (void **)&sceneMatrices );
const int count = ( eye == 2 ) ? 2 : 1;
const int offset = ( eye == 2) ? 0 : eye;

memcpy( sceneMatrices + 0 * count, &viewState->viewMatrix[offset], count * sizeof( ksMatrix4x4f ) );
memcpy( sceneMatrices + 1 * count, &viewState->projectionMatrix[offset], count * sizeof( ksMatrix4x4f ) );
ksGpuCommandBuffer_UnmapBuffer( commandBuffer, &scene->sceneMatrices, sceneMatricesBuffer, KS_GPU_BUFFER_UNMAP_TYPE_COPY_BACK );
}

In samples/apps/atw/atw_vulkan.c, srcOffsets[1].z and dstOffsets[1].z are being set to 0 on vkCmdBlitImage(). However, according to the spec:

If the calling command’s srcImage is of type VK_IMAGE_TYPE_1D or VK_IMAGE_TYPE_2D, then srcOffset[0].z must be 0 and srcOffset[1].z must be 1.
[...]
If the calling command’s dstImage is of type VK_IMAGE_TYPE_1D or VK_IMAGE_TYPE_2D, then dstOffset[0].z must be 0 and dstOffset[1].z must be 1.

The app got stuck after showing one frame on Android 7 (MI 5, MIUI 8)
log:
com.vulkansamples.atw_vulkan V/atw: --------------------------------
/com.vulkansamples.atw_vulkan V/atw: OS : Android 7.1.1 (18)
com.vulkansamples.atw_vulkan V/atw: CPU : Qualcomm Technologies, Inc MSM8953Pro - AArch64 Processor rev 4 (aarch64)
com.vulkansamples.atw_vulkan V/atw: GPU : Adreno (TM) 506
com.vulkansamples.atw_vulkan V/atw: Vulkan : 1.0.20
com.vulkansamples.atw_vulkan V/atw: Display : 1920 x 1080 - 60 Hz (fullscreen)
com.vulkansamples.atw_vulkan V/atw: Eye Img : 1024 x 1024 - 1x MSAA
com.vulkansamples.atw_vulkan V/atw: --------------------------------
com.vulkansamples.atw_vulkan W/Adreno-GSL: <gsl_ldd_control:467>: ioctl fd 52 code 0xc040094a (IOCTL_KGSL_GPU_COMMAND) failed: errno 71 Protocol error
com.vulkansamples.atw_vulkan W/Adreno-GSL: <log_gpu_snapshot:376>: panel.gpuSnapshotPath is not set.not generating user snapshot
com.vulkansamples.atw_vulkan I/System: Daemon delayGCRequest, sDelayGCRequest=true, delay=false, sPendingGCRequest=false

After some googling I've discovered that appending ?ts=4 to URLs makes the code render correctly.
https://github.com/KhronosGroup/Vulkan-Samples/blob/master/samples/apps/atw/atw_vulkan.c?ts=4

Setting this at the project/file level in github would be preferred. Contact github for how to implement this.

I tried building the Vulkan-Samples with a recent GCC version (6.2.0 as shipped by Debian Stretch) but gut a failure for the binaries in apps/atw:

/tmp/test-vk/Vulkan-Samples/samples/apps/atw/atw_cpu_dsp.c: In function ‘Signal_Wait’:
/tmp/test-vk/Vulkan-Samples/samples/apps/atw/atw_cpu_dsp.c:6262:20: error: storage size of ‘ts’ isn’t known
    struct timespec ts;
                    ^~

The problem seems to be, that timespec is not defined with -std=c99. The patch at https://gist.github.com/TheRealCuran/08a3a62c8c03bebb38f4c0cd43120fad fixes this issue for me (sorry for the Gist mess, but apparently GitHub doesn't like patches).

To fix this contact github as the error page suggests.

https://github.com/KhronosGroup/Vulkan-Samples/blame/master/samples/apps/atw/atw_opengl.c
https://github.com/KhronosGroup/Vulkan-Samples/blame/master/samples/apps/atw/atw_vulkan.c

This page is taking way too long to load.

Sorry about that. Please try refreshing and contact us if the problem persists.

Contact Support — GitHub Status — @githubstatus

The issue title is the question.

Looks like the root of the problem is that context selection or binding seems to have failed, and it crashes somewhere trying to check extension availability.

Hello,

Here is the output when I'm launching the demo :

Device Name          : AMD Radeon R9 200 Series
Device Type          : discrete GPU
Vendor ID            : XxXXXX
Device ID            : XxXXXX
Driver Version       : 1.2.0
API Version          : 1.0.17
Queue Families       : 0 = graphics compute transfer (1 queues, 2 priorities)
                       1 = compute transfer (2 queues, 2 priorities)
                       2 = transfer (2 queues, 2 priorities)
Required work queue family not supported.

No capable Vulkan physical device found.'atw_vulkan.exe' (Win32)

Sould I understand that my device is not compatible ?
If not, does it mean the code is developped for specific hardware ?

Thanks you.

At https://github.com/KhronosGroup/Vulkan-Samples/blob/master/samples/apps/atw/atw_vulkan.c?ts=4#L4299 in the case of a false return code from #L4134 ,where current desktop size is still unset, results in these unset values later being used to recover the desktop size at #L4249 .

Clearing windowFullscreen would prevent this, but perhaps it would be better to bail in that case.

In atw_vulkan.c, at least, dlsym is used as though it's guarantied the symbol being looked up exists. This may not be correct as it assumes that the Vulkan Loader was built and installed correctly.

To be correct dlsym should be wrapped in dlerror calls and given the usage here it may make sense to put this handling into a function that reports error and exits on symbol not found.

Vulkan 1.0 documentation has been released but this repo is still empty. Why so?