khan / babyhint Goto Github PK

After looking at the code a bit I realized that we don't use $ for anything other than the functions we attach to it in i18n.js I have to double check by I think part of the KA pipeline searches for $._() calls so we may still need to keep it on $, but the $ could just be a dummy object jQuery isn't already bound to $.

Some lines are really long and scrolling in github to see the whole line isn't fun 😞.

See http://editorconfig.org/ for more information.

eslint is more pluggable than jshint and has better support for es6.

This is so that we can use this module from live-editor which can't use modules yet.

• CLA
• coding style
• create an issue before a pull request
• ?

We use a custom fork of JSHint. It would be nice if it was included as a dependency so that people don't have to require it in their projects.

Add the following errors (requires renaming of these error codes):
E052: $.("I think you meant to type a value or variable name before that comma?"),
E053: $.("I think you either have an extra comma or a missing argument?")

In JSHint 2.8.0 they have:
E052: "Unclosed template literal.",
E053: "Export declaration must be in global scope.",
E054: "Class properties must be methods. Expected '(' but instead saw '{a}'.",
E055: "The '{a}' option cannot be set after any executable code."

We should also try to merge these errors with upstream JSHint

Right now it's sitting at 2.1.11 and a couple of the tests are failing because of it.