Git Product home page Git Product logo

quickmove-extension's Introduction

Quick Folder Move

This is the source code for Quick Folder Move, an add-on to quickly move emails into other folders in Thunderbird. The main purpose is to quickly triage emails using only the keyboard, but of course you can also use the mouse if you prefer.

Cmd+Shift+M (or Ctrl+Shift+N on Windows/Linux) opens a popup menu that allows you to move the selected messages. You can also assign keyboard shortcuts to copy, go to a folder, or apply tags via the shortcut manager.

Quickmove Toolbar

Development

As for versioning, please go ahead and bump the version number in each pull request. After 1.9 comes 2.0, even if it not a major change.

When testing, please keep in mind:

  • The popup can be opened in the message display action, or the main toolbar.
  • The popup can also be opened from a single message view, where the selected message is different.
  • It is possible the user removed the toolbar button.
  • There are different popup layouts to test on.

quickmove-extension's People

Contributors

dependabot[bot] avatar gfrenoy avatar jpyllman avatar kewisch avatar maherma-adg avatar paysplat avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

quickmove-extension's Issues

Lost e-mails

Where do e-mails go if moved into a folder which does not exist any more because they are renamed or moved?

Unfortunatelly there is no warning. So some mails are missing now....

Thanks a lot!

Tooltip shows encoded folder name for special character

Version: 2.0.0pre1

  1. Press Shift-M
  2. Enter a folder name which contains a special character (like รŸ).
    => The folder name is shown properly (with the special character).
  3. Hover the mouse.

Actual result: Tooltip is shown, but &AN8- is shown instead of รŸ.
Expected result: The full path should also show the special character properly.

Cannot enter space in Move search bar

When searching for a folder in the Move search bar (Shift-M), I cannot enter a space character, and thus cannot search specifically for folders that contain a space. This doesn't appear to be an issue with the Goto (Shift-G) and Copy (Shift-Y) search bars.

Create an option to show full path of folder

This is also one of the comments in the review and related to #25 #14 #2

At present the default behavior is just to show the "folder name" under the "Move To" option when seraching. It adds the account if there are two accounts with the same "folder name" and the pat if there are two identical "folder name" within the same account, but under different folders.

I'd really like, for example, to always see the full path with the account nearby.
Maybe some others would not like it.
It would be great to be able to decide the behavior.

Sort results by currently selected account

First: Thx for this great extension. I use it a lot.

I've set up multiple e-mail accounts in Thunderbird. When I use quickmove I always want to move a mail from one to another folder both belonging to the same account.
Quickmove lists all available folders also from all other accounts. It happens quite often to me, that I'm moving the mail into the wrong folder. Sometimes I don't even realize it and have to then to search my mail over all acounts and folders.

I have two suggestions how this could be improved:

  • sort folders list so that folders of my current selected account are always on top of the list
  • or only show folders of the current selected account

Indent Folder Names under each account

Please can you indent the folder names under each account?

I have about 12 accounts with multiple folders in each account with the same name (ie "Sales & Marketing" x12)

It would make it much easier to spot the account I need ;)

TIA

Option to exclude some folders

Hello,
Can you add an option to exclude some folders in suggestions menu ?

My workcase is : I have many folders in hierarchy grouped by years, I would only have suggestions for current year folder and subfolders.
A simpler workaround could be exclude Archive folder.

Thank you in advance for taking into account my proposal.

Input not recognised when typing too early.

Version: 2.0.0pre1

Steps to reproduce:

  1. Press Shift-G.
    => First, the Buttons "Move", "Copy" and "Goto" and a text box will appear.
  2. Immediately type something.

Expected result: The typed string is entered into the text box.
Actual result: The typed string does not appear in the text box. Instead, it is apparently still processed by the folder list, and can trigger (via keyboard shortcuts) actions like watching a thread.

Support of tag management

This extension is sometimes mentioned as a replacement of the Nostalgy or Nostalgy++ TB add-ons.
QuickMove could be a serious alternative if the management of tags was also supported.

I don't know if this is included in your plans / roadmap. This does not seem to be mentionned in the issues so far, so I was asking, just in case.

After removing an attachment, moving a message does not work.

Version: 2.0.0pre1

Steps to reproduce:

  1. Select a message with attachment.
  2. Detach an attachment.
  3. Press Shift-M, select a folder and confirm.

Expected result: Message is moved to that folder.
Actual result: Nothing happens.

I tried various things to recover:

  • Select a different message and then the same one again. Repeat step 3. => Still nothing happens.
  • Restart Thunderbird, repeat steps 1 and 3 => Message is moved.

I also tried moving a message with Drag&Drop after detaching an attachment. That works just fine.

TB76.0b1: type error for parameter accounts (Error processing 0: Unexpected property "identities") for quickmove.sortAccounts. at popup.js:22:38

I'm using 2.0.0pre1.

With Thunderbird 76.0b1, the folder list does not get displayed.

Steps to reproduce:

  1. In Inbox, focus on the message list, press "G".

Actual result: The popup opens, but the list of folders is empty.
Expected result: After max. 1 second, the list in the popup contains folders.

In the debugger, I see the following:

Content Security Policy: Die Einstellungen der Seite haben das Laden einer Ressource auf inline blockiert ("default-src"). panel.js:62:24
Error: Type error for parameter accounts (Error processing 0: Unexpected property "identities") for quickmove.sortAccounts. popup.js:22:38

popup.js:22 is:

accounts = await browser.quickmove.sortAccounts(accounts);

Indeed this no longer matches schema.json, identities apparently has been added.

Support for dark theme in webextensions

I have been testing the 2.0pre1 version. The webextensions version. And the biggest 'thing' I see at the moment is that the popup menu does not follow the OS or Thunderbird theme settings. I like darkt themes, that mean white text. And since the popup stay white even in dark mode it is white text on white background in the input field.

Just wanted you to know.

Mark messages as unread when moving

There is a option for: Mark messages as read when moving
Is it possible to add another option for Mark messages as unread when moving.

This is useful as I quickly move messages to folders categorized as today, this week and later. I want them to be unread, so that I can see the count of unread messages!

Searching in the folder list stopped working (for non-top-level folders?)

I just upgraded to Thunderbird 74.0 beta 1. QFM version is 2.0.0pre1.

Now I now longer get proper results when searching in the folder list.

Steps to reproduce:

  1. In the message list, press Shift-G.
    => The popup appears, "Goto" is selected, the folder list contains some names (apparently recent folders). This is as expected.
  2. Wait long enough, then type "Pos".
    => Two "Posteingang" (German for "Inbox") folders are shown (for two different accounts). This is as expected.
  3. Type letters of any other folder.
    => List becomes empty. Expected would be: That folder is shown in the list.

Could this be related to this entry in the Changelog: "MailExtensions: Changed folder enumeration to return tree structure rather than list"?

Option to include path in search

I have a large, complex, folder structure. Includes multiple folders of the same name, for example: alpha/foobar, beta/foobar, gamma/foobar, etc.

If I search foobar, all the folders appear in the list (often 10+ results) and then I have to click or use arrow keys to select the specific one. It would be extremely beneficial to have an option to search with path included, for example: searching alpha/foobar which would then have just that folder pop up.

If implemented, this should probably be an option. There are likely performance implications not all users may want. (By the looks of quickmove.suffixTree = new MultiSuffixTree(allNames, allFolders);) - however, for me, I would save so much time (and make far fewer mistakes) if I could include / in the search for searching path.

Display last move in TB status bar

As a former user of Nostalgy, I find that having the last know target folder displayed in the TB status bar was useful. Often I move messages between other distractions, and having such a memory aid is useful.

Folder sort during search

In the move popup, the default folder sort is most-recently-used. However, if you start to type, it gives search matches, which seem to be in alphabetical order. I humbly request that this might be even more useful if the sort is also most-recently-used.

I think I know how to implement this: in src/content/quickmove.js, line 327, we can sort the list using folders.sort(sorter). However, I don't know how to test this myself as I don't have a Thunderbird plugin development setup yet.

Moving an item causes previous focus to be lost

When I use shift+M and then select a folder to move an item into, I find that the previous focus in the Thunderbird UI is sometimes lost. I can most reliably get the focus to be lost by tabbing away from the message list and then using shift+M. Usually when the message list has focus, it keeps it. I thought I had seen the message list lose focus as well during regular use but I can't reproduce that behavior purposefully. After shift+M with something other than the message list focused, tab does not seem to focus anything. The only way I can get focus back is by using ctrl+K to focus the search bar and then tabbing away from there.

It would be nice if the extension could restore focus to an element after performing the move and hiding the popup so that tab could work again.

Some background: I don't actually use tab to navigate. I use tbkeys. When the focus disappears and tab stops working, my j/k shortcuts in tbkeys for focusing the next/previous message also stop working. Also the built in shortcuts like b/f/p/n stop working as well. It would be great if anything in the UI could be focused so that these shortcuts would keep working.

Arrow up should move highlight to bottom of list of results

When the result of a search operation is a long list, it would be convenient to not only be able to move the highlight through the list with arrow down key from the top, but also to be able to use arrow up key to start from the bottom. This saves a lot of key strokes!

Thanks, Thomas

"Send Later" column displays in Inbox upon startup of TB

When I start TB (currently 78.3.1 (64-bit) on Red Hat Enterprise Linux Workstation release 7.9 (Maipo), The "Send Later" column displays in Inbox in spite of disabling it. See the following image:

image

When I navigate to another folder (i.e., Drafts) and back to the Inbox, then "Send Later" column disappears.

I am currently using QM version 1.9.0:

image

There seems to be a preferences initialization problem upon startup.

Support Thunderbird 68.0

This is an awesome plugin I use daily.

It would be nice if the recent TB version would be supported.

No Work with TB 91.2

With the new Thunderbird version 91.2 distributed via update, the Move menu no longer works. No entries of the last moved emails are displayed.

Mouse hover over list of folders takes away focus from search

In the webextension version. If the mouse pointer happens to be where the list of folders are it will take away the focus from where you enter your search. This often makes me do unknown things to the messages in the folder I was trying messages from.

Find folder field in a toolbar

Is it possible to create a new field, always visible, to search folder (now it opens with Shift+G) and to add ti to a Toolbar (for example "Mail Toolbar") through "Customize" action?

Inconsistent display of folder hierarchy

Ubuntu 18.04
Quick Move 1.7.1

I have a folder "Stuff" with hierarchy Inbox/Work/Stuff. When I first press Ctrl + M it shows up in the recent folder list as "Stuff" but when I start typing the folder name "Stuff" it shows up in that search list as "Inbox/Work/Stuff". The inconsistency between those 2 display formats (short and full path) is a bit disconcerting. I would rather have it all one way or the other.

Certainly not a huge problem.

2.0.0.0pre1 identical folders

in 2.0.0pre1, when I click Shift + M, one of my email accounts shows 2 identically named folders. I don't think that there are 2 folders with the same name, but if there are there needs to be a way to tell them apart.

Allow moving through list with Tab/Shift+Tab

It would be great if you could move through the pop-up list with the Tab and Shift+Tab keys instead of just the arrow keys, this way you wouldn't have to constantly move your hand to the arrow keys just to press Down once or twice. It would be even better if in addition to this the top-most entry would be automatically selected so often you wouldn't even have to move the selection at all. Thanks!

Move is canceled when hitting enter too quickly

v1.8.2

When I type shift-M, then a folder name, then enter, the move is not correctly executed unless I wait for the search-result folder display to come up before hitting enter. This is not an issue of the typing not making it into the text box (which is issue #13). The text does appear in the box, but it takes QFM about 0.5 seconds to search through my list of numerous folders to generate the matching list. If I hit enter before that list comes up, the "enter" will be associated with the default folder list and not the folder name I just typed.

Make hotkeys configurable

It would be nice if the hotkeys (Shift + M/Y/G) would be configurable so that I could use the Nostalgy hotkeys (G/S/B/C) which I'm accustomed to and which I like because they work without having to press the Shift key.

Bug - Parameter Number of Recent folder - 0

Hello,

When we parameter "Number of recent folder" to 0 : at the restart the extension failed.

To re-enabled the plugin we need to set the parameter to "1", quit, and re-set the parameter to "0"

Ctrl + M sometimes shows contents of clipboard

Thunderbird 68.2.2
Ubuntu 18.04
Quick Folder Move 1.7.0pre2

I can't reproduce this at will. It is not a new but, it was happening in versions before 1.7.

Sometimes when I hit Ctrl + M to move a message, the contents of the clipboard shows up in the box where you can type the destination folder name. I get around it by clicking to another message then back to the original message.

1.7: Problem with Addon AttachmentCount

Thankyou for Version 1.7. of "Schnelles Nachrichtenverschieben"!
It work fine!
But: There is a collision with addon "attachment count": https://bitbucket.org/alta8888/attachmentcount/wiki/Home.
I have TB 68.3.1 and attachment count V. 5.4.
Normally there is a column of attachment count in the messages pane.
As soon as "quickmove" is installed, the column of attachment count is gone (although attachment count is still activated).
Could you please look into that?
Thank you very much!

Folder list displayed in single line when search results too long

When searching with SHIFT-G for a common term in my folders (e.g. just a few letters, but also something like "201" where all years 201? are matched, the results list snaps to a single line. This is still usable in principle by scrolling and resizes to usable size once the results are narrowed down, but is still unexpected behaviour.
With SHIFT-M, the behaviour is different, but the location of the popup-menu jumps around depending on length of results list: if scrolling is required, it moves to the vertical center of the screen, if scrolling is not required it jumps to the location of the message it was invoked on.
grafik

Inconsistent Undo Behaviour

Version: 2.0.0pre1
Thunderbird: 68.3.0
OS: Windows 10

Steps to reproduce:

  1. Move an email to a folder
  2. Undo the action

Expected result:
Email reappears

Actual result:
Performs the last "non-quickmove" action (e.g. restoring a deleted email)

Tooltiptext is missing on Addon Page

With '_locales/messages.json' the toolotiptext seems to be defined for at least 'maxRecentFolders' element ('maxRecentFolders.title'), but on the addon-manager page there is no popup for it.
On other elements like 'Standard' or on the buttons the 'tooltiptext' pops up.
Maybe a general issue with the options.js/.html on the addon-manager page?

folder view reset on shift+G

I just migrated from Nostalgy to your extension and find this behavior surprising:

Steps to reproduce:

  1. Set folder view to unread: View->Folders->Unread
  2. Go to a folder which is not shown in the folder pane (because it does not contain unread messages): Shift+G a_folder_without_unread_messages

Actual result:
Folder view switches to "All" (a change from "Unread")

Expected result:
Folder view setting is left untouched.

Maybe it is intentional - in that case may I suggest adding an option to settings to disable this?

Use-case: I have lots and lots of folders which are used only as "filling cabinet" when a message was processed. Displaying them in folder pane obscures folders with unread messages, making it too easy to overlook a message filled into a folder by message filters.

Thank you for considering this change.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.