kelvintegelaar / cipp Goto Github PK

Describe the bug
The $.datatable call doesn't have a way of handling errors.

To Reproduce
Steps to reproduce the behavior:

1. Go to a datatable that may produce an error.
2. Check the console/network info for a 404 or 500
3. Datatable will not load when the API has produced an error.

Expected behavior
Notify the user that an error has occurred from the API.

Desktop (please complete the following information):

• OS: Windows
• Browser Brave

This can be handled a number of ways. I personally like using Toastr for something like this.

Describe the bug
On the Tenant Dashboard URLs to the portal load inside the same window as the Dashboard

To Reproduce
Steps to reproduce the behavior:

1. Go to Administration > Tenants
2. Click on a link

Expected behavior
It should open in a new tab

Ability to run a message trace. "summary report" with an option of getting more details
Input

• Time Range "2 days default setting"
• Senders address (drop down list of accounts or free textbox)
• Recipients address (drop down list of accounts or free textbox)

Output

• Date
• Recipient
• Subject
• Status

Get-MessageTrace
Get-MessageTraceDetail

Enable SMTP Auth would be nice.
We now do this with Powershell
Command used:

Check: Get-TransportConfig | Format-List SmtpClientAuthenticationDisabled

Enable SMTP: Set-TransportConfig -SmtpClientAuthenticationDisabled $false

Don't seem to be able to select many regions, have tried in multiple tenants to make sure it's not some fancy setting I'm missing.

Would like to be able to deploy in Australia

Add ability to view restricted users for a tenant and remove block

Get-BlockedSenderAddress

Remove-BlockedSenderAddress -SenderAddress

Is your feature request related to a problem? Please describe.
User List butons

Describe the solution you'd like
Make spacing on buttons wider
Add confimation before running command

When we click on the M365 portal link we get an error.
Is this because of some rights in the Secure App? Or Something different.

The Exchange Portal Works same for other portals.

When adding a new group, make the tenant selector field mandatory before you can fill in the details below.

Describe the bug
Tenants added to the "Excluded Tenants" list are not excluded from the tenants listed even after clearing the Tenant Cache

To Reproduce
Steps to reproduce the behavior:

1. Go to Seetings - Tenants
2. Add a Tenant to be Excluded, Tenant appears in Excluded Tenants list
3. Go to Profile Tab (Generic Settings)
4. Click "Clear Tenant Cache" button (this never seems to finish BTW)
5. Return to any feature that lists tenants (e.g. Users) and the excluded tenants are still visible.

Expected behavior
Tenants added to the "Excluded Tenants" list should not appear in and tenant select drop downs or searches

Desktop (please complete the following information):

• OS: Windows 11
• Browser Edge Chromium
• Version 94.0.992.47

Additional context
Latest version from GitHub, fetched and merged 5 minutes before test.

Describe the bug
MFA Report does not load

To Reproduce
Steps to reproduce the behavior:

1. Go to Reports, MFA Reports, Select the Tenant
2. MFA Report just stays at loading....

Expected behavior
Expect to see a list of users and their MFA Status

Screenshots

Desktop (please complete the following information):

• OS: Windows 11
• Browser Edge
• Version 94.0.992.50

Under /?page=Addstandard .. Have the ability to set a 'standard' for max email attachment size for the tenant.

Get-MailboxPlan | Set-MailboxPlan -MaxSendSize 150MB -MaxReceiveSize 150MB

Describe the bug
Back to Users Button, takes you back to user list but removes current tenant detials

To Reproduce
Steps to reproduce the behavior:

1. Go to User
2. Click on cog (on user line)
3. Click on Back to Users (top right)
4. See error

Expected behavior
keep current tenant active

Desktop (please complete the following information):

• OS: Windows 10
• Browser edge

Is your feature request related to a problem? Please describe.
Add mobile device information per mailbox

Describe the solution you'd like
Add mobile device information per mailbox

Describe alternatives you've considered
Using the 365 portal.

Is your feature request related to a problem? Please describe.
The logging engine currently works by adding entries to a text file, using a mutex to prevent parallel write issues. This works OKish but could use some improvements.

I'd also like to have logs be in a better format. We currently use

DATE, USER, MESSAGE, SEVERITY

I am proposing changing this to:

DATE, USER, TENANT, MESSAGE, SEVERITY

Each API should post to the log without exception. Severity levels should be:

DEBUG
INFO
WARN
ERROR
CRITICAL

By default, the log should only return the INFO/WARN/ERROR levels, and have a selection option for the full log.

Is your feature request related to a problem? Please describe.
When you run the message trace report display newest items first and show what timezone the date format is "UTC"
Make date column wider

Is your feature request related to a problem? Please describe.
When clicking password reset at the moment it generates a password and forces change at next login.

Add additional box to ask for "create password automatically" "require password change at next login" like the new user form

Password reset button

New user form

Describe the bug
Link to documentation page is 404

To Reproduce
Steps to reproduce the behavior:

1. Go to '/index.html?page=AddPolicy'
2. Select a tenant and click next
3. Click "this link" for doc on raw JSON help
4. 404

Screenshots

Describe the bug
Link to documentation is 404

To Reproduce
Steps to reproduce the behavior:

1. Go to '/index.html'
2. Click on 'Documentation' (header menu)
3. Click on 'Documentation' (it points to https://github.com/KelvinTegelaar/CIPP/Documentation which doesn't exist)
4. See error

Describe the bug
Sort order for tenants. It had a space at the beginning it has now been fixed in office365 but the list has not updated. I have even removed the M to see if that forces a refresh. I have left it over night.

Screenshots

When adding a "user" allow system wide default setting for "Usage location"

Is your feature request related to a problem? Please describe.
When Microsoft imports a new tenant contract it only updates that information a single time; at creation. This means if the tenant had the wrong name, or changed names/domains they will forever be listed like that in your contracts list.

We can use the following to edit tenants:

•    Log into Azure Graph API through the URL https://graphexplorer.azurewebsites.net  using your Global Admin & Admin agent credentials.  
•    Then execute the GET call to get the list of the Partner Contacts using the following REST Call  
o    GET https://graph.windows.net/myorganization/contracts?     [api-version=1.6]
•    From here copy the Object ID of the customer.
•    With the help of following PATCH call, please update the display domain of the Customer: 
o    PATCH https://graph.windows.net/myorganization/contracts/<object-id-of-contract>?    [api-version=1.6] 
{"defaultDomainName":"NEWDEFAULTDOMAINNAME"}

Maybe we can include a edit button on the tenants list, to allow change of the returned properties:

    "contractType": "3",
    "customerContextId": "8dde2954-2562-48c7-a555-cccc",
    "defaultDomainName": "cccc.onmicrosoft.com",
    "displayName": "xxxx BV"

We could also add the delete button, but this is quite destructive and I'm not 100% confident it's needed.

Describe the bug
sync ajax calls can cause little hangs in the app, that are quite annoying. I think setting async to true everywhere should resolve, but needs to be tested first.

To Reproduce
Steps to reproduce the behavior:

1. Go to tenants
2. Click on tenantlist
3. possible hang event, can even crash page if you force a reload during

Expected behavior
no hang events.

Desktop (please complete the following information):

• OS: W11
• Browser: Chrome
• Version latest

Change hint "disable user" to "Block sign in" to match portal text.

Describe the solution you'd like
Under the add standards section, I'd like a standard option for removing anonymous sharing from OneDrive and SharePoint.

This is a common element I do manually for all new tenants.

Mailbox Stats keep loading;
Wait 5 min and still no results.

Describe the bug
Duplicate word on page
To Reproduce
Steps to reproduce the behavior:

1. Go to '//index.html?page=Addstandard'
2. Click next to step 2
3. Enable Usernames instead of pseudo anonymised names (names) in reports

Screenshots

Desktop (please complete the following information):

• OS: Win 10
• Browser edge

Is your feature request related to a problem? Please describe.
A useful standard we already keep for our tenants is disabling of shared mailboxes. I'm unsure why Microsoft doesn't do this already, but my understanding is that shared mailboxes can be logged into. So it is best practice to ensure they are disabled.

Describe the solution you'd like
Create a standard to make sure all shared mailboxes have sign-in disabled.

Describe the bug
When a page with a data table is loaded, before a tenant is selected, the page calls the Azure Function unnecessarily. This slows down the load of the page and can cause a temporary micro hang, triggers the functions with error output and causes unnecessary usage of resource (potentially increasing cost unnecessarily in a consumption plan)

To Reproduce
Steps to reproduce the behavior:

1. In the function app, go in to the ListSites function and Code + Test
2. Click on Logs to expand and stream logs live for the function, connecting you to the log streaming service
3. In a different window, navigate to Sharepoint > List Sharepoint
4. Note the error that displays in the log stream as the function has been called unnecessarily and without tenant information

Expected behavior
No call to the function should be made until a tenant is selected

Desktop (please complete the following information):

• OS: Windows 11
• Browser: Edge
• Version: v.latest

Describe the bug
when you click the PDF button it does not output correctly

Screenshots

Desktop (please complete the following information):

• OS: windows 10
• Browser edge
• Version 94.0.992.50

Describe the bug

1. In the primary readme.md file (https://github.com/KelvinTegelaar/CIPP/blob/master/README.md) the link to the Security.md file is broken (possibly a case sensitive link, security.md vs Security.md).
2. https://github.com/KelvinTegelaar/CIPP/blob/master/Documentation/Security.md, also contains the same broken link to security.md as the best place to report security related issues. I'm guessing this is supposed to be a link to https://github.com/KelvinTegelaar/CIPP/security but not really sure.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'https://github.com/KelvinTegelaar/CIPP/blob/master/Documentation/Security.md#reporting-a-vulnerability'
2. Click on the link to "our security page"
3. Scroll down to a Github 404 page
4. See error

Discussed in #49

When adding a new user, make the tenant selector field mandatory before you can fill in the details below.

When you create a new user show username on confirmation box and format correctly so its easy to copy username/password

Might look like
Success User has been created.
USER: [email protected]
PASSWORD: 1234567

Describe the bug
On users, when clicking "mange groups" it drops the selected tenant.
Same happens from groups

To Reproduce
Steps to reproduce the behavior:

1. Go to User
2. Select a tenant
3. Click on Mange Groups

Screenshots

Desktop (please complete the following information):

• OS: windows 10
• Browser edge

Swap "tenant" and "Identity" on the left hand menu around as most management will be done on the users.

It would by very helpful to report the current status of each item that is settable via the Standards. This would allow a central place to determine if setting to standard would change the tenant's current configuration.

Ideally a single page with a matrix of the tenants and their related settings in regards to the items available to be set to a standard.

A button to refresh on demand would be great.

Is your feature request related to a problem? Please describe.
The critical alerts currently only show up in the logbook. It would be nice to have them on the homepage so it's possible to react based on it.

Describe the solution you'd like
A new API at /api/GenerateAlert that will be called each time a critical alert is generated.

Describe alternatives you've considered
E-mail notifications and Webhooks, these are on their way in a future release.

Additional context

One element of system administration that always made my life easier was AD user templates. Having pre-defined permissions, group memberships, ADSI customizations, profile settings all pre-populated was awesome.

M365 user templates suck and are all but pointless. They don't do anything except save a few clicks (they save no brainpower).

With CIPP I can foresee an alternative to AD user templates with something like 'copy user settings from other user' dropdown box.

Get-AzureADUserMembership -ObjectId {source user object id}|foreach { Add-AzureADGroupMember -ObjectId $_.ObjectId -RefObjectId {new user object id} }

Is your feature request related to a problem? Please describe.
I'd like the first settings page to contain a check for which permissions are active, and give a red X when a permission is not yet present. This should help in troubleshooting scenarios, as the Secure App Model can behave iffy sometimes.

Describe the solution you'd like
Go to settings
First page will run a compare of permissions vs active key permissions. If no key is found or logon is impossible, it will also note why.

Describe alternatives you've considered
None

Additional context
Add any other context or screenshots about the feature request here.

Describe the bug
When changing the pages via a <SpecialNavLink> the active marker of the page does not change.

To Reproduce
Steps to reproduce the behavior:

1. Go to home
2. Click on users
3. click on tenants
4. Users is still the selected active menu item.

Expected behavior
Menu item must change

Additional context
This is a known issue, will be worked on.

Describe the bug
When searching in certain conditions the tenant selector returns two of the same tenant

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Sharepoint > List Sharepoint'
2. Click on Tenant selector and search for a tenant name
3. See multiple results with the same information

Expected behavior
One search result presented when selecting a tenant

Desktop (please complete the following information):

• OS: Windows 11
• Browser: Edge
• Version: V.Latest

It would be nice to have a Refresh / Reload tenants button to grab the latest results from the partner portal.
Don't know if there is a default interval at the moment.

Describe the bug
When adding a tenant to the Excluded Tenants list, the website doesn't automatically refresh, making it impossible to add another tenant.

To Reproduce
Steps to reproduce the behavior:

1. Go to Settings - Tenants.
2. Click Add Excluded Tenant and select a tenant.
3. After seeing the "Success" message, click Close.
4. The tenant isn't listed and if you click "Add Excluded Tenant" again you see the same "Success" message.

Expected behavior
After clicking Close after adding the tenant, the page should auto-reload to reflect the change and allow you to add a new tenant to the list.

Describe the bug
Form can be submitted with no data being filled in.

To Reproduce
click add new user to open the form
click add user button at the bottom of the page

Expected behavior
Required fields/check before the form is submitted.

Screenshots

Desktop (please complete the following information):

• OS: Windows 10
• Browser: Edge

Describe the bug
When you click Permissions Check, the results dont show if they are "delegated" or "application" permissions

Screenshots

Desktop (please complete the following information):

• OS: windows
• Browser edge

Describe the solution you'd like
I'd like to be able to have engineers run a Wizard to offboard a user, with checkboxes to convert a user to a shared mailbox, remove the licenses, block sign-in, and set an OoO.

Describe alternatives you've considered
manually doing it, blergh

Describe the bug
Report\Mailbox List does not display correctly missing items on right. if you zoom the page to 80% it shows

To Reproduce
Steps to reproduce the behavior:

1. Go to reports
2. Click on Mailbox Statistics
3. Pick company

Screenshots

Desktop (please complete the following information):

• OS: windows 10
• Browser edge
• Version 94.0.992.50

Describe the bug
Text formatting, needs a new line after permissions:
Screenshots

Describe the bug
First off, amazing solution - thank you!
I have a tenant with around 2,200 users, for this tenant only, the user list never loads the actual list of users.
It is working for my other tenants with much less users. The app permissions test is coming back ok.
I've tried leaving it for a while and have tried different browsers - chrome, firefox, edge
The groups seem to load ok and there's 1,350 of those.

To Reproduce
Steps to reproduce the behavior:

1. Go to Administration -> Users
2. Click on the tenant in question from the drop down
3. Users never load - always 'Loading'

Expected behavior
The list of users will appear.

Screenshots

Desktop (please complete the following information):

• OS: Win10
• Browser FireFox 93.0 / Chrome 94.0.4606.81
• Version [e.g. 22]