Directory whitelisting doesn't work about node-ignore HOT 3 CLOSED

The patterns of your example should be ['*', '!/foo', '/foo/*', '!/foo/bar'].

https://git-scm.com/docs/gitignore:

It is not possible to re-include a file if a parent directory of that file is excluded.

I thought it is better to read the gitignore spec carefully rather than the blog article written by someone.

And I could NOT agree with the gitignore whitelisting patterns as a good way.

from node-ignore.

It is not possible to re-include a file if a parent directory of that file is excluded.

The !*/ includes the parent directory /foo/. Since /foo/ is now included, the following rule of !/foo/bar would work since the parent directory /foo/ has been included.

I thought it is better to read the gitignore spec carefully rather than the blog article written by someone.

Here's the example running on my computer showing that the behavior above is indeed how git works.
Let me know if you need more documentation.

[anthony@ambp] ~/dev/test-ignore  2018-05-22 12:50:53 > tree -R
.
├── a
├── b
│   └── c
└── foo
    ├── bar
    └── e

2 directories, 4 files
[anthony@ambp] ~/dev/test-ignore  2018-05-22 12:51:22 > cat .gitignore
*
!*/
!foo/bar
[anthony@ambp] ~/dev/test-ignore  2018-05-22 12:51:26 > find * -not -path './.git*' | git check-ignore -v --stdin
.gitignore:1:*	a
.gitignore:2:!*/	b
.gitignore:1:*	b/c
.gitignore:2:!*/	foo
.gitignore:3:!foo/bar	foo/bar
.gitignore:1:*	foo/e

from node-ignore.

@kaelzhang can we reopen this issue or would you like me to create a new one with the repro case from #38 (comment) ?

from node-ignore.