Ignore rules containing .. as a path element about node-ignore HOT 7 CLOSED

I ended up just making gitignore-fs

from node-ignore.

This kind issue is hard to be handled by runtime but by conventions

test/../foo is actually a path that is not normalized and normalizing a path is the duty of the path module of nodejs

Maybe we could detect if ignore is running in node env and normalize the path before the real logic of ignores()

from node-ignore.

Yes I understand that, on the other hand is there any reason ignore shouldn't filter out rules matching /(^|\/)\.\.($|\/)/? They're not really valid rules

from node-ignore.

also maybe this repo shouldn't be named node-ignore anymore? I was thinking the wrapper package I'm planning to make for a node env should be called node-ignore 🙃

from node-ignore.

also maybe this repo shouldn't be named node-ignore anymore? I was thinking the wrapper package I'm planning to make for a node env should be called node-ignore 🙃

It is a naming convention for myself. I write code in many languages so I use the node- prefix to indicate it is a node project.

from node-ignore.

Okay. Do you have any opinion on what I name my npm package for loading rules from files via fs and implementing the rest of the gitignore spec? Possibilities:

• node-ignore
• fs-ignore
• ignore-fs

from node-ignore.

closing this, be free to reopen it if necessary

from node-ignore.