Incorrect filter management about node-ignore HOT 7 CLOSED

Thought it could be closed.

from node-ignore.

.gitignore exactly works in this way.

The spec says:

It is not possible to re-include a file if a parent directory of that file is excluded.

You could sightly change your ignore rules as:

.git/*
!.git/config
.ftpconfig

I thought it is solved.

from node-ignore.

No solved my problem!

I use Windows.

My rules:

.git/*
!.git/config
.ftpconfig

Accepted:

D:/ => true
D:/DEV/ => true
D:/DEV/_incubator/ => true
D:/DEV/_incubator/cubicbox/ => true
D:/DEV/_incubator/cubicbox/.ftpconfig => false [It's OK]
D:/DEV/_incubator/cubicbox/.git/ => true
D:/DEV/_incubator/cubicbox/.git/config => true
D:/DEV/_incubator/cubicbox/.git/description => true [This and other files is bad!]

from node-ignore.

@icetee I've added a test spec of your case, and it is ok with windows. See here for test result and here for the test case.

Could you please provide any code slices or examples?

And BTW, you should not do something like this on windows:

// WRONG!
ignore().add(rules).ignores('D:/DEV/_incubator/cubicbox/.git/description')

Because .gitignore does not works with absolute paths but only relative ones. We should use path.relative() method first, then do:

const rootOfYourProject = 'D:/DEV/_incubator/cubicbox/'
const absoluteFilePath = 'D:/DEV/_incubator/cubicbox/.git/description'

ignore().add(rules).ignores(
  // Right way
  path.relative(rootOfYourProject, absoluteFilePath)
)

from node-ignore.

@kaelzhang Can you help me?

I write spec in other test file custom.spec.js and run ./node_modules/.bin/mocha --grep deep:

var ignore = require('../');
var expect = require('chai').expect;

var ig = null;

describe('deep', function() {
  before(function() {
    ig = ignore().add([
      'abc',
      '!abc/b',
    ]);
  });

  it('#0', function() {
    expect(ig.ignores('abc')).to.equal(true); // CORRECT
  });

  it('#1', function() {
    expect(ig.ignores('abcdefg')).to.equal(false); // CORRECT
  });

  it('#2', function() {
    expect(ig.ignores('abc/b')).to.equal(false); // WRONG
  });
});

It's as if he did not notice that he was negative. Do I do something wrong?

from node-ignore.

The gitignore spec might help you.

An optional prefix "!" which negates the pattern; any matching file excluded by a previous pattern will become included again.
It is not possible to re-include a file if a parent directory of that file is excluded.

Let me explain that.

The parent directory of abc/b is abc, and abc is ignored, so abc/b could not re-include again by the rule !abc/b.

The correct way:

ignore().add([
  // The directory `abc` is not ignored, while only the things INSIDE `abc` are ignored.
  'abc/*',
  '!abc/b'
]).ignores('abc/b')  
// -> false

If abc is already ignored, we could

ignore().add([
  // If already ignores
  'abc',
  // It could be re-included itself
  '!abc',
  'abc/*',
  '!abc/b'
]).ignores('abc/b')  // -> false

from node-ignore.

I understand! Thanks for the help!

from node-ignore.