Git Product home page Git Product logo

Comments (5)

justinstenning avatar justinstenning commented on September 23, 2024

I'm not sure that this is necessary. EasyHook should already be preventing recursion into the hooked function for us. Can you elaborate a little on the scenario where you see an issue here?

from direct3dhook.

remcoros avatar remcoros commented on September 23, 2024

I didn't have any issues and don't really know about the internals of Easyhook, but I thought it would be safe.

btw, you might want to check: https://github.com/remcoros/Direct3DCapture

especially: https://github.com/remcoros/Direct3DCapture/blob/master/Hook/DXHookD3D9.cs

I spent some time looking at how OBS (Open Broadcaster) did their direct3d hooking and revised the directx 9 version a lot. Solving issues with alt-tab / fullscreen / lost devices etc.

I removed all other directx versions from that repo though, as I didn't needed it in my case,

I hope you don't mind the GPL license, I couldn't find any licensing in your code and I was forced to add GPL because of the OBS code.

from direct3dhook.

justinstenning avatar justinstenning commented on September 23, 2024

Ah ok, I might just close this issue then.

The GPL is fine. Do you mind me bringing some of the changes if appropriate back into here (minus the OBS code)? The license used here is MIT, so you are free to do what you like providing appropriate credit.

from direct3dhook.

remcoros avatar remcoros commented on September 23, 2024

I can bring the revised version of the direct3d9 hook, minus the drawing stuff though. If you don't mind?

Also, I don't really have the time to look into the other direct3d versions. But I suppose the revised version of Direct3d9 can serve as a good example.

from direct3dhook.

justinstenning avatar justinstenning commented on September 23, 2024

Ok that would be great, yeah I can deal with the other versions once you bring it in and I review the changes.

I started working on an overlay engine in this project and still plan to sort that out at some point.

from direct3dhook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.