Memory leak in hooked application about direct3dhook HOT 7 CLOSED

Can you please try with Png image format, and PixelData to see if they also exhibit the behaviour.

from direct3dhook.

Disabled all my code inside using and re-checked.

Both Bitmap and Png formats cause memory leak. Probably, Png does it slower, but I'm not sure.

PixelData does not. However, I need to improve my code to be able to use it.

from direct3dhook.

Ok thanks, not sure what changed to introduce that, fairly certain it was good for a while. I’ll try to take a look over the next month.

from direct3dhook.

I'm not very experienced in low level graphics programming, but I made some investigations with dotTrace. There is a leak of unmanaged memory allocated in SharpDX.WIC.Bitmap's constructor inside DXHookD3D11.ToStream.

I'll try to fix it by myself and will make a PR in case of success. Otherwise, I hope that my investigation will help you to find the problem and to fix it.

from direct3dhook.

Further investigations show that the converter.Initialize(bitmap, ...) is the cause of memory leak. When this call happens, a bitmap can not Dispose in a right way.

Disabled converter temporarily in my project, but I'm sure you can find a more elegant solution.

from direct3dhook.

@SladeThe yeah, I have missed wrapping the converter in a using clause in a recent update e.g. var converter = new SharpDX.WIC.FormatConverter(wicFactory); becomes:

using (var converter = new SharpDX.WIC.FormatConverter(wicFactory)) 
{
    ...
}

from direct3dhook.

Yes. That helped, thanks. But doesn't really matter.

The following code works fine for me. Both with and without converter.

using (MemoryStream dataStream = new MemoryStream(screenshot.Data)) {
    using (Bitmap bitmap = (Bitmap) Image.FromStream(dataStream)) {

from direct3dhook.