Summary

Currently isObject returns the type boolean, but i think it would improve the package if it returned val is { [key: string]: unknown }.

Current behaviour

const test: { example: "hello" } | string[] = ...;

if(isObject(test)) {
  test.example = "world" // Error since test could be a string array
}

Improved behaviour

const test: { example: "hello" } | string[] = ...;

if(isObject(test)) {
  test.example = "world" // No error 
}

What was the reason for 3.0.1 major bump to 4.0.0?

I don't see release changelog or a CHANGELOG.md in the repo that explains any BREAKING CHANGES which would help explain the version changes.

Perhaps https://www.npmjs.com/package/commitizen would be a benefit to this lib :-)

const isObject = require("isobject");

console.log(isObject(new Date())) // true, maybe return false?

Ref: https://developer.mozilla.org/zh-TW/docs/Web/JavaScript/Reference/Operators/typeof

Issue: There is no package-lock.json or npm-shrinkwrap.json file uploaded to the GitHub repository https://github.com/jonschlinkert/isobject

Questions: We are conducting a research study on the lock files used in JS projects. We were curious:

1. Will you upload any lock files to GitHub as recommended above? (Yes/No), and why?:
2. Do you have any additional comments? (If so, please write it down):

For any publication or research report based on this study, we will share all responses from developers in an anonymous way. Both your projects and personal information will be kept confidential.

Rationale: NPM introduced package-lock.json and npm-shrimpwrap.json files to capture the exact dependency tree installed at any point in time. When package.json defines the required dependencies and their respective versions using semantic versioning (e.g., “express”: “^4.16.4”), npm always downloads the latest version of packages to satisfy the specified version ranges (e.g., 4.17.1)[1]. If the latest version of any package keeps changing and has backward incompatibility issues with previous versions, the project may have an inconsistent running environment and get intermittent failures. In such scenarios, it can be very difficult for developers to debug programs and settle down the software environment [2].

List of Risks:

• Nondeterministic package downloads and installations across different environments [3]
• Produce irreproducible builds [4]
• Inconsistent results of program execution [5]

Suggested Solution: Please fixate the dependencies by either specifying the exact library version in the package.json file or by uploading the package-lock.json or npm-shrinkwrap.json file to GitHub.

References:
https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json
https://blog.logrocket.com/why-you-should-use-package-lock-json/
2019. 10 npm Security Best Practices. https://snyk.io/blog/ten-npm-security-best-practices/.
Pronnoy Goswami, Saksham Gupta, Zhiyuan Li, Na Meng, and Daphne Yao. 2020. Investigating The Reproducibility of NPM Packages. In2020 IEEE International
2021. Npm Security Best Practices. https://bytesafe.dev/posts/npm-security-best-practices/#no9-deterministic-results.

As-is Array.isArray makes this module incompatible with IE8 and lower - would be great to use the isarray module to avoid that.

that hurts, lol. that 1.0.1 was breaking change really.
Whole week cant realize why builds of is-kindof fails, even released before latest tag that works.

https://travis-ci.org/tunnckoCore/is-kindof/builds see that last v2.1.0 rebuild fails

It's because is-kindof sits on is-typeof-error which use isobject. I will update them, but yea.

I noticed you are using Array.isArray(val) === false...

return val != null && typeof val === 'object' && !Array.isArray(val);

or even...

return !!val && typeof val === 'object' && !Array.isArray(val);

I noticed you used that way here...
https://github.com/jonschlinkert/use/blob/843c0e1b6934cef9570e7a9962501bf84212c3b5/index.js#L146
It's shorter and imho more descriptive. Just a suggestion though.
Happy to do a pr is needed.
Thanks.

So what is the point of this? Test if some value is an "object"?

Are Function objects supposed to pass? Clearly they fail, but the documentation makes no mention of them. Regular expressions welcome, but not arrays? Documenting the intentions may help, but can't imagine this is a useful dependency.

The following code:

const isObject = obj => Object.prototype.toString.call(obj) === '[object Object]'

Advantage: Uses less number of operations to detect if given value is an object or not ✌️

isObject(/abc/) return true.
is it expected?

isarray is declared deprecated. Proposing to use standard Array.isArray.