jonjozwiak / bluecat-ipam-rest Goto Github PK

View Code? Open in Web Editor NEW

18.0 18.0 10.0 21 KB

Ansible role for Bluecat IPAM using the REST API

License: GNU General Public License v3.0

bluecat-ipam-rest's People

Contributors

Stargazers

Watchers

Forkers

ismc flysen morenod arickels perryk yalesom dfoley84-zz dwa6 naukrii prince0205

bluecat-ipam-rest's Issues

Use uri instead of curl

I was looking into the response you get from "getHostRecordsByHint". The thing is that the json response is an array: (note the brackets)

"json": [
        {
            "id": 720154, 
            "name": "ID-TY-DEV20", 
            "properties": "absoluteName=ID-TY-DEV20.com|parentId=112918|parentType=Zone|reverseRecord=true|addresses=192.168.4.5|addressIds=720153|", 
            "type": "HostRecord"
        }
    ],

In your case you are only interested in the first element [0] (start=0&count=1)

So the trick is to use a filter and then just take the first element out (no need to iterate over array for this):
dnsId: "{{ (host_record_output.content|from_json)[0].id }}"

This will give a cleaner code more Ansible native eg:

- name: Check if host record already exists
  url: 
      url: "{{ bluecat_url }}/Services/REST/v1/getHostRecordsByHint?containerId={{ viewId }}&start=0&count=1&options="hint=^{{ target_hostname }}$|retrieveFields=false"
 --> lines of code <--
  register: host_record_output

- name: Set DNS Entry Fact
  set_fact:
    dnsId: "{{ (host_record_output.content|from_json)[0].id }}"
   --> lines of code <--

Hope this helps :-)

Just a thought.

@jonjozwiak thanks for pushing up this role:-) I have one minor thought regarding snippet below. Is there a reason that you don't split the string instead of regexp?

Something like this:
{{ network_record_output.json.properties.split("|")[7] | replace("gateway=", "") }}

# Hacky way to get address from properties="CIDR=192.168.240.0/24|locationInherited=true|allowDuplicateHost=disable|inheritAllowDuplicateHost=true|pingBeforeAssign=disable|inheritPingBeforeAssign=true|gateway=192.168.240.1|inheritDefaultDomains=true|inheritDefaultView=true|inheritDNSRestrictions=true|"
- name: Set Gateway Fact
  set_fact:
ipGateway: "{{ network_record_output.json.properties | regex_replace('^.*gateway=', '') | regex_replace('\\|.*', '') }}"

Regards
Fredrik

jonjozwiak / bluecat-ipam-rest Goto Github PK

bluecat-ipam-rest's People

Contributors

Stargazers

Watchers

Forkers

bluecat-ipam-rest's Issues

Use uri instead of curl

Just a thought.

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent