john-lluch / swrevealviewcontroller Goto Github PK

instead of having the pan gesture only on the navigation bar to open/close the menu, it would be nice if it was on the entire view

(see the official facebook app for example)

using built-in panGestureRecognizer fires relevant delegate methods (e.g. revealController:willHideRearViewController:), when in fact these methods should only fire when the view is actually hidden or being hidden.

you can reproduce this by adding NSLog() calls from the delegate methods and then beginning a pan - you will notice that these NSLog() calls fire as the pan occurs, NOT after the pan completes.

this is only really a problem when you do a partial pan but do not pan enough to actually hide the front view controller. my dismissal logic is firing when the front view controller is not actually dismissed.

suggestion: tie delegate methods to state changes instead of x-y coordinates check

I would like to be able to show the rear view on the right side as well, but it doesn't seem possible using the API. I might patch it, but I find the code a little hard to grok.

Steps to reproduce:

a) Run RevealControllerProject
b) Touch on the MapView with the second finger while making slow pan gesture with the first finger

Results in black screen appearing.

I only just changed code in color view controller.m in the storyboard sample from

[self.navigationController.navigationBar addGestureRecognizer: self.revealViewController.panGestureRecognizer];

to

[self.view addGestureRecognizer: self.revealViewController.panGestureRecognizer];

then run it, when rear view revealed and blue cell clicked, it crashed, red cell as well.

debug said:

RevealControllerStoryboardExample[2244:c07] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSArrayM insertObject:atIndex:]: object cannot be nil'

What happened? I didn't touch any other in this sample but change a little as above. My intention is to be able to pan any place in the view, not only panning on navigation bar.

Could you help me fix the issue?

Thanks!

Since the class itself works fine under iOS 5, why not update the podspec to reflect that?

If in one pan move from left to right so that you reveal both controllers, the revealed controller will not be updated appropriately. Here is an example of the right view controller showing up on the left side after multiple reveals with 1 pan gesture:

Hi,
In my project I have a UINavigationController inside a tabBarController. On it's child controllers, I set childController.hidesBottomBarWhenPushed = YES; to hide the tab bar when pushing child controllers on the navigation stack. This works fine when the navigationController is the top controller in the tabBarController.
However, this fails to work if the navigationController is set as the frontViewController of the SWRevealViewController and the revealViewController is set as the top controller in the tabBarController. Now, when pushing the child controllers in the navigationController, the tab bar continues to be displayed.

George

I did a quick check targeting the 5.1 simulator and it seems to work. Can you please explain the iOS 6.0 requirement?

Hi,
Seems like the Storyboard example does push a new view for every time the view is changed from the menu. This reloads the view and don´t preserve the state it was is.
Anyone found a fix?

Hi, instruments is showing a leak in the _enqueueBlock method when setting the frontViewPosition. The common path in the leaks I've seen is setFrontViewPosition > _dispatchSetFrontViewPosition > _enqueueBlock

I have a controller which has a uitableview.
in viewDidLoad:

LeftSideController *sc = [[LeftSideController alloc] initWithNibName:@"LeftSideController" bundle:nil];
    SWRevealViewController *revealController = [[SWRevealViewController alloc] initWithRearViewController:sc frontViewController:self];
    revealController.delegate = (id)self;
[self addChildViewController:revealController];
    [self.view addSubview:revealController.view];
    [self.navigationController.navigationBar addGestureRecognizer:revealController.panGestureRecognizer];

    UIBarButtonItem *revealButtonItem = [[UIBarButtonItem alloc] initWithImage:[UIImage imageNamed:@"back_m.png"]
                                                                         style:UIBarButtonItemStyleBordered target:revealController action:@selector(revealToggle:)];    
    self.navigationItem.leftBarButtonItem = revealButtonItem;

i tried several times,still crash...

The centerViewController is active even when the left or right viewcontrollers are showing.

E.g you can push the "push" button on the center view while the rear view is visible.

I've implemented this in my app since I am using a UINavigationController as my frontVewController, and I needed some of the child viewControllers to be only portrait/only landscape...

I forward the settings for the below methods from the visibleViewController to the same methods in SWRevealViewController.m:
-(BOOL)shouldAutorotate
-(NSUInteger)supportedInterfaceOrientations

• (UIInterfaceOrientation)preferredInterfaceOrientationForPresentation

Shall I submit a pull request with these changes? I think they would be useful as many apps would find this functionality useful I think.

I have added a Simple UIViewController as my window.rootViewController
and added the SWRevealViewController as a subview of my UIViewController that is the rootViewController.

i have taken your first example and changed the applicationDidLaunch code with this. http://pastebin.com/8GCHyGi9

If the app starts in landscape mode you will immediately see the problem.

On line 436 of the .m file the perform segue fires if the _rightViewController == nil. This should read like this:

// load any defined right controllers from the storyboard
if ( self.storyboard && _rightViewController != nil )
{
    [self performSegueWithIdentifier:SWSegueRightIdentifier sender:nil];
}

I was getting a crash on startup because I don't have a right view controller defined. This fix from == nil to != nil fixed my code. I'm loving this library. Thanks for the hard work.
jared

It seems I can only set the pan gesture recognizer on one view. I'd like to for it be on both self.view AND the nav bar. Is this at all possible?

Hi, I was wondering if it would be possible to add an option in SWRevealViewContoller so that the rear (left side) view controller is animated in at the same time that the front view controller is animated to the side. The best example of an app that does this is Vesper. The rear view controller starts off slightly to the left of the screen and as the front view controller animates to the right, the rear view controller is simultaneously animated to the right (by a much lesser amount) so that when the animation finishes it's in the correct position.

Michael.

The method 'revealViewController' in the category on UIViewController should, in my opinion, always return the appropriate SWRevealViewController when called by either its front or rear view controllers or any of their children. However, if the rear view controller calls [self revealViewController] while it is concealed, the method will return nil. I imagine if the front view controller were completely concealed, the same would hold true, but I haven't tested that part yet.

Thoughts?

Hello everyone here is my code

        ViewController *viewController = [[tViewController alloc] init];
        UINavigationController *navigationController = [[UINavigationController alloc] initWithRootViewController:viewController];
        [revealController setFrontViewController:navigationController animated:YES];

Its rather taking time to show it .. like 2 - 3 seconds. Any help?

if UIPanGestureRecognizer is attached to the entire view, Is there a way to swipe from rearViewController for revealing the frontViewController ? like in the Facebook app for example
thank you for sharing this great lib !

I'm trying to emulate the behavior in the Facebook app where the "rear" view controller is a UITableViewController with an integrated UISearchBar/UISearchDisplayController. When the UISearchBar becomes first-responder the front-view controller slides away fully to reveal the UISearchDisplayController in full-screen.

Basically I have it working with the following:

rearViewController is a UITableViewController with a UISearchBar+UISearchDisplayController in place. The delegate methods, copied below, handle updating the reveal controller to remove/show the frontViewController.

...

// force the rear view controller to be the width that is revealed, not wider. if we dont do this then a portion of the UISearchBar will be hidden when the rear is only partially revealed.

revealViewController.rearViewRevealOverdraw = 0;

...

- (void)searchDisplayControllerWillBeginSearch:(UISearchDisplayController *)controller
{
    self.revealViewController.rearViewRevealWidth = 320;
    [self.revealViewController setFrontViewPosition: FrontViewPositionRightMost animated: YES];
}

- (void)searchDisplayControllerWillEndSearch:(UISearchDisplayController *)controller
{
    self.revealViewController.rearViewRevealWidth = 260;
    [self.revealViewController setFrontViewPosition: FrontViewPositionRight animated: YES];
}

The main issue I have is on the end-search (user-cancel) the animation isn't quite as nice as the Facebook app. When the frontViewController animates back in you can see a black hole to the right of the search bar. It just doesn't look great.

Any ideas for implementing this behavior?

Currently I have this implemented in my viewDidLoad method of the frontviewcontroller, basically like the first example project.

By the way, this is a phenomenal class you created :).

Anyways, I am have implemented the frontviewcontroller to recognize gestures when the user swipes the view rather than the navigationbar.

Issue is, I want to REMOVE the swipe feature in one of the subviews of the frontviewcontroller.

I have the dimensions of the specific view and I notice there are several UIGestureRecognizer delegate methods to look into but when I set the delegate to self in the frontviewcontroller, the user is unable to swipe throughout the entire frontviewcontroller.

So I'm sorta lost at this point but with time - not sure how much :/, I will possibly get this working.

SWRevealViewController *revealController = [self revealViewController];

[self.navigationController.navigationBar addGestureRecognizer:revealController.panGestureRecognizer];
[self.view addGestureRecognizer:revealController.panGestureRecognizer];

UIBarButtonItem *revealButtonItem = [[UIBarButtonItem alloc] initWithImage:[UIImage imageNamed:@"reveal-icon.png"]
                                                                     style:UIBarButtonItemStyleBordered target:revealController action:@selector(revealToggle:)];

self.navigationItem.leftBarButtonItem = revealButtonItem;

UIBarButtonItem *rightRevealButtonItem = [[UIBarButtonItem alloc] initWithImage:[UIImage imageNamed:@"19-gear.png"] style:UIBarButtonItemStyleBordered target:revealController action:@selector(rightRevealToggle:)];

self.navigationItem.rightBarButtonItem = rightRevealButtonItem;

But if you have any suggestions or comments, please... send them here :)

Have a great one John.

• Johnny

A major issue with custom container view controllers like SWRevealViewController is that they're a pain to use in a storyboard. This pain is primarily due to the fact that Apple hasn't enabled a mechanism to expose "relationship" segues from the custom controller, and thus there is no way to graphically hook up the controller on the storyboard.

With SWRevealViewController the issue is somewhat compounded by the fact that the component requires the rear-view-controller at init time.

I made a few minor changes/additions to my local build to enable storyboard support and I propose these changes here. I'm happy to do a pull and resubmit to the project if folks like the mechanism.

1. Support initWithCoder: Basically set all the same internal ivars as initWithFrame, except for the rear and front view controllers.
2. Define a custom segue class whos purpose is to hook up both front and rear view controllers. In the storyboard the developer defines custom segues from the SWRevealViewController to their rear/front view controllers and sets both the segue class and segue identifier of these. The implementation of the segue perform method is straightforward:

• (void) perform
  {
  if ( [self.identifier isEqualToString: @"sw_rearviewcontroller"] )
  {
  SWRevealViewController* src = (SWRevealViewController*) self.sourceViewController;
  [src internalSetRearViewController: self.destinationViewController];
  }

  if ( [self.identifier isEqualToString: @"sw_frontviewcontroller"] )
  {
  SWRevealViewController* src = (SWRevealViewController*) self.sourceViewController;
  [src internalSetFrontViewController: self.destinationViewController];
  }
  }

I also added these support methods to SWRevealViewController:

- (void) internalSetFrontViewController:(UIViewController *)fvc
{
    _frontViewController = fvc;
}

- (void) internalSetRearViewController:(UIViewController *)rvc
{
    _rearViewController = rvc;
}

1. in loadView, detect if we are associated with a storyboard and if so perform the two custom segues that hook up the rear/front:

   • (void)loadView
     {
     // Do not call super, to prevent the apis from unfructuously looking for inexistent xibs!

     // This is what Apple tells us to set as the initial frame, which is of course totally irrelevant
     // with the modern view controller containment patterns, let's leave it for the sake of it!
     CGRect frame = [[UIScreen mainScreen] applicationFrame];

     // create a custom content view for the controller and assign it to the controller's view
     _contentView = [[SWRevealView alloc] initWithFrame:frame controller:self];
     self.view = _contentView;

     // $TS: hook up any storyboard-defined front/rear controllers
     if ( self.storyboard && nil == _rearViewController )
     {
     [self performSegueWithIdentifier: @"sw_rearviewcontroller" sender: nil];
     [self performSegueWithIdentifier: @"sw_frontviewcontroller" sender: nil];
     }

None of this would be necessary if Apple would give us an ordained solution. But for now it works pretty well. The code I added is lacking a few safety checks but they'd be easy to add.

Similarly I've also created a custom segue for transitioning the front-view-controller. I'm happy to submit that as well.

As I said, I'm looking for feedback. If it's positive I'll make a pull request and add my changes formally.

i need a version which not use ARC ,because i must use the gcc compiler.please.

Hello,

I open an issue about a closed one.

On newly created View Controllers with XIBs that uses Auto Layout feature, the Pan Gesture recognizer stop working.

Can you see comment on closed one : https://github.com/Joan-Lluch/SWRevealViewController/issues/14

Thanks

Maybe I'm not aware of another way to make this work, but rotation doesn't work in iOS 5 and below because this method is missing, and the default action is to only allow UIInterfaceOrientationPortrait.

- (BOOL)shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)interfaceOrientation
{
    return YES;
}

I'm swizzling the method during runtime for now.

#import <objc/runtime.h>

BOOL shouldRotateForSwizzle(id self, SEL _cmd, UIInterfaceOrientation interfaceOrientation){
    //- (BOOL) shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)interfaceOrientation
    return YES;
}

// put this call somewhere;  I put it in AppDelegate application:didFinishLaunching...
class_addMethod([SWRevealViewController class], @selector(shouldAutorotateToInterfaceOrientation:), (IMP)shouldRotateForSwizzle, "c@:i");

Hello
I use the SWRevealViewController for both sides of the screen (left-right).
When the Rear Menu is shown i think taping in the front view controller should be disabled, because you cant tap a button or something and navigate your frontview controller to a screen which hasn't the menu icon to close the menu. So if you dont want to enable pan gesture in your app you cant close the menu.

Possible solutions: interaction with frontviewcontroller to be disabled, or swipe gesture only to close the menu and not to open it.

Tried both solutions without success.

Any help?

Thanks in advance!

When using SWRevealViewController's panGestureRecognizer on the FrontViewController's view, if you swipe from right to left quickly, the front view stops before its left edge gets to 0. In order for this to occur, you must not lift your finger off the screen. You will see the view stop short of 0, yet you can still move your finger to the left while the view stays stationary.

Without speaking of the details of iOS 7, SWRevealViewController needs to be updated so that it will not fail in iOS7. There are problems when it is run in the iOS 7 preview.

some kind of highlight on the table cell which marks which view controller they are on in the menu

Steps to reproduce:

a) Run sample included with the project
b) Make pan gesture to reveal RearViewController without releasing finger.
c) Tap with other finger on Front View and Map View simultaneously multiple times.
d) Release gesture finger.

Animations are performed multiple times.

These steps look kind of dumb but in my code I do smth like this:

[CATransaction begin];
[CATransaction setCompletionBlock:^{
    [delegate.phoneViewController restoreOriginalNavigationStackAnimated:NO];
    [delegate.phoneViewController popToRootViewControllerAnimated:NO];
    [self.revealViewController revealToggleAnimated:YES];
}];
[self.revealViewController setFrontViewPosition:FrontViewPositionRightMostRemoved animated:YES];
[CATransaction commit];

What I am trying to accomplish is when selecting something from the RearViewController the FrontViewController should hide entirely, make off-screen change of its view and reveal itself with animation again. But when I make pan gesture and quickly select smth from the RearViewController, the FrontViewController does not hide in time and I can notice the change of its view on screen.

When setting the FrontViewController position to FrontViewPositionRightMost when clicking the Item on the RearViewController, is it possible that the FrontViewController window resizes itself to fit the available width (rearViewWidth - IPAD_PORTRAIT_WIDTH) ? So that it has the same effect like the iPad UIViewSplitter landscape mode.

Can we have this option? Maybe position type of FrontViewPositionRightMostFixed ?

The view controller loading code doesn't perform the sw_right segue to load the right side view controller. I'll submit a pull request with a simple fix.

Hi! I add panGestureRecognizer to self.navigationController.view, and now i want to use left swipe(←) to enter editing mode in my TableView. Please give me advice, how to implement it.

In the SWRevealviewController.m you support all InterfaceOrientations.

• (NSUInteger)supportedInterfaceOrientations
  {
  return UIInterfaceOrientationMaskAll;
  }

In my case I have views with different orientation behavior.

Now I have used this workaround to different behavior for each frontViewController:

• (NSUInteger)supportedInterfaceOrientations
  {
  if (_frontViewController)
  return _frontViewController.supportedInterfaceOrientations;
  else
  return UIInterfaceOrientationMaskAll;
  }

It's correct?

Thanks

Heya,

I was wondering whether you would be able to tag releases with semantic versioning (semver.org) so that the Cocoapods spec (https://github.com/cocoapods/specs/tree/master/SWRevealViewController) can be more accurately maintained.

Thanks heaps in advance!

Hi,
I've added this control to my application, and I've seen a weird behavior.
Each time setting the front controller, the previous one is not released.
This behavior even happens in the example project.

Please advice

When I modify the storyboard version and remove navigation controller and use a brand new UIViewController, it's working with toggle button but when I activate panGestureRecognizer with

[self.view addGestureRecognizer:revealController.panGestureRecognizer];

in the FrontViewController (let's keep naming..the Color VIew Controller) it stops with error:

*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSArrayM insertObject:atIndex:]: object cannot be nil'

The modified part in Menu View Controller (rear view controller), just commented out the original parts:

- (void) prepareForSegue: (UIStoryboardSegue *) segue sender: (id) sender
{
// configure the destination view controller:
if ( [segue.destinationViewController isKindOfClass: [ColorViewController class]] &&
    [sender isKindOfClass:[UITableViewCell class]] )
{
    NSLog(@"IDE");
    UITableViewCell* c = sender;
   ColorViewController* cvc = segue.destinationViewController;

    [cvc view];
    cvc.label.textColor = c.textLabel.textColor;
    cvc.label.text = c.textLabel.text;
    }

    // configure the segue.
    // in this case we dont swap out the front view controller, which is a      UINavigationController.
    // but we could..
    if ( [segue isKindOfClass: [SWRevealViewControllerSegue class]] )
    {
            NSLog(@"ODA");
    SWRevealViewControllerSegue* rvcs = (SWRevealViewControllerSegue*) segue;

    SWRevealViewController* rvc = self.revealViewParentController;

//        NSAssert( rvc != nil, @"oops! must have a revealViewController" );
//        NSAssert( [rvc.frontViewController isKindOfClass: [UINavigationController class]], @"oops!  for this segue we want a permanent navigation controller in the front!" );

    rvcs.performBlock = ^(SWRevealViewControllerSegue* rvc_segue, UIViewController* svc, UIViewController* dvc) {

//!!!            UINavigationController* nc = (UINavigationController*)rvc.frontViewController;
//!!!            [nc setViewControllers: @[ dvc ] animated: NO ];

        [rvc setFrontViewController:dvc animated:YES];

        [rvc setFrontViewPosition: FrontViewPositionLeft animated: YES];
        };
    }
}

Took me a while to narrow the deadlock in my application to your SWRevealViewController.

This deadlock appears when making vertical swipe gesture on the navigation bar. After deadlock application does not respond to any touches anymore.

This deadlock is reproducible in iOS Simulator also:

1. Run the latest RevealControllerProject2 project in iOS Simulator.
2. Make vertical up swipe gesture which starts on the navigation bar (somethere in the middle).
3. If application continues to respond to other input, try again a few times.
4. Kill the application and start over again.

It seems like a very hardly reproducible bug, but I use UISwipeGestureRecogniser on my UINavigationViewController's entire view, so deadlock happens quite offen.

Let me know if you need more information about this issue.

Thanks

It would be great to be able to setup rear-left and rear-right ViewController, like in Path.app or FB.

In the code, CGFloat rearWidth = _c.rearViewRevealWidth + _c.rearViewRevealOverdraw;

When I add a corner radius for the front view, there will be a black little corner there, because the below is empty. I'm wondering why not just set rearWidth to 320?

I can't manage to make it work, is this possible ?

I have not been able to programmatically select a row when returning to the app from a local notification. It seems that to use the setFrontViewController method, I would need to create a new instance of the view controller I am trying to reveal, instead of using the existing. Once I 'select' the row to reveal the view controller, I want to push another view controller with no animation. I am sure I am missing something, but I just cannot seem to grab the existing controllers to manipulate them programmatically. Not sure if this is an issue, but I sure could use some help.

Is there anyway to get rid of the slide animation when switching view controllers? kind of too much. I think no animation would be better (well maybe, I'd have to see)

Hi there,
Using storyboards I usually use this method to pass an array or value between a table view and segued "detail view". I can't seem to work out how to do this using SWRevealViewController and storyboards. Can anyone steer me in the right direction.

This is how I do it now between regular segues

-- (void)prepareForSegue:(UIStoryboardSegue *)segue sender:(id)sender // Used to prepare for moving to the other screen. Sends values to next screen depending on the type of segue initiated.
{
if ([[segue identifier] isEqualToString:@"ViewKPIDetail"]) // If the segue is to just display the current KPI in more detail.
{
DetailViewController *kpiDetail=[segue destinationViewController];
//kpiDetail.itemToView=sender;
kpiDetail.currentIndex=self.kpiTable.indexPathForSelectedRow.row;
kpiDetail.kpiArray=self.kpiArray;
}
}

Hi,
I'm trying to crate a navigationController in my rearViewController. When I click a row pushViewController is fired but all the SWRevealViewController's structure disappears and the pushed view controller get in full screen. How can I push a controller inside the rearViewController and keep the SWRevealViewController's structure alive?

Hi,

nice work. I have one question: We are using Sensible Table View (http://sensiblecocoa.com) - is it possible to use it with your controller? I tried it but i dont' get it working together. The SCTableViewController lost "the design" and is only a simple Table.

Sorry for my bad english. I hope you can understand my question.

Best regards

On newly created View Controllers with XIBs that uses Auto Layout feature, the Pan Gesture recognizer stop working.

The samples FrontViewController and MapViewController both have unchecked Use Auto Layout in XIB setting. At least on my testing

UPDATE:
Upon further investigation of my issue, it turned out that if I inherit TableView controller named 'PFQueryTableViewController' from Parse SDK, this problem occurs. I still don't know what causes this on the side of Parse SDK.