jm1 / ansible-collection-jm1-libvirt Goto Github PK

In case the user does not override all of the default fields. Would that be better in Ansible or python?

I am trying to run and adapt this for Fedora, and there are some issues with newer libvirt versions:

• os-variant is required. This can easily be fixed by adding a default "detect=on"
• disk is not defined or called in the command. Maybe I am misreading the flow of the program there but shouldn't it have an additional argument disk where the Ansible variable volume is passed?

Also it makes more sense for the volume variable to default to {{ domain }}.{{ volume_format }} instead of {{ inventory_hostname }}.{{ volume_format }}

When creating a domain using jm1.libvirt.domain, the hardware arguments must be a dict of (str, str) values. In some cases, the value side of the dict requires multiple parameters for that argument:

--network network=default,mac=52:54:00:aa:bb:cc,model=virtio

Adding these types of arguments to the yaml playbook using this module raises an error saying the value for this argument is in Key=Value Shorthand and not YAML:

ERROR! no module/action detected in task.

The error appears to be in '/my/playbook.yml': line 113, column 30, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

          - network: "network=os_net,mac=52:54:00:aa:bb:cc,model=virtio"
                             ^ here

There appears to be both 'k=v' shorthand syntax and YAML in this task. Only one syntax may be used.

Python 3.9.7
Ansible Core 2.11.5