Git Product home page Git Product logo

Comments (3)

JM1 avatar JM1 commented on June 20, 2024

We cannot merge user input with default fields because then users would have no way of removing fields they do not want to pass to virt-install. The current style follows Ansible's way of specifying defaults: Either do not specify parameter hardware and be happy with its default or specify hardware with the a value you want it to be.

from ansible-collection-jm1-libvirt.

LecrisUT avatar LecrisUT commented on June 20, 2024

How about defining a default_hardware so that one can call a set_facts with hardware | combine(default_hardware) for the necessary role?

from ansible-collection-jm1-libvirt.

JM1 avatar JM1 commented on June 20, 2024

Customizations like virtual-machines-share-most-hardware-specs-but-differ-in-minor-aspects are better handled through inventory group_vars and host_vars instead of trying to add more and more variables to a role such as jm1.libvirt.server.

hardware in jm1.libvirt.server already allows maximum flexibility and thus does not have to be extended. Adding more variables to that role to tweak hardware a bit for your use case will not add any flexibility for others, hence you are looking at the wrong place. Try to grasp the power of Ansible's variable system, variable precedence rules and inventories!

from ansible-collection-jm1-libvirt.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.