Git Product home page Git Product logo

Comments (11)

jgpc42 avatar jgpc42 commented on May 27, 2024 2

Just a quick update. @BrunoBonacci @liuchong

I've recently pushed jmh-clojure 0.4.0-SNAPSHOT (and lein-jmh 0.3.0-SNAPSHOT). Aside from some new features and fixes, this version downgrades insn to 0.2.1, which uses Clojure's bundled ASM by default. The recent features and bugfixes of later versions don't impact this library. This will alleviate the dependency conflict for the time being until I decide whether to bundle my own ASM (via mranderson) or something else.

Thanks.

from jmh-clojure.

BrunoBonacci avatar BrunoBonacci commented on May 27, 2024 1

I found the source of the conflict (cider/refactor-nrepl transitive dependency via [org.clojure/tools.analyzer.jvm "0.7.3"]) and fixed.
I tested the version 0.3.1-SNAPSHOT and it works!! thx

from jmh-clojure.

jgpc42 avatar jgpc42 commented on May 27, 2024

Thanks for catching this!

I forgot to update my project file after I recently updated my local JDK version from 8 to 14. Obviously, this wasn't caught by the CI runner due to it compiling the Java from source for each test.

I will have 0.3.1 out in a little bit.

from jmh-clojure.

jgpc42 avatar jgpc42 commented on May 27, 2024

Please try 0.3.1-SNAPSHOT when you have some time. This is working on my end, I just want to make sure before I release. Thanks again.

from jmh-clojure.

BrunoBonacci avatar BrunoBonacci commented on May 27, 2024

i'm getting this error now

Syntax error (ClassNotFoundException) compiling at (insn/util.clj:1:1).
org.objectweb.asm.ConstantDynamic

Additionally, this was causing some problem as it was forcing a particular version of jmh-clojure

from jmh-clojure.

jgpc42 avatar jgpc42 commented on May 27, 2024

I can't understand why this is happening. insn 0.4.0 uses asm 7.0, which provides the class in question... It seems like there is a version conflict. Do any of your other dependencies depend on asm? I recently had a similar problem trying to use codox with jmh-clojure due to it depending on asm-all 5.0.3.

Can you provide a repro, or at least show me your project.clj?

from jmh-clojure.

BrunoBonacci avatar BrunoBonacci commented on May 27, 2024

you are right, there is asm-5.2 in the classpath but is not part of any of the dependencies.
Need to figure out where does it get injected. I think you can release, meanwhile I will fix my dependencies.

from jmh-clojure.

jgpc42 avatar jgpc42 commented on May 27, 2024

I released 0.3.1.

I also released lein-jmh 0.2.8 that uses this new version as well. I added its own CI runner that will catch any bugs like this in the future.

Thanks again for all your help. Feel free to reopen this if you run into any more problems. 👍

from jmh-clojure.

BrunoBonacci avatar BrunoBonacci commented on May 27, 2024

Great thanks,
one way to avoid classpath collision is to use MrAnderson.
It shadows the dependencies in your project and reduces the classpath collision problem.

from jmh-clojure.

jgpc42 avatar jgpc42 commented on May 27, 2024

I hadn't heard of mranderson before. I definitely will consider its use in a future version. Thanks for the info!

from jmh-clojure.

liuchong avatar liuchong commented on May 27, 2024

Mark same problem as #7 (comment)

from jmh-clojure.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.