Valid clj keyword benchmark names are munged to invalid Java method names about jmh-clojure HOT 6 CLOSED

On Sun, Jan 8, 2023 at 12:48 AM Justin Conklin ***@***.***> wrote: (Sorry for the delay btw, I'm on vacation.) No problem, and thanks for the additional input. I was curious as to what Clojure does when it comes to generating class and method names. For example, in a test project: $ mkdir -p classes demo $ echo '{:paths ["." "classes"]}' > deps.edn $ clj (in-ns 'user) (System/getProperty "java.version");; => "14.0.2" *clojure-version*;; => {:major 1, :minor 10, :incremental 3, :qualifier nil} (munge '&);; => _AMPERSAND_ Somewhat surprisingly, Clojure can generate classes with names that are invalid according to javac. For example: (spit "./demo/&.clj" (pr-str '(do (ns demo.& (:gen-class)) (defn -main [& _] (prn :wow))))) (compile 'demo.&);; => demo.& (import [demo &]) (&.);; => #object[demo.& 0x178270b2 ***@***.***"] If we look with javap, we see the same name: $ javap 'classes/demo/&.class' | head -n1 public class demo.& { But if we try to create a class with the same name with javac it (expectedly) fails: $ echo 'public class & {}' > 'demo/&.java' $ javac 'demo/&.java' demo/&.java:1: error: <identifier> expected public class & {} ^ 1 error But perhaps even more surprising, while javac can't create them, java can still run the ones generated by Clojure: $ java -cp "$(clj -Spath)" 'demo.&' :wow However, while it can generate ostensibly invalid class names, it won't allow the same for methods. (spit "./demo/test2.clj" (pr-str '(do (ns demo.test2 (:gen-class :methods [[& [] String]])) (defn -& [] "???") (defn -main [& _] (prn (-&)))))) (compile 'demo.test2);; Syntax error macroexpanding clojure.core/gen-class at (demo/test2.clj:1:5).;; Not a valid method name: & But, of course, it works fine from Clojure: (require 'demo.test2 :reload) (demo.test2/-main);; "???" ------------------------------ Anyway, I hope you don't mind the small brain dump. So, I think raising an error if the munged name is still an invalid Java method name is the right course of action. This will be less restrictive than Clojure's gen-class <https://github.com/clojure/clojure/blob/38705b4/src/clj/clojure/genclass.clj#L114>, which doesn't allow even munge-able characters like -, but it still will disallow dot as a valid character for benchmark names. If you don't have any more input or objections, I'll likely get to enforcing this in the code some time next week. — Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHHB5KEFFPTYQOR7C7JZIDWRGMK5ANCNFSM6AAAAAATMWPI2M> . You are receiving this because you authored the thread.Message ID: ***@***.***>