NullPointerException when any benchmark is not matched by :selector predicate about jmh-clojure HOT 4 CLOSED

The NPE was caused by jmh's NoBenchmarksException returning nil from getMessage, which I didn't expect. I have fixed the issue in my local repo.

Do you have an opinion on how the larger "no benchmarks" issue should be handled? Should the NoBenchmarksException be re-thrown? Or should jmh.core/run just return an empty seq in this case?

Thanks again for the bug report and good repro!

from jmh-clojure.

I've thought a bit on this now and I'm leaning on just re-throwing the NoBenchmarksException for the time being, which is consistent with the JMH API. Also, jmh.exec/run already will throw other JMH exception types. For example, a RunnerException is thrown when JMH can't acquire the lock file.

Returning an empty seq might be confusing too if a user simply misspelled a selector name for example.

from jmh-clojure.

Thank you for answer and work.

Unfortunately I don’t think I can answer these questions. I am only a
user; I’m not familiar with the JMH APIs. This issue here I stumbled
over when I wanted to run a single benchmark and did not manage to write
a selector that worked.

from jmh-clojure.

Fixed with 194a5ac. Released version 0.1.2. Thanks again!

from jmh-clojure.