janejeon / dev Goto Github PK

For libraries, applications, infra repos…

• eslint-config
• prettier-config
• renovate-config
• skip-ci

• @typescript-eslint/eslint-plugin
• @typescript-eslint/parser
• eslint-plugin-deprecation
• eslint-plugin-import for typescript

https://github.com/standard/eslint-config-standard-with-typescript/blob/master/src/index.ts for rules

I'd like to be able to replicate CodeClimate's rules on complexity thru ESLint.

A few pointers:

• https://eslint.org/docs/rules/complexity (ESLint itself has a rule for cyclic complexity)
• CodeClimate "maintainability" checks:

(if I'm done replicating, I should delete the CodeClimate account)

Is there a shorthand for pointing within a monorepo?

At the very least, they need to be pulled up to the root level.

Have it as a separate package for peerDeps purposes

• react
• react-hooks
• react-app
• xss
• rule for no class components?
• eslint-plugin-import for react/jsx

Split out prettier as peerDependencies, as they are now installed by default.

Make sure npm version is >=7 (which is when the "install peer deps by default" behaviour was added) via engines key.

Probably split them out into "universal", "backend", and "frontend"

Some ideas for prod:

• nopp: a small, universal package to prevent prototype pollution straight up?
• trace and clarify: backend packages to be run on init to help with debugging - do we still need this w/ VS Code, given that we're never going to use this in production?

Dev dependencies:

• husky v8
• lint-staged
• is-ci
• skip-ci
• eslint config
• prettier config
• commitlint config
• commitlint-related tooling
• jest-related tooling (jest, jest-junit, node-notifier)
• typescript-related tooling (typescript, typescript-eslint, ts-jest)
• cross-env
• onchange
• concurrently
• npm-run-all
• wait-on
• rimraf
• copyfiles

e.g lint, lint-pr, prettier & eslint commands w/ caching

Again, need to leverage lerna's cross-linking and task running abilities.

Once I experiment with normalize-url-plus, update the eslint config as necessary!

• #48
• #49
• cut a release manually (patch) w/ lerna

For libraries? For applications?

• Make eslint, eslint-config-prettier, eslint-config-standard, eslint-plugin-import, eslint-plugin-n, and eslint-plugin-promise into peer dependencies
• switch from node to n
• Trim down the ESLint config down to just the above
• eslint-plugin-import for regular javascript
• extend plugin:promise/recommended
• extend plugin:n/recommended
• eslint-plugin-lodash plugin and extend recommended
• eslint-plugin-markdown plugin and extend recommended
• no-extend-native and no-use-extend-native
• regexp
• sonarjs
• security
• eslint-config-turbo for monorepo usage

Specifically, for git hooks.

Also remove individual git hooks at the repository level.

• jest
• jest-formatting
• jest-dom
• testing-library
• jest-async

Basically, the idea is to have a renovate.json at the root repo, with something like

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": ["local>JaneJeon/renovate-config"]
}

pointing at the local JSON.

https://lerna.js.org/docs/getting-started#caching

Instead of having different versions of packages cross-referencing each other installed in package.json, leverage lerna bootstrap to just "link" all of the packages together as a "*" dependency.

The idea is that for most of my repos, the .lintstagedrc.yml is going to look basically the same. Therefore, we export the JSON configuration as a package, and utilize .lintstagedrc.js JS configuration for the lint-staged configuration (see: https://github.com/okonet/lint-staged/#using-js-configuration-files) so that we can simply require that JSON and export it (or add additional attributes if I have special needs).

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(): update vitest monorepo to v1 (major) (@vitest/coverage-istanbul, @vitest/ui, vitest)
• chore(commitlint-config): update commitlint monorepo to v19 (major) (@commitlint/cli, @commitlint/config-conventional, @commitlint/config-lerna-scopes, @commitlint/cz-commitlint)
• chore(eslint-config): update dependency eslint to v9
• chore(eslint-config): update dependency eslint-plugin-n to v17
• chore(got): update dependency got to v14
• chore(got): update dependency got-scraping to v4
• chore(got): update dependency got-ssrf to v3
• chore(workflows): update actions/setup-node action to v4
• chore(workflows): update github/codeql-action action to v3
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository