inloop / image-picker Goto Github PK

when recording a video, default camera cell should have duration label with a blinking red dot indicating that a video is being recorded

while calling flip camera, the completion closure if unused should not be present and set to nil by default

Hi, I recently find out a bug, when collection view loads a lot of images, app will crash, can you fix that problem. Thank you. Btw, your library is really great, but can you detail more about How to install it via carthage, or pod, and manually too. Thanks.

Hi,
i got a problem when i take a picture, in my collection that pics will added but the already selected cells will be deselected (it seems that this collection reloaded itself).
Im using default cells and layout (not that custom one)
I did a test with your example app, and i noticed that this not happen.

Can u please tell me how can i move to solve this ?

live badge label on picture has transparent text, current implementation shows just yellow label

therefore we have to add to AssetCell if asset is a video:

• video icon
• video duration
• bottom shadow gradient

and if it's a live image

• live image icon

Image picker displays only 2 photos for selection by default unless the count in camera roll exceeds 1000.

start a video recording and scroll camera cell off the screen. Recording will still undergo but camera cell is blurred. It should be blurred only if session is not running.

Implement:

func imagePicker(controller: ImagePickerController, didCaptureVideo url: UIImage)
func imagePicker(controller: ImagePickerController, didTake livePhoto: UIImage, videoUrl: UIImage)

Steps to reproduce:

1. Play music on iPhone
2. Enable Video and Photo for ImagePicker
3. Go to app and open image picker

Result: Music stops playing due to AVCAptureSession audio type

Provide different session setups for image, video, live photos.

• animated shutter button
• live photo badge
• animated start/stop video record button

this was recently added to iMessages picker, so it would be nice to have

After touching flip camera button nothing happened

Thank you for creating such a great component! We would love to use it in our project, but I do not see the license file. Is it meant to be MIT like your other projects and the license file was just omitted or is there a different intention?

Thank you!

If setting any color to appearance globally, it does not work.

Steps to reproduce:

1. call ImagePickerController.appearance().backgroundColor = UIColor.black
2. create an instance of ImagePickerController
3. present it as input view

Expected result:

• the background color is black

Actual result:
The color is not changes

Environment:
iPhone 6s
iOS 11.0

Note: Setting the background per instance works well

Create podspeca and support cocoapods setup.
Also enhance REAMDE by step by step guide how to setup it.

please provide a way to remove all selected assets e.g

let imagePicker = ImagePickerController()
imagePicker.clearSelection()

When built with iOS 12 beta SDK the State enum conflicts with the UIControl.State (renamed from UIControlState in iOS 12).

Currently new safe area traits are not being considered when laying out collection view. This must be adopted to fully support iPhone X for both portrait and landscape modes.

Receive following error.
Module compiled with Swift 4.1.2 cannot be imported by the Swift 4.2 compiler: .../Carthage/Build/iOS/ImagePicker.framework/Modules/ImagePicker.swiftmodule/arm64.swiftmodule

Have already tried: carthage update --platform iOS and carthage build

log information:

The following build commands failed:
	CompileSwift normal armv7
	CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler
	CompileSwift normal arm64
(3 failures)

Also tried setting different Swift Language Versions in Build Settings

Nothing helps

ImagePicker crashes on CaptureSession:338 because of the force unwrap of defaultVideoDevice.

now the aspect ratio is fixed:

• action cells have ratio 1:1
• camera cell has ratio 0,7:1

1. it would be nice if we changed ratio of action cells to match original iMessage picker, also in landscape
2. in landscape, camera cell's ratio should be updated to 1:0,7 or something wider

While subclassing the CameraCollectionViewCell, I cannot add custom target and selector for takePicture, switchCamera since the functions are not marked @objc @tankista

I got implement your image picker, i'm able to bring object from collection, but when i click "camera" button that allow me to have a default camera of smartphone, after clicked to get foto or video, i'm not able to find that file in a list....where i can find that, there is a delegate that allow to get that file ?

From Fabric:

Fatal Exception: NSInternalInconsistencyException
attempt to delete and reload the same index path (<NSIndexPath: 0x1d4429640> {length = 2, path = 2 - 5})

The permissions should be required once the user would like to display the component instead during load time / controller initialization.

Potentially you can add overlay indicating that to use the component additional permissions are required.

Hello! Thank you very much for this amazing library. I also like your other libraries here on GitHub. It's really useful and looks great too.

I just have a question. How do I remove the video option when I open the camera app?
I have set the captureSettings.cameraMode = photo.
However, there is still a video option. I don't want my users to use video recording because my app does not use it. Just photo.
I attached a screenshot here.

Thank you!

Is it possible to embed the image-picker in a ViewController which always has the keyboard open? I want to have image-picker as an independent row above the keyboard and always stay visible, while the user may use the keyboard to input text in a text view on the screen.

Layout configuration should have enabled both action items by default, showing default icons and text. Ideally default implementation should open camera and photo library.

Options:

• add support for custom identifier
• add static overridable identifier to cells
• expose identifiers that everyone is aware of it

or update readme defining that the reuse identifier should be left empty when registering the nib