self::$fields is an array of arrays, but $columns must be an array of strings
so we have to take only "label" of fields by using wp_list_pluck

In the example file change the last function to:

public static function _columns( $columns ) {

	$columns = array_merge( $columns, wp_list_pluck( self::$fields, 'label' ) );

	return $columns;
}

If I am using wp_setup_nav_menu_item() to create menu items, will this allow me to insert custom fields dynamically with that function? Or is it called after the menu items are created?

This works fine with WordPress 4.6.1 but doesn't work with WordPress 4.7. I can't seem to figure out the issue. Could you please point me in the right direction.

Thank you!

I have this included in my theme as a library, with only slight modifications to the example implementation.

Without a conditional on all the code, the ajax call for adding a new menu item fails and users can't add new menu items.

Fix looks like:

if ( ! defined( 'DOING_AJAX' ) || ! DOING_AJAX ) :

function myplugin_load_menu_item_custom_fields() {
    require_once get_template_directory() . '/vendor/wp-menu-item-custom-fields/menu-item-custom-fields.php';
}
add_action( 'load-nav-menus.php', 'myplugin_load_menu_item_custom_fields' );

/**
 * Menu item metadata
 */
class Pipeline_Menu_Item_Custom_Fields {

}
Pipeline_Menu_Item_Custom_Fields::init();

endif; // AJAX check

Hi @kucrut again.

I'm using your brilliant plugin wp-menu-icons together with your wp-menu-item-custom-fields library for adding my own menu item custom fields.

I required Menu_Item_Custom_Fields_Walker from wp-menu-item-custom-fields library directly in my theme and extended with some extra functions for my needs.
So, when my theme activated within wp-menu-icons plugin — i can't use my functions from my theme's Menu_Item_Custom_Fields_Walker, because class is already exist in menu icons plugin.

For example, here is my Menu_Item_Custom_Fields_Walker where I adding my own item-controls in .menu-item-bar.

class Menu_Item_Custom_Fields_Walker extends Walker_Nav_Menu_Edit {

    function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) {
        $item_output = '';
        parent::start_el( $item_output, $item, $depth, $args, $id );
        $output_pre = preg_replace(
            // NOTE: Check this regex from time to time!
            '/(?=<span[^>]+class="[^"]*item-type)/',
            $this->get_labels( $item, $depth, $args ),
            $item_output
        );
        $output .= preg_replace(
            // NOTE: Check this regex from time to time!
            '/(?=<p[^>]+class="[^"]*field-move)/',
            $this->get_fields( $item, $depth, $args ),
            $output_pre
        );
    }

    protected function get_fields( $item, $depth, $args = array(), $id = 0 ) {
        ob_start();
        do_action( 'wp_nav_menu_item_custom_fields', $id, $item, $depth, $args );
        return ob_get_clean();
    }

    protected function get_labels( $item, $depth, $args = array(), $id = 0 ) {
        ob_start();
        do_action( 'wp_nav_menu_item_custom_labels', $id, $item, $depth, $args );
        return ob_get_clean();
    }
}

in OS_Menu_Item_Custom_Fields i've added that action.

add_action( 'wp_nav_menu_item_custom_labels', array( __CLASS__, '_labels' ), 11, 4 );

public static function _labels( $id, $item, $depth, $args ){
    $out = '<span class="os-item-label-mega"><span class="os_label os_bg_brand">Mega Menu</span></span>';
    $out .= '<span class="os-item-label-mega-column"><span class="os_label os_bg_brand_alt">Column</span></span>';
    echo $out;
}

Interesting that, when i've used wp-menu-icons from icon-picker-integration branch — my Menu_Item_Custom_Fields_Walker class was not overridden by plugin's class.

So, I have a question. How to right filter Walker_Nav_Menu_Edit walker via your Menu_Item_Custom_Fields_Walker from this library that in the future do not have problems with other plug-ins, which can also extend Walker_Nav_Menu_Edit walker class?

Cheers!

I was planning on using this library. But for some reason the fields are duplicated.

What I have for each menu item is:
Custom Field #1
Custom Field #2
Custom Field #1
Custom Field #2

This plugin adds fields to all the nav menus. I want to add specific fields to specific menus, and I don't see a parameter for that.

Can you add support for composer?

Thanks in advance.

While this does a fairly good job at quickly and easily creating additional input fields on menu items...does it actually display on the front end at all?

I'm looking for a way to add a field for 'Custom Class', and hook into the default menu walker without having to load my own.

Originally reported by @helgatheviking.

First, I love the preg_replace() idea! And two, thanks for adding the wp_nav_menu_item_custom_fields action hook so Nav Menu Roles and Menu Icons can be compatible.

However, I've found that your action hook's params aren't the same as mine.

You have:

do_action( 'wp_nav_menu_item_custom_fields', $id, $item, $depth, $args );

While I have:

do_action( 'wp_nav_menu_item_custom_fields', $item_id, $item, $depth, $args );

In your case $id will always be zero. I don't know if this has a lot of impact since it's only used by us menu plugin authors, but I thought I'd point it out.