Creating new annotations destroys existing unsaved ones about client HOT 7 CLOSED

Expected: Annotation 1 should be deleted, I should see annotation 2 in the sidebar.

I'm trying to remember, is this what we designed? The argument being that I might have written something long form, gotten distracted, and then gone to create a new annotation forgetting that I hadn't saved the first.

Should we instead prevent the creation of a new one and perhaps scroll the existing one back into view?

But I'm struggling to find any of the threads of previous discussion around this, and may not be recalling correctly.

from client.

@seanh 's descriptions of the actual and expected behavior are correct. This is broken because a couple of my recent changes did not correctly account for annotations without server assigned IDs. PR on its way.

from client.

Also there was an existing but previously unnoticed bug where the orphan status of new annotations was not correctly initialized.

from client.

🎉

from client.

Nice, @robertknight

from client.

I had thought we decided that two annotations can never be under construction at the same time?

from client.

No, you can have multiple in-progress drafts, but if your draft is empty (no text or tags) it will be discarded when you start a new annotation.

from client.