Comments (4)
acelaya
commented on June 29, 2024
The root cause is the same causing #5520
A possible solution would be for Dialog to expose a handle with a close method that triggers the close transition in the normal way.
We considered this some time ago hypothesis/frontend-shared#1178
I think I even created a POC, but I guess I had to park it due to other priorities.
from client.
victuseze
commented on June 29, 2024
Hi robertKnight, I would like to work on this.
from client.
mustafaazad03
commented on June 29, 2024
Hi @robertknight & @acelaya, Can I try to solve this issue?
from client.
acelaya
commented on June 29, 2024
Thanks for the interest!
This issue is a bit more complex than it might seem and has some implications. We need to put a bit more thinking on it to see where it fits in the grand scheme of things, before we can prioritize it.
We'll share more information as soon as we have it.
from client.
Related Issues (20)
- Consider keeping sidebar state when opening modals via native `dialog`.
- Use a native `dialog` in user profile modal
- Indicate links that open in new tabs to assistive technologies HOT 1
- Improve close button label specificity
- Can't annotate https://community.canvaslms.com/ (issue with tsParticles) HOT 2
- Validate max length for tags
- Error with iframe `allow` attribute when annotating pages on archive.org HOT 6
- Migrate to eslint flat config HOT 1
- Create a new toast-like notification that is displayed when there are pending updates HOT 2
- Add accessible `tabpanel` role to the panels handled by selection tabs in the sidebar
- Hide "annotate" and "highlight" icons from "Getting started" tab to screen readers
- Consider automatically closing the help panel if auto-opened and user creates annotations HOT 2
- can't log in at Edge add-on HOT 7
- Optionally preserve (carry over) tags for the ensuing annotation
- Multiple annotations by the same person have the same accessible title HOT 3
- Annotation cards can be interacted with the mouse but not with the keyboard
- Reconsider the usage of "dialogs" for non-modal sidebar panels
- When loading pending updates, consider scrolling to the "closest" one, not the latest one HOT 2
- Incorrect Conversion of Overlapping Highlights or Notes Upon Page Navigation HOT 5
- Adder not fully visible due to z-index miscalculation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from client.