Git Product home page Git Product logo

Comments (5)

robertknight avatar robertknight commented on June 21, 2024

That's not a standard build of the Hypothesis client shown in the video, which also probably means it is not based on a current version. The controls in the standard build look like this:

Annotate Highlight

Can you confirm the version number that is shown in the sidebar (it's under the "?" button), the URL of the page that is being annotated (if there is one) or the software in which Hypothesis is being used?

from client.

likithesh-ts avatar likithesh-ts commented on June 21, 2024

That's not a standard build of the Hypothesis client shown in the video, which also probably means it is not based on a current version. The controls in the standard build look like this:

Annotate Highlight Can you confirm the version number that is shown in the sidebar (it's under the "?" button), the URL of the page that is being annotated (if there is one) or the software in which Hypothesis is being used?

We have made some changes on the CSS part so it's looking bit different than the standard version and I was able to replicate this issue in latest version of the hypothesis-client. Please find the below video for reference
https://github.com/hypothesis/client/assets/159520431/2a50c3dc-e34e-4943-8c5e-36ad58fc040c

from client.

robertknight avatar robertknight commented on June 21, 2024

In that video I see two highlights created and saved and two notes created, but not saved. After the navigation away from the page and back to it, only the saved highlights persist. Changing groups in the sidebar would also lead to the same result as a navigation.

If the issue here is the confusion that the draft notes are not automatically saved, or that there isn't a warning about it, then that's understandable and I would recommend to create a specific issue about it.

from client.

likithesh-ts avatar likithesh-ts commented on June 21, 2024

In that video I see two highlights created and saved and two notes created, but not saved. After the navigation away from the page and back to it, only the saved highlights persist. Changing groups in the sidebar would also lead to the same result as a navigation.

If the issue here is the confusion that the draft notes are not automatically saved, or that there isn't a warning about it, then that's understandable and I would recommend to create a specific issue about it.

If you watch the video below, you'll notice that before navigation, highlighted text and notes appear in different colors: highlights are light yellow, while notes are a darker shade. However, when switching between pages, both words become the darker shade of yellow. Additionally, clicking on a noted word in the sidebar should only highlight the single word that we initially highlighted, but it highlights both words instead.

Hypothesis-issue-3.1.mp4

from client.

acelaya avatar acelaya commented on June 21, 2024

highlighted text and notes appear in different colors: highlights are light yellow

Highlights and annotations don't actually have different colors, but we do show a "darker" color when there are "stacked" annotations, or more than one annotation in the same block of text, in order to more visually spotlight what parts are heavily annotated.

In fact, it's not really darker, technically speaking. What really happens is that the element we use for highlights and annotations has a yellow color with opacity. As an intentional side effect, the opacity makes it look darker the more annotations are rendered in the same piece of text.

However, when switching between pages, both words become the darker shade of yellow. Additionally, clicking on a noted word in the sidebar should only highlight the single word that we initially highlighted, but it highlights both words instead.

I was able to reproduce this with the standard hypothesis client in that particular Google search result, but not in other pages.

I think this was a known issue due to how hypothesis detects where the quoted text starts and ends. Let me see if I can find some related issue.

from client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.