Git Product home page Git Product logo

Comments (1)

robertknight avatar robertknight commented on June 16, 2024

The short answer is that this setting still exists but is not effective any more, and we should indeed remove it from the documentation.

This setting is still used in the code, but you'd need to use something like VS Code which understands TypeScript projects to find all usages of the icon field.

To go into more detail, the option was originally added for publishers like eLife who have a white-labeled version of Hypothesis on their site. We subsequently added the concept of "organizations" to Hypothesis which can have their own logo, and that takes priority over the services.icon field. We later made it so that all groups are assigned to an organization, using a default one with a Hypothesis logo if they haven't been assigned to a more specific one. I believe this means, although it needs to be confirmed, that the service.icon value is never used.

from client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.