Comments (1)
The short answer is that this setting still exists but is not effective any more, and we should indeed remove it from the documentation.
This setting is still used in the code, but you'd need to use something like VS Code which understands TypeScript projects to find all usages of the icon
field.
To go into more detail, the option was originally added for publishers like eLife who have a white-labeled version of Hypothesis on their site. We subsequently added the concept of "organizations" to Hypothesis which can have their own logo, and that takes priority over the services.icon
field. We later made it so that all groups are assigned to an organization, using a default one with a Hypothesis logo if they haven't been assigned to a more specific one. I believe this means, although it needs to be confirmed, that the service.icon
value is never used.
from client.
Related Issues (20)
- Make sure annotations text is rendered to HTML when exporting to that format
- Filter toggles can overflow search panel
- Making excerpts editable HOT 3
- Accessibility issues from Jan 2024 review HOT 1
- Make documentation around iframe permissions more generic
- Notebook modal dialog is not properly represented as a dialog
- Incorrect use of `aria-pressed` for sidebar collapse/expand button
- `aria-pressed` not used for "Show highlights" button
- Annotation/Reply body text areas accessibility improvements
- Update PDF.js (2024 edition)
- `<article>` label is the same for every annotation by the same author HOT 1
- Add status message confirming when a highlight is created HOT 1
- Consider keeping sidebar state when opening modals via native `dialog`.
- Use a native `dialog` in user profile modal
- Indicate links that open in new tabs to assistive technologies HOT 1
- Improve close button label specificity
- Can't annotate https://community.canvaslms.com/ (issue with tsParticles) HOT 2
- Validate max length for tags
- Error with iframe `allow` attribute when annotating pages on archive.org HOT 6
- Migrate to eslint flat config HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from client.