hughrun / rockpool Goto Github PK

Describe the bug
When a user changes their email address, the app is meant to immediately log them out. However, the app currently does not tell a user that they have been logged out when they change their email address. Additionally, users can continue to make edits to their user details without being aware that they have been logged out. It is unclear whether these edits save properly to the database.

To Reproduce

1. Log in, navigate to /user
2. Change email address and/or other details
3. Click 'update'
4. Admire the absence of any error or advice message
5. Continue to update user details

Expected behavior
I expected the app to tell me that I had been logged out. It wasn't until I did a forced refresh (cleared cache) that I was returned to the /letmein screen.

Desktop (please complete the following information):
Chrome on macOS

Probably using Vue

Who will benefit from your new feature?

• App users
• [X ] App Maintainers / System Administrators
• Developers
• Someone else

Is your feature request related to a problem? Please describe.
Updating colour schemes is a pain in the neck if you have to do it manually.

Describe the solution you'd like
Assign colours via an SCSS file that processes into a css file when npm setup is run.

Describe alternatives you've considered
None.

What kind of users will this most benefit?
Admins who just want to update the colour scheme.

Additional context
None.

Create a docker file, docker compose file, and documentation for using docker to run Rockpool.

Who will benefit from your new feature?

• [x ] App users
• App Maintainers / System Administrators
• Developers
• Someone else

Is your feature request related to a problem? Please describe.
A lot of the user and admin screen is not very beautiful, not mobile-optimised, and likely not as accessible as it could be.

Both the default markdown file and the github docs need to be updated, specifically:

• claiming blogs instructions are wrong
• registering blog instructions slightly wrong
• database structure may be out of date
• installation instructions are missing
• general cleanup of README

This will allow users to simply press a button and then confirm, rather than typing in the URL.

e.g. the domain name length should be calculated rather than assumed.

There appears to be a memory leak when running in production.

This is probably due to not closing mongo connections properly, and the setInterval functions.

On the help page, the heading 'Excluding one of more blogs from Pocket subscription' should read 'Excluding one OR more blogs from Pocket subscription'.

Would be good to be able to click on the category and then the list only shows blogs with that category. Would need a reset button somewhere to get the full list back without having to reload the page.

Legacy blog data doesn't include titles, so the browse page shows URLs, which are often ugly and long. When a user claims a blog we should run feed-finder like happens when registering a blog, so that the title can be added to the DB and then displayed instead of the URL.

1. Log in with new email
2. Do not update details
3. go to /browse page
4. notice that you cannot see any blogs listed.

i.e. add some v-ifs such that you can only update email, twitter and mastodon until you've actually registered.

Currently it is easy to create a mismatch between server and client data, if client data is updated multiple times whilst and API request is being processed. browse-vue.js, user-vue.js and admin-vue.js all need to be refactored so that editing is set to false before the api call is made, and at the same time processing or loading or something like that is set to true, triggering a loader icon and preventing further edits until the API call finishes.

This should hopefully assist with #43 and is somewhat related to #46

Who will benefit from your new feature?

• App users
• App Maintainers / System Administrators
• Developers
• Someone else

Is your feature request related to a problem? Please describe.
Upon logging in for the first time, it is likely users may wish to claim an existing (legacy) blog, but there is no clear path on the /user page for them to do this.

Describe the solution you'd like
Add a 'claim blog' button under 'Your Blogs', to complement the 'register a blog' option.

Describe alternatives you've considered
I could click aimlessly until I found what I'm after, but this seems less efficient.

What kind of users will this most benefit?
Users who already have legacy blogs registered and would like to claim them.

Additional context

Ideally we should enable this from both the browse and user pages.

It could use a new API route at .../update/user/delete-blog-registration

Existing functions (i.e. used by the rejection process) should be able to be re-used.

The logic in 8e935e0 to stop legacy blog approvals being announced was overridden by 555e537 (use feedfinder to get titles for legacy blogs).

Describe the bug
When running npm test on a fresh DB (i.e. no rockpool_test DB exists), the check for indexes fails.

To Reproduce
Steps to reproduce the behavior:

1. Run npm test without a pre-existing rockpool_test database

Expected behavior
Index-checking tests pass.

Error message

  80 passing (11s)
  40 pending
  4 failing

  1) Test suite for Rockpool: a web app for communities of practice
       npm setup - to prepare DB before running Rockpool
         should build index on tags field in rp_articles:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/hugh/coding/JavaScript/rockpool/test/test.js)
  

  2) Test suite for Rockpool: a web app for communities of practice
       npm setup - to prepare DB before running Rockpool
         should build text index in rp_articles:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/hugh/coding/JavaScript/rockpool/test/test.js)
  

  3) Test suite for Rockpool: a web app for communities of practice
       npm setup - to prepare DB before running Rockpool
         should create rp_articles collection when they are indexed:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/hugh/coding/JavaScript/rockpool/test/test.js)

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• node version [e.g. 10.16.0] - run node -v on your command line to get this

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Needs a default favicon.

Describe the bug
Clicking 'edit' and then 'update' in account page wipes Pocket account details for user.

In admin page when you deal with all of a user's requests the requests disappear but the user remains.

Who will benefit from your new feature?

• App users
• App Maintainers / System Administrators
• Developers
• Someone else

Is your feature request related to a problem? Please describe.
Sometimes you just want to get an email rather than follow a twitter account.

Describe the solution you'd like
Each week subscribers are sent an email listing each blog post published in the previous 7 days, with a brief description and link.

What kind of users will this most benefit?
People who don't use Twitter or Pocket, or prefer email.

Additional context
Add any other context or screenshots about the feature request here.

See user page for how to implement.

currently blog suspension is a big clunky.

views/subscribe.html uses hard-coded values for the twitter and masto accounts. This should be pulled in from settings.json.

At the moment there is an ugly form at the bottom of the user dashboard. Should only appear when needed, like the blog edit toggle.

Once a user has registered, they are asked to input their details on the user page. The fields for a user's email, twitter and mastodon accounts are too short and don't quite line up. The field text is also bigger than the text on the rest of the page.

It's not clear whether there's any input validation for these fields, nor is there guidance as to what input is expected (e.g. include/omit the leading @ in a twitter or mastodon handle, ensure server is included for mastodon)

connect-mongo seems the best bet. MemoryStore is not fit for production use.

Who will benefit from your new feature?

• App users
• App Maintainers / System Administrators
• Developers
• Someone else

Is your feature request related to a problem? Please describe.
Since toots are automated, it's likely that some will include content that would benefit from a content warning.

Describe the solution you'd like
Add a new setting content_warnings that takes an array of strings. These are checked against each post's tags before tooting, and all matching terms are included as a content warning on the toot.

Describe alternatives you've considered
We could simply CW every toot but that seems a bit over the top.

What kind of users will this most benefit?
Mastodon users who don't want to be confronted with upsetting automated toots.

Additional context
Add any other context or screenshots about the feature request here.

In the old app all tags were passed through, which wasn't great, but currently Rockpool sends no tags through. Should pass a tag that is the name of the app.

Describe the bug
In /browse users can claim ownership of blogs they already own. This is confusing and likely to be buggy.

Should have a v:if to not show it if the blog is owned by the current user.

This will need to

• check environment settings,
• install mongodb,
• set up mongo security, db name and user,
• install node modules (npm install should do the trick)

and probably some other things.

And then report to the user in a meaningful fashion if there's something they need to do.

Describe the bug
When a user claims a blog and it is approved, an announcement is triggered that the blog has been added, which is not true.

To Reproduce
Steps to reproduce the behavior:

1. Claim a blog
2. Approve blog as admin
3. Wait for blog to be announced on twitter/masto
4. See announcement

Expected behavior
Approving a claimed blog should trigger an email to the owner but not an announcement.

Error message
n/a

Screenshots
n/a

Desktop (please complete the following information):
all

Smartphone (please complete the following information):
all

Additional context
Nil

Follow the 12-factor app rules on env and have a single environment file that docker imports rather than settings.js with different environments. Tests should cope with most env variables.

Describe the bug
On the help page, the 'login or register' link goes to localhost.

To Reproduce
Steps to reproduce the behaviour:

1. Go to the help page
2. Click on 'login or register'
3. Admire the localhost link that doesn't work for anyone else

Expected behaviour
I expected the link to go to the /letmein page but it did not 🙁

Desktop:

• OS: macOS
• Browser : chrome

Additional context
Changing this to a relative link should solve this issue.

• non-admin component file needs to be renamed
• check component names are sensible
• can anything be more DRY?
• check and if necessary rewrite all 'flash' message code
• check functionality of admin and user pages
• user script & html needs to be componentised

As discussed in #41 , this was previously set up in commit 31b4479 but was reversed when VueJS was added to the project and user info updates were moved to an AJAX API model. Needs to be re-instated.

There should also be a email2 field to confirm the email address before updating it, otherwise people might typo it and lock themselves out.

i.e. in migrate.js

Don't forget to update this once all 'new' settings are finalised.
Possibly add test coverage for each tested feature, if we're being complete.

some of the styling is a little ...rudementary. Need to audit everything.

Header says Posts about from [month]

Should say Posts from [month]

This is the same as #27 but for claimed blogs, not just owned blogs

In app.js (line 98), the login email sent to users contains the phrase 'please log in in now'. This should read 'please log in now'.

announce() sorts the announcements collection by date ascending. This should be date descending so that posts are announced in the order they were added.

Who will benefit from your new feature?

• App users
• App Maintainers / System Administrators
• Developers
• Someone else

Is your feature request related to a problem? Please describe.
Not every blog in Aus GLAM Blogs is of interest to me. It would be good to be able to apply a filter so some never appear in my Pocket account.

Describe the solution you'd like
Ideally users would select a blog that is listed in the DB, and select it to be filtered out. This would add the blog _id to an array which would be checked prior to adding to Pocket.

Describe alternatives you've considered
Originally this was an idea to add to pocketsnack but it's better to filter them at the source.

What kind of users will this most benefit?
Fussy ones.

Additional context
Add any other context or screenshots about the feature request here.

need to find some freely licensed images for the repo.