Git Product home page Git Product logo

Comments (4)

hughrun avatar hughrun commented on September 27, 2024

There is server-side validation of these fields, primarily because client-side validation has multiple problems including security issues. If you enter text in the wrong format a message will appear explaining how to correct the mistake.

  1. Would some placeholder text do the job sufficiently?
  2. Should the font size of the labels be increased or that of the fields be decreased?

from rockpool.

lissertations avatar lissertations commented on September 27, 2024

I tested this but did not receive an error message (Chrome/macOS).

Additionally, when testing incorrectly-formatted input I noticed that after a couple of changes the 'Update' button appears to stop working (that is, the field remains available to edit) but subsequently clicking the 'Cancel' button saves the changes anyway.
Screen Shot 2020-03-09 at 21 49 42

Screen Shot 2020-03-09 at 21 52 59

Screen Shot 2020-03-09 at 21 49 18

  1. Some placeholder text would be useful, thank you :)
  2. The font size of the fields should be decreased, to bring them into line with the rest of the page.

from rockpool.

lissertations avatar lissertations commented on September 27, 2024

Additionally, when testing incorrectly-formatted input I noticed that after a couple of changes the 'Update' button appears to stop working (that is, the field remains available to edit) but subsequently clicking the 'Cancel' button saves the changes anyway.

This is probably related to #43.

from rockpool.

hughrun avatar hughrun commented on September 27, 2024

Soooo I added field validation for all three fields in 31b4479 but then when I moved everything to vuejs components so I could make the page reactive I forgot to keep the field validation... Whoops.

from rockpool.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.