hpatoio / deploybundle Goto Github PK

When deploying, I often get timeouts (Symfony\Component\Process\Exception\RuntimeException)

So it would be nice to be able to set a timeout for the process

Possible patch:

--------------------------------8<-----------------------------

--- DeployCommand.php   2013-12-10 14:01:57.385970911 +0100
+++ DeployCommand.php.new   2013-12-10 14:03:51.477975039 +0100
@@ -31,6 +31,7 @@
             ->addOption('go', null, InputOption::VALUE_NONE, 'Do the deployment')
             ->addOption('rsync-options', null, InputOption::VALUE_NONE, 'Options to pass to the rsync executable')
             ->addOption('force-vendor', null, InputOption::VALUE_NONE, 'Force sync of vendor dir.')
+            ->addArgument('timeout', InputArgument::OPTIONAL, 'Process timeout')
             ;
     }
 
@@ -45,7 +46,10 @@
         $available_env = $this->getContainer()->getParameter('deploy.config');       
         
         $env = $input->getArgument('env');
-        
+        $timeout = $input->getArgument('timeout');
+        if(!$timeout) {
+            $timeout = 60;
+        }
         if (!in_array($env, array_keys($available_env))) {
             $output->writeln('Env value not valid.');
             exit();
@@ -82,7 +86,7 @@
             $command));
 
         $process = new Process($command);
-
+        $process->setTimeout($timeout);
         $output->writeln("\nSTART deploy\n--------------------------------------------");
 
         $process->run(function ($type, $buffer) use ($output) {

------------------------------------>8------------------------------------------------

Hi @hpatoio
I could not open an issue on your bitly github. Wanted to say as you abandoned your bitly repo. We are grateful if you add a link to our bitly repo as replacement suggestion.
Thanks,

in DependencyInjection/DeployExtension.php, line 30

This file ends with no newline character. It won't render properly on a terminal, and it's considered a bad practice. Add a simple line feed as the last character to fix it.

        $container->setParameter('deploy.config', $config);

    }

}

Posted from SensioLabsInsight

Improve doc.

• Put everything in README.md
• Include new feature
• Reword and reorganize

After installing the DeployBundle with composer I can't execute no command with the symfony console. Regardless of which command I try, following exception is thrown:

[Symfony\Component\Config\Definition\Exception\InvalidConfigurationException]  
The path "deploy" should have at least 1 element(s) defined.

This exception is also thrown in the development-env (app_dev.php)

Environment: Symfony v2.1.7 Standard Distribution plus FOSUserBundle v1.3.1

Hi, how can I ignore the cache folder?

Thanks

The checker detected 1 security issues in package symfony/framework-bundle installed in version 2.5.0.0 1) Code injection in the way Symfony implements translation caching in FrameworkBundle.

Posted from SensioLabsInsight