Argument for process timeout about deploybundle HOT 5 CLOSED

Sorry, the patch has been corrupted, so again:
---------------------------8<----------------------------------

--- DeployCommand.php   2013-12-10 14:01:57.385970911 +0100
+++ DeployCommand.php.new   2013-12-10 14:03:51.477975039 +0100
@@ -31,6 +31,7 @@
             ->addOption('go', null, InputOption::VALUE_NONE, 'Do the deployment')
             ->addOption('rsync-options', null, InputOption::VALUE_NONE, 'Options to pass to the rsync executable')
             ->addOption('force-vendor', null, InputOption::VALUE_NONE, 'Force sync of vendor dir.')
+            ->addArgument('timeout', InputArgument::OPTIONAL, 'Process timeout')
             ;
     }
 
@@ -45,7 +46,10 @@
         $available_env = $this->getContainer()->getParameter('deploy.config');       
         
         $env = $input->getArgument('env');
-        
+        $timeout = $input->getArgument('timeout');
+        if(!$timeout) {
+            $timeout = 60;
+        }
         if (!in_array($env, array_keys($available_env))) {
             $output->writeln('Env value not valid.');
             exit();
@@ -82,7 +86,7 @@
             $command));
 
         $process = new Process($command);
-
+        $process->setTimeout($timeout);
         $output->writeln("\nSTART deploy\n--------------------------------------------");
 
         $process->run(function ($type, $buffer) use ($output) {

--------------------------->8-----------------------------------

from deploybundle.

Hello, I think is much better to have it as a parameter in the config file. In this way you don't have to specify it every time you write the command and you can also have a per environment timeout.

from deploybundle.

Hi,

i think you are right :-)

A parameter in the config file is even better!

from deploybundle.

Just committed this functionality. Please switch to dev-master your composer and tell me if you like it. I've updated the doc to, so you can find there how set the timeout.

from deploybundle.

I checked it out and it seems to work perfectly! Thank you very much!

from deploybundle.