Possibly wrong return type about json-everything HOT 10 OPEN

No worries, if only dotnet's ElementAt would have checked for IReadOnlyList instead of IList :)

But, is it breaking? IReadOnlyList implements IReadOnlyCollection, so all code that works now, should remain working?
It might need recompiling, not 100% sure how the CLI handles that at runtime, is the return type part of the signature?

from json-everything.

Doesn't matter, it still doesn't like it:

Unhandled exception. System.MissingMethodException: Method not found: 'System.Collections.Generic.IReadOnlyCollection`1<Char> MethodSignatureTest.Lib.Extensions.GetContents(System.String)'.
   at Program.<Main>$(String[] args)

When i update only the called assembly from:

namespace MethodSignatureTest.Lib
{
    public static class Extensions
    {

        public static IReadOnlyCollection<char> GetContents(this string data)
        {
            return data.ToCharArray();
        }
    }
}

to:

namespace MethodSignatureTest.Lib
{
    public static class Extensions
    {

        public static IReadOnlyList<char> GetContents(this string data)
        {
            return data.ToCharArray();
        }
    }
}

while living the calling assembly intact:

using MethodSignatureTest.Lib;

var bytes = "hello world".GetContents();

Console.WriteLine("Hello, World:" + bytes.Count);

So yes, the return type is not part of the signature for compilation, but once compiled, it does matter.

from json-everything.

Yeah, I can update those, but it would be a breaking change, so it could be a bit. For now, feel free to just cast them. I'm not doing any transformations from the keywords, so a direct cast will work.

from json-everything.

Return type is part of the signature, but I think you're right. This would be breaking if these methods were on an interface, but not as static methods.

from json-everything.

No, return type is NOT part of the signature. That's why you can't have method overloads that only differ in return type. ;-)

from json-everything.

So yes, the return type is not part of the signature for compilation, but once compiled, it does matter.

Oh dang, you're right.

from json-everything.

@SGStino would you like to submit a PR for these changes?

from json-everything.

Sure, I'll have a look.

Is there any particular reason the enum keyword is build around a collection instead of a list? Shall I take that one with the rest or leave it?

from json-everything.

A collection is more general. There's no reason you should need to access them with an index.

They should also all be read-only.

from json-everything.

Then it should be #707?

from json-everything.