ArgumentOutOfRangeException thrown when calling JsonSchema's Evaluate methods from multiple threads. about json-everything HOT 3 CLOSED

Create new options everytime to call _constraints.Clear()

I would recommend against creating new options for each evaluation. I understand that this is for replicating in the test, but what's the real-world usage?

The recommendation is to have a single options object that is re-used.

from json-everything.

The recommendation is to have a single options object that is re-used.

Yes. This problems can be resolved by changing existing code,
to reuse shared object that is defined as static readonly field.

but what's the real-world usage?

On my use case.
The above solution is sufficient to resolve existing code problems.

from json-everything.

I understand that this behavior is by design.

But it seems unclear from API user.
That It cause constraints re-build every time when passing new EvaluationOptions.

There are some existing code found that using cached JsonSchema object. But passing new option instance everytime.
https://github.com/search?q=%22EvaluationOptions%22+%22schema.Evaluate%22+language%3AC%23&type=code

I thought it's better to add parameter doc comments. (And 6.0.3 release notes)
Some thing like.

> This parameter is expected that same `EvaluationOptions` reference is passed.
> If a different `EvaluationOptions` instance is passed. 
> It must rebuild the constraints. And this operation isn't non-thread safe.
> When using cached schema object. It's recommended to use single `EvaluationOptions`. 

from json-everything.