Custom `IAttributeHandler` never called about json-everything HOT 5 CLOSED

It never really was. The base non-generic version is just so I can hold them all in a list.

Looking at the registration methods, though, it seems they should probably use the generic.

void AddHandler<T>() where T : IAttributeHandler, new()

could be

void AddHandler<THandler, TAttribute>()
    where TAttribute: Attribute
    where THandler : IAttributeHandler<TAttribute>, new()

But that second type parameter feels clunky, which may be why I left it off. You'd have to call this like

AttributeHandler.AddHandler<DisplayAttributeHandler, DisplayAttribute>();

from json-everything.

Thanks for reporting this and for including good reproductions. I'll dig in and see what's going on.

from json-everything.

Ah, you need to use the IAttributeHandler<T> interface.

public class DisplayAttributeHandler : IAttributeHandler<DisplayAttribute>

from json-everything.

Ah. I see. Is the use of the non-generic IAttributeHandler no longer valid?

from json-everything.

Related discussion: dotnet/csharplang#2845

from json-everything.