Git Product home page Git Product logo

Comments (7)

rando2 avatar rando2 commented on August 16, 2024 1

Hi @agitter , Thank you so much for this! I assumed you had some permissions because of manubot. I'll have to figure out what the difference between you and @mprobson is in this repo (weirdly I'm still able to tag you but not him). Hopefully Casey is right and it's something simple like you're watching the repository and he's not. We have some virology folks hopefully coming on board today who are brand new to this platform, so I really appreciate having your feedback on what is and isn't working!

The other plan is I can just give people read permissions as they add themselves to the metadata.yaml, which might not be the best streamlined plan but should probably work just fine!

Edit: It did tag him, it just said it couldn't. Maybe it's just really against nepotism in tagging, the people I've been having trouble tagging are both family members.

from covid19-review.

cgreene avatar cgreene commented on August 16, 2024

We have not figured out a way to do this. Perhaps folks have to watch the repo so they aren't spammed with notifications? I imagine that's what GitHub is trying to avoid.

from covid19-review.

agitter avatar agitter commented on August 16, 2024

I believe anyone can comment on or review a pull request. I left a comment here #11 (review) and do not have any special permissions in this repo.

Similarly, any GitHub user can be tagged in an issue or pull request. They may not show up in the autocomplete, but you can still type or copy/paste their username.

Users also can't add reviewers etc. to their own PRs.

Based on deep review, this is desirable. Outside contributors may not know who is the best reviewer for a section. The project maintainers have the best knowledge of who should review.

from covid19-review.

cgreene avatar cgreene commented on August 16, 2024

@rando2 : I was able to assign @agitter to this issue. I'm not sure if it's because he already replied within the issue or if it's because he's watching the repo. I'm pretty sure you won't have to explicitly grant read permission. Instead, I think that the person has to signal in some way that they're interested to GitHub to avoid using this as a method to spam users.

from covid19-review.

cgreene avatar cgreene commented on August 16, 2024

It must be because he replied here. I cannot assign @MicPie who also watches the repo but who has not replied in this issue.

from covid19-review.

rando2 avatar rando2 commented on August 16, 2024

@cgreene : Interesting, thank you for testing that! From Stack Overflow, it sounds like that is the rule and the strategy is to ask people to leave comments on issues in order to be assigned. I don't love that we'll have to have their GitHub usernames on-hand in order to tag them rather than searching a list of active participants. The other option seems to be to make an organization associated with the project.

from covid19-review.

rando2 avatar rando2 commented on August 16, 2024

I'm giving triage permissions to people as needed-- I think we need to be able to assign people to issues and PRs. I also gave maintainer permissions to @mprobson since he's been making a lot of commits and is a git power user. Happy to change course if there's a better strategy we'd like to follow.

from covid19-review.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.