Git Product home page Git Product logo

Comments (4)

benjie avatar benjie commented on June 27, 2024 1

Weirdly... we already have interval in the codebase:

pg-aggregates/src/AggregateSpecsPlugin.ts

Line 92 in 975eefb

[INTERVAL_OID]: TYPES.interval, // interval -> interval

I think the isNumberLike detection is too narrow:

pg-aggregates/src/AggregateSpecsPlugin.ts

Line 75 in 975eefb

isSuitableType: isNumberLike,
/

pg-aggregates/src/AggregateSpecsPlugin.ts

Lines 30 to 35 in 975eefb

if (pgType.typcategory === "N") {
if (!pgCodec.extensions) {
pgCodec.extensions = Object.create(null);
}
pgCodec.extensions!.isNumberLike = true;
}
.

Looks like it should be relatively straightforward to fix this; just expand to isNumberLike || isIntervalLike (or similar).

from pg-aggregates.

psirenny avatar psirenny commented on June 27, 2024 1

Copy that! We'll submit a PR to add support.

from pg-aggregates.

benjie avatar benjie commented on June 27, 2024

V4 or V5?

from pg-aggregates.

psirenny avatar psirenny commented on June 27, 2024

Sorry, I should have mentioned that it's on V5.

from pg-aggregates.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.